My favorites | Sign in
Logo
                
Details: Show all Hide all

Today

  • 2 hours ago
    issue 1179 (Errors not reported in applet-free testbed) reported by metaweta   -   What steps will reproduce the problem? 1. Cajole var a=b[]; 2. Go to compiler warning/error panel. 3. No error.
    What steps will reproduce the problem? 1. Cajole var a=b[]; 2. Go to compiler warning/error panel. 3. No error.
  • 3 hours ago
    r3913 ([No log message]) committed by ihab.awad   -   [No log message]
    [No log message]
  • 23 hours ago
    issue 1107 (Require a version of the testbed without dependency on apple...) Status changed by jasvir   -   @3901
    Status: Fixed
    @3901
    Status: Fixed
  • 23 hours ago
    r3912 (Sub-class caja runtime exceptions so they are easier to trac...) committed by jasvir   -   Sub-class caja runtime exceptions so they are easier to track and distinguish http://codereview.appspot.com/129056 Creates a new subclass of RuntimeException which the cajoler throws when there it can no longer proceed. Added explanations for a number of these exceptions R=mikesamuel@gmail.com
    Sub-class caja runtime exceptions so they are easier to track and distinguish http://codereview.appspot.com/129056 Creates a new subclass of RuntimeException which the cajoler throws when there it can no longer proceed. Added explanations for a number of these exceptions R=mikesamuel@gmail.com

Yesterday

  • 24 hours ago
    issue 1178 (spurious "folding element head into parent") reported by felix8a   -   prior to r3889, cajoling this: <html></html> succeeded without warnings. after r3899, cajoling that emits 3 warnings: WARNING debug.html:1+1 - 14: folding element html into parent debug.html:1: <html></html> WARNING debug.html:1+7: folding element head into parent debug.html:1: <html></html> WARNING debug.html:1+7: folding element body into parent debug.html:1: <html></html>
    prior to r3889, cajoling this: <html></html> succeeded without warnings. after r3899, cajoling that emits 3 warnings: WARNING debug.html:1+1 - 14: folding element html into parent debug.html:1: <html></html> WARNING debug.html:1+7: folding element head into parent debug.html:1: <html></html> WARNING debug.html:1+7: folding element body into parent debug.html:1: <html></html>
  • 25 hours ago
    r3911 (Cleanup warnings http://codereview.appspot.com/175043 R=j...) committed by mikesamuel   -   Cleanup warnings http://codereview.appspot.com/175043 R=jasvir@gmail.com
    Cleanup warnings http://codereview.appspot.com/175043 R=jasvir@gmail.com
  • 26 hours ago
    r3910 (Moved CajaWebToolsServlet.main into a separate class so that...) committed by mikesamuel   -   Moved CajaWebToolsServlet.main into a separate class so that it doesn't interact badly with appengine.
    Moved CajaWebToolsServlet.main into a separate class so that it doesn't interact badly with appengine.
  • 28 hours ago
    r3909 (A testcase for bug 1029 http://codereview.appspot.com/171054...) committed by mikesamuel   -   A testcase for bug 1029 http://codereview.appspot.com/171054 Bug 1029 seems to have been fixed, but this testcase increases coverage. R=metaweta@gmail.com
    A testcase for bug 1029 http://codereview.appspot.com/171054 Bug 1029 seems to have been fixed, but this testcase increases coverage. R=metaweta@gmail.com
  • 29 hours ago
    Debugging (How to debug Caja applications) Wiki page edited by ihab.awad   -   Revision r3908 Edited wiki page through web user interface.
    Revision r3908 Edited wiki page through web user interface.
  • 29 hours ago
    r3907 ([No log message]) committed by ihab.awad   -   [No log message]
    [No log message]
  • 30 hours ago
    Debugging (How to debug Caja applications) Wiki page edited by ihab.awad   -   Revision r3904 Edited wiki page through web user interface.
    Revision r3904 Edited wiki page through web user interface.
  • 30 hours ago
    Debugging (How to debug Caja applications) Wiki page edited by ihab.awad   -   Revision r3903 Edited wiki page through web user interface.
    Revision r3903 Edited wiki page through web user interface.
  • 30 hours ago
    Debugging (How to debug Caja applications) Wiki page edited by ihab.awad   -   Revision r3902 Edited wiki page through web user interface.
    Revision r3902 Edited wiki page through web user interface.
  • 40 hours ago
    r3901 (A applet-free testbed http://codereview.appspot.com/116069 ...) committed by jasvir   -   A applet-free testbed http://codereview.appspot.com/116069 A caja testbed that uses the cajoling service instead of an applet to perform the cajoling. (See http://10.latest.caja.appspot.com for an example of it running). * Adds a series of examples of the attacks caja prevents and interactions it supports * Adds gwt libraries needed to use the front-end during development * The changes to Normalizer are needed to handle the varing availability of java's Normalizer depending on the version of Java and on AppEngine * Adds support for HTTP POST * Adds the original cajoling service to the war R=ihab.awad@gmail.com
    A applet-free testbed http://codereview.appspot.com/116069 A caja testbed that uses the cajoling service instead of an applet to perform the cajoling. (See http://10.latest.caja.appspot.com for an example of it running). * Adds a series of examples of the attacks caja prevents and interactions it supports * Adds gwt libraries needed to use the front-end during development * The changes to Normalizer are needed to handle the varing availability of java's Normalizer depending on the version of Java and on AppEngine * Adds support for HTTP POST * Adds the original cajoling service to the war R=ihab.awad@gmail.com
  • 43 hours ago
    issue 1156 (JSON.parse infinite loop in browsers with native JSON) commented on by lucas.e.smith   -   Yes. The issue doesn't arise with browsers that don't have native JSON support.
    Yes. The issue doesn't arise with browsers that don't have native JSON support.
  • 47 hours ago
    issue 1029 (Css UriLiterals do not clone properly if URI has no scheme) Status changed by mikesamuel   -   Seems to be working as of revision 3900.
    Status: Fixed
    Seems to be working as of revision 3900.
    Status: Fixed
  • 47 hours ago
    issue 1172 (window is undefined in the testbed) commented on by mikesamuel   -   Ok. Hopefully it's applet weirdness that won't bite us once we bury the applet testbed, but let's remember it in case we see it again.
    Ok. Hopefully it's applet weirdness that won't bite us once we bury the applet testbed, but let's remember it in case we see it again.
  • 47 hours ago
    issue 1156 (JSON.parse infinite loop in browsers with native JSON) changed by mikesamuel   -   Is it the case that all these browsers support native JSON, hence that code path is exercised?
    Status: Accepted
    Owner: mikesamuel
    Is it the case that all these browsers support native JSON, hence that code path is exercised?
    Status: Accepted
    Owner: mikesamuel
  • 47 hours ago
    issue 1177 (NPE in Namespaces.java:131) Status changed by mikesamuel   -  
    Status: Pending
    Status: Pending
  • 47 hours ago

Last 7 days

  • Dec 09, 2009
    r3900 (bad html attributes downgraded to a warning http://coderevie...) committed by felix8a   -   bad html attributes downgraded to a warning http://codereview.appspot.com/164070 Prior to r3844, html with an invalid attr like <div title='bob's foo'> would have the bad "foo'" attribute deleted with a warning. r3844 changed that to be a fatal error. Bad attributes are unfortunately common, for many reasons. Usually because they're typos of some sort. This CL downgrades the error to a warning. R=mikesamuel@gmail.com
    bad html attributes downgraded to a warning http://codereview.appspot.com/164070 Prior to r3844, html with an invalid attr like <div title='bob's foo'> would have the bad "foo'" attribute deleted with a warning. r3844 changed that to be a fatal error. Bad attributes are unfortunately common, for many reasons. Usually because they're typos of some sort. This CL downgrades the error to a warning. R=mikesamuel@gmail.com
  • Dec 09, 2009
    issue 1172 (window is undefined in the testbed) Status changed by metaweta   -   After rebooting my browser and doing a clean build, both these issues went away.
    Status: Invalid
    After rebooting my browser and doing a clean build, both these issues went away.
    Status: Invalid
  • Dec 09, 2009
    issue 1165 (domita_test testCustomEvent fails on opera 10) Status changed by mikesamuel   -   Fixed @3899
    Status: Fixed
    Fixed @3899
    Status: Fixed
  • Dec 09, 2009
    r3899 (Issue 1165: fixed testCustomEvent on opera http://codereview...) committed by mikesamuel   -   Issue 1165 : fixed testCustomEvent on opera http://codereview.appspot.com/167059 Opera supports both addEventListener and attachEvent but events created using the DOM standard mechanism can only be dispatched to listeners added using addEventListener. R=felix8a@gmail.com
    Issue 1165 : fixed testCustomEvent on opera http://codereview.appspot.com/167059 Opera supports both addEventListener and attachEvent but events created using the DOM standard mechanism can only be dispatched to listeners added using addEventListener. R=felix8a@gmail.com
  • Dec 09, 2009
    issue 1177 (NPE in Namespaces.java:131) changed by mikesamuel   -   Ok, so rewriters that are a core part of the shindig project would need to be changed. And possibly some proprietary client specific code that does similar things would also need to be changed.
    Status: Accepted
    Owner: mikesamuel
    Ok, so rewriters that are a core part of the shindig project would need to be changed. And possibly some proprietary client specific code that does similar things would also need to be changed.
    Status: Accepted
    Owner: mikesamuel
  • Dec 09, 2009
    issue 1174 (bridal <button> clone in ie[67]) Status changed by mikesamuel   -   Submitted @3898
    Status: Fixed
    Submitted @3898
    Status: Fixed
  • Dec 09, 2009
    r3898 (Issue 1174 - <button>.cloneNode fails on IE http://coderevie...) committed by mikesamuel   -   Issue 1174 - <button>.cloneNode fails on IE http://codereview.appspot.com/165098 http://code.google.com/p/google-caja/issues/detail?id=1174 ie[67] doesn't let you change a button's type after it's created. it's the same as the <input> type problem, you have to specify the type in createElement. bridal's cloneNode handles <input> correctly but not <button. This change fixes constructClone in bridal.js. I also checked html4-attributes-defs.json to see whether there are any other nodes with a "type" or "value" attribute that need to be fixed up. The only other ones are PARAM and LI, UK, OL, and disallowed elements like OBJECT and LINK, none of which are inputs. R=felix8a@gmail.com
    Issue 1174 - <button>.cloneNode fails on IE http://codereview.appspot.com/165098 http://code.google.com/p/google-caja/issues/detail?id=1174 ie[67] doesn't let you change a button's type after it's created. it's the same as the <input> type problem, you have to specify the type in createElement. bridal's cloneNode handles <input> correctly but not <button. This change fixes constructClone in bridal.js. I also checked html4-attributes-defs.json to see whether there are any other nodes with a "type" or "value" attribute that need to be fixed up. The only other ones are PARAM and LI, UK, OL, and disallowed elements like OBJECT and LINK, none of which are inputs. R=felix8a@gmail.com
  • Dec 09, 2009
    issue 1177 (NPE in Namespaces.java:131) commented on by gilles.devaux   -   TemplateRewriter, HTMLContentRewriter... pretty much all of them. Mutating the DOM is how Shindig is creating the final output. GadgetHtmlParser.normalizeFragment() also uses createElement()
    TemplateRewriter, HTMLContentRewriter... pretty much all of them. Mutating the DOM is how Shindig is creating the final output. GadgetHtmlParser.normalizeFragment() also uses createElement()
  • Dec 09, 2009
    issue 1177 (NPE in Namespaces.java:131) commented on by mikesamuel   -   Which rewriters?
    Which rewriters?
  • Dec 09, 2009
    issue 1177 (NPE in Namespaces.java:131) commented on by gilles.devaux   -   Thing is the document is heavily mutated by the rewriters, all createElement() would have to be replaced by createElementNS(). I don't know what's the best solution here.
    Thing is the document is heavily mutated by the rewriters, all createElement() would have to be replaced by createElementNS(). I don't know what's the best solution here.
  • Dec 08, 2009
    issue 1165 (domita_test testCustomEvent fails on opera 10) changed by mikesamuel   -   http://codereview.appspot.com/167059
    Status: Pending
    Owner: mikesamuel
    http://codereview.appspot.com/167059
    Status: Pending
    Owner: mikesamuel
  • Dec 08, 2009
    issue 1176 (Ant build target "demos" fails with build.xml format error) Status changed by mikesamuel   -   Submitted @3897
    Status: Fixed
    Submitted @3897
    Status: Fixed
  • Dec 08, 2009
    r3897 (Fix issue 1176: ant demos fails with ANT error http://codere...) committed by mikesamuel   -   Fix issue 1176 : ant demos fails with ANT error http://codereview.appspot.com/167054 http://code.google.com/p/google-caja/issues/detail?id=1176 > What steps will reproduce the problem? 1. Checkout using svn (or git-svn) 2. (cd caja && ant demos) > What do you see instead? BUILD FAILED /opt/svn/google-caja/build.xml:1121: transform doesn't support the nested "include" element. R=metaweta@gmail.com
    Fix issue 1176 : ant demos fails with ANT error http://codereview.appspot.com/167054 http://code.google.com/p/google-caja/issues/detail?id=1176 > What steps will reproduce the problem? 1. Checkout using svn (or git-svn) 2. (cd caja && ant demos) > What do you see instead? BUILD FAILED /opt/svn/google-caja/build.xml:1121: transform doesn't support the nested "include" element. R=metaweta@gmail.com
  • Dec 08, 2009
    issue 1172 (window is undefined in the testbed) commented on by metaweta   -   It was the applet-based one, but now I'm getting an NPE there: java.lang.NullPointerException at com.google.caja.parser.html.DomParser.makeDocument(DomParser.java:168) at com.google.caja.parser.html.DomParser.parseFragment(DomParser.java:254) at com.google.caja.opensocial.DefaultGadgetRewriter.parseHtml(DefaultGadgetRewriter.java:186) at com.google.caja.opensocial.DefaultGadgetRewriter.rewriteContent(DefaultGadgetRewriter.java:165) at com.google.caja.opensocial.DefaultGadgetRewriter.rewriteContent(DefaultGadgetRewriter.java:128) at com.google.caja.demos.applet.CajaApplet.runCajoler(CajaApplet.java:179) at com.google.caja.demos.applet.CajaApplet.cajole(CajaApplet.java:133)
    It was the applet-based one, but now I'm getting an NPE there: java.lang.NullPointerException at com.google.caja.parser.html.DomParser.makeDocument(DomParser.java:168) at com.google.caja.parser.html.DomParser.parseFragment(DomParser.java:254) at com.google.caja.opensocial.DefaultGadgetRewriter.parseHtml(DefaultGadgetRewriter.java:186) at com.google.caja.opensocial.DefaultGadgetRewriter.rewriteContent(DefaultGadgetRewriter.java:165) at com.google.caja.opensocial.DefaultGadgetRewriter.rewriteContent(DefaultGadgetRewriter.java:128) at com.google.caja.demos.applet.CajaApplet.runCajoler(CajaApplet.java:179) at com.google.caja.demos.applet.CajaApplet.cajole(CajaApplet.java:133)
  • Dec 08, 2009
    issue 1154 (selectEl.options.selectedIndex is undefined) Status changed by metaweta   -   @3896
    Status: Fixed
    @3896
    Status: Fixed
  • Dec 08, 2009
    r3896 (Fixes issue 1154, selectEl.options.selectedIndex. http://cod...) committed by metaweta   -   Fixes issue 1154 , selectEl.options.selectedIndex. http://codereview.appspot.com/166045 Exposes the selectedIndex property on an options nodelist. R=jasvir@gmail.com
    Fixes issue 1154 , selectEl.options.selectedIndex. http://codereview.appspot.com/166045 Exposes the selectedIndex property on an options nodelist. R=jasvir@gmail.com
  • Dec 08, 2009
    issue 1172 (window is undefined in the testbed) commented on by mikesamuel   -   Which testbed? The applet based one or the applet-free one?
    Which testbed? The applet based one or the applet-free one?
  • Dec 08, 2009
    issue 1174 (bridal <button> clone in ie[67]) changed by mikesamuel   -   http://codereview.appspot.com/165098
    Status: Pending
    Owner: mikesamuel
    http://codereview.appspot.com/165098
    Status: Pending
    Owner: mikesamuel
  • Dec 08, 2009
    issue 1176 (Ant build target "demos" fails with build.xml format error) changed by mikesamuel   -   http://codereview.appspot.com/167054
    Status: Pending
    Owner: mikesamuel
    http://codereview.appspot.com/167054
    Status: Pending
    Owner: mikesamuel
  • Dec 08, 2009
    issue 1176 (Ant build target "demos" fails with build.xml format error) commented on by mikesamuel   -   This is cruft left over from http://code.google.com/p/google-caja/source/detail?r=3841
  • Dec 08, 2009
    issue 1177 (NPE in Namespaces.java:131) Cc changed by mikesamuel   -   Ok. So Shindig parses it as a non-namespace aware document. I think Fargo is updating Shindig to use a namespace aware parser. In the meantime, we can probably treat a null namespace as HTML as long as the qualified name contains no :.
    Cc: johnfargo
    Ok. So Shindig parses it as a non-namespace aware document. I think Fargo is updating Shindig to use a namespace aware parser. In the meantime, we can probably treat a null namespace as HTML as long as the qualified name contains no :.
    Cc: johnfargo
  • Dec 08, 2009
    issue 1177 (NPE in Namespaces.java:131) commented on by gilles.devaux   -   sure content is the MutableContent of Shindig Document doc = content.getDocument(); Node root = doc.createDocumentFragment(); root.appendChild(doc.getDocumentElement()); Note: Node root = doc.getDocumentElement(); produces the same result
    sure content is the MutableContent of Shindig Document doc = content.getDocument(); Node root = doc.createDocumentFragment(); root.appendChild(doc.getDocumentElement()); Note: Node root = doc.getDocumentElement(); produces the same result
  • Dec 08, 2009
    issue 1177 (NPE in Namespaces.java:131) commented on by mikesamuel   -   NPE is definitely not the best diagnostic. Giles, can you explain how rootNode was created?
    NPE is definitely not the best diagnostic. Giles, can you explain how rootNode was created?
  • Dec 08, 2009
    issue 1177 (NPE in Namespaces.java:131) commented on by felix8a   -   I think this is because caja now requires incoming dom nodes to be namespace qualified. NPE is perhaps not the best diagnostic. maybe a null namespace should be treated as equivalent to Namespaces.HTML_NAMESPACE_URI?
    I think this is because caja now requires incoming dom nodes to be namespace qualified. NPE is perhaps not the best diagnostic. maybe a null namespace should be treated as equivalent to Namespaces.HTML_NAMESPACE_URI?
  • Dec 08, 2009
    issue 1177 (NPE in Namespaces.java:131) reported by gilles.devaux   -   Create the internal DOM from an existing org.w3c.dom.DocumentFragment -> compiler.addInput(AncestorChain.instance(new Dom(rootNode))); compiler.run() throws NPE stack: at com.google.caja.parser.html.Namespaces.forUri(Namespaces.java:131) at com.google.caja.parser.html.ElKey.forElement(ElKey.java:92) at com.google.caja.plugin.templates.TemplateSanitizer.sanitize(TemplateSanitizer.java:74) at com.google.caja.plugin.templates.TemplateSanitizer.sanitize(TemplateSanitizer.java:68) at com.google.caja.plugin.stages.SanitizeHtmlStage.apply(SanitizeHtmlStage.java:46) at com.google.caja.plugin.stages.SanitizeHtmlStage.apply(SanitizeHtmlStage.java:32) at com.google.caja.util.Pipeline.applyStage(Pipeline.java:41) at com.google.caja.plugin.PluginCompiler$1.applyStage(PluginCompiler.java:122) at com.google.caja.plugin.PluginCompiler$1.applyStage(PluginCompiler.java:116) at com.google.caja.util.Pipeline.apply(Pipeline.java:35) at com.google.caja.plugin.PluginCompiler.run(PluginCompiler.java:194) In ElKey.java:92 -> 90 String uri = el.getNamespaceURI(); 91 String localName = el.getLocalName(); 92 Namespaces ns = Namespaces.HTML_DEFAULT.forUri(uri); -> uri is ‘null’, Namespaces.forUri(uri) does not like null
    Create the internal DOM from an existing org.w3c.dom.DocumentFragment -> compiler.addInput(AncestorChain.instance(new Dom(rootNode))); compiler.run() throws NPE stack: at com.google.caja.parser.html.Namespaces.forUri(Namespaces.java:131) at com.google.caja.parser.html.ElKey.forElement(ElKey.java:92) at com.google.caja.plugin.templates.TemplateSanitizer.sanitize(TemplateSanitizer.java:74) at com.google.caja.plugin.templates.TemplateSanitizer.sanitize(TemplateSanitizer.java:68) at com.google.caja.plugin.stages.SanitizeHtmlStage.apply(SanitizeHtmlStage.java:46) at com.google.caja.plugin.stages.SanitizeHtmlStage.apply(SanitizeHtmlStage.java:32) at com.google.caja.util.Pipeline.applyStage(Pipeline.java:41) at com.google.caja.plugin.PluginCompiler$1.applyStage(PluginCompiler.java:122) at com.google.caja.plugin.PluginCompiler$1.applyStage(PluginCompiler.java:116) at com.google.caja.util.Pipeline.apply(Pipeline.java:35) at com.google.caja.plugin.PluginCompiler.run(PluginCompiler.java:194) In ElKey.java:92 -> 90 String uri = el.getNamespaceURI(); 91 String localName = el.getLocalName(); 92 Namespaces ns = Namespaces.HTML_DEFAULT.forUri(uri); -> uri is ‘null’, Namespaces.forUri(uri) does not like null
  • Dec 06, 2009
    issue 1175 (Make available a deterministic version of Cajita) commented on by erights   -   Trying again. See http://code.google.com/p/v8/issues/detail?id=436
  • Dec 06, 2009
    issue 1175 (Make available a deterministic version of Cajita) commented on by erights   -   See http://code.google.com/p/v8/issues/detail? q=ecmascript&colspec=ID%20Type%20Status%20Priority%20Owner%20Summary%20HW %20OS%20Area%20Stars&sort=priority&id=436
    See http://code.google.com/p/v8/issues/detail? q=ecmascript&colspec=ID%20Type%20Status%20Priority%20Owner%20Summary%20HW %20OS%20Area%20Stars&sort=priority&id=436

Last 30 days

  • Dec 04, 2009
    FinallySkipped (finally blocks can fail to execute in one script block and c...) Wiki page edited by mikesamuel   -   Revision r3895 Edited wiki page through web user interface.
    Revision r3895 Edited wiki page through web user interface.
  • Dec 04, 2009
    FinallySkipped ({{{finally}}} blocks can fail to execute in one script block...) Wiki page added by mikesamuel   -   Revision r3894 Created wiki page through web user interface.
    Revision r3894 Created wiki page through web user interface.
  • Dec 04, 2009
    AttackVectors (Interpreter&Browser properties that can be exploited to esca...) Wiki page edited by mikesamuel   -   Revision r3893 Edited wiki page through web user interface.
    Revision r3893 Edited wiki page through web user interface.