Today
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r473
Explain inclusion of _next_parameter_size in frame size.
Revision r473
Explain inclusion of _next_parameter_size in frame size.
Yesterday
Last 7 days
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r472
Refine STACK CFI spec.
Revision r472
Refine STACK CFI spec.
-
r471
(Issue 49012: Breakpad Processor: Rename 'StackFrameInfo' str...) committed by jimblandy
- Issue 49012: Breakpad Processor: Rename 'StackFrameInfo' structure to 'WindowsFrameInfo'.
Also, rename stack_frame_info.h to windows_frame_info.h.
If it seems odd to have functions like FillSourceLineInfo returning
Windows-specific data structures... well, it is! This patch just makes
it more obvious what's going on.
a=jimblandy, r=nealsid
Issue 49012: Breakpad Processor: Rename 'StackFrameInfo' structure to 'WindowsFrameInfo'.
Also, rename stack_frame_info.h to windows_frame_info.h.
If it seems odd to have functions like FillSourceLineInfo returning
Windows-specific data structures... well, it is! This patch just makes
it more obvious what's going on.
a=jimblandy, r=nealsid
-
r470
(Breakpad: Regenerate build files with latest versions of aut...) committed by jimblandy
- Breakpad: Regenerate build files with latest versions of autotools.
This patch refreshes the build system files to those generated by:
- Libtool 2.2.6
- Automake 1.11
- Autoconf 2.64
a=jimblandy, r=nealsid
Breakpad: Regenerate build files with latest versions of autotools.
This patch refreshes the build system files to those generated by:
- Libtool 2.2.6
- Automake 1.11
- Autoconf 2.64
a=jimblandy, r=nealsid
-
r469
(Breakpad processor: Use unsigned constants in comparisons, t...) committed by jimblandy
- Breakpad processor: Use unsigned constants in comparisons, to quiet compiler warnings.
This patch avoids comparisons between signed and unsigned values, as
warned about by G++ 4.4.1.
a=jimblandy, r=nealsid
Breakpad processor: Use unsigned constants in comparisons, to quiet compiler warnings.
This patch avoids comparisons between signed and unsigned values, as
warned about by G++ 4.4.1.
a=jimblandy, r=nealsid
-
r468
(Breakpad Linux Dumper: Fix up comments in google_breakpad::M...) committed by jimblandy
- Breakpad Linux Dumper: Fix up comments in google_breakpad::Module interface.
Use the term "own", since ownership is the concept at work here.
a=jimblandy, r=nealsid
Breakpad Linux Dumper: Fix up comments in google_breakpad::Module interface.
Use the term "own", since ownership is the concept at work here.
a=jimblandy, r=nealsid
-
r467
(Issue 49003: Breakpad Linux Dumper: Add unit tests for STABS...) committed by jimblandy
- Issue 49003: Breakpad Linux Dumper: Add unit tests for STABS dumper.
Previous patches added unit tests for the STABS parser and the
Breakpad symbol file writer; this adds unit tests for the "dumper"
class that sits between them, receiving data from the parser and
handing it to the writer. So now the whole pathway has coverage.
a=jimblandy, r=nealsid
Issue 49003: Breakpad Linux Dumper: Add unit tests for STABS dumper.
Previous patches added unit tests for the STABS parser and the
Breakpad symbol file writer; this adds unit tests for the "dumper"
class that sits between them, receiving data from the parser and
handing it to the writer. So now the whole pathway has coverage.
a=jimblandy, r=nealsid
-
r466
(Breakpad Linux dumper: Add unit tests for google_breakpad::M...) committed by jimblandy
- Breakpad Linux dumper: Add unit tests for google_breakpad::Module.
Adjust Module's interface a bit to facilitate testing:
- Make AssignSourceIds something a client can call --- it's perfectly
well-defined, so this is an okay change.
- Add GetFunctions, GetFiles and FindExistingfile member functions,
which the test harness will use to get results to examine.
a=jimblandy, r=nealsid
Breakpad Linux dumper: Add unit tests for google_breakpad::Module.
Adjust Module's interface a bit to facilitate testing:
- Make AssignSourceIds something a client can call --- it's perfectly
well-defined, so this is an okay change.
- Add GetFunctions, GetFiles and FindExistingfile member functions,
which the test harness will use to get results to examine.
a=jimblandy, r=nealsid
-
r465
(Breakpad Linux Dumper: Use proper sizes and radixes when wri...) committed by jimblandy
- Breakpad Linux Dumper: Use proper sizes and radixes when writing Breakpad symbol files.
A FUNC record's parameter size is also hexadecimal, and all values are
64 bits wide.
A line record's address and size are 64 bits wide.
a=jimblandy, r=nealsid
Breakpad Linux Dumper: Use proper sizes and radixes when writing Breakpad symbol files.
A FUNC record's parameter size is also hexadecimal, and all values are
64 bits wide.
A line record's address and size are 64 bits wide.
a=jimblandy, r=nealsid
-
r464
(Breakpad Linux dumper: move DumpStabsHandler into its own fi...) committed by jimblandy
- Breakpad Linux dumper: move DumpStabsHandler into its own file, for testing.
This will make it easier to write unit tests for DumpStabsHandler.
a=jimblandy, r=nealsid
Breakpad Linux dumper: move DumpStabsHandler into its own file, for testing.
This will make it easier to write unit tests for DumpStabsHandler.
a=jimblandy, r=nealsid
-
r463
(fix compilation on 64-bit, followup from issue 357) committed by ted.mielczarek
- fix compilation on 64-bit, followup from issue 357
fix compilation on 64-bit, followup from issue 357
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by nealsid
- Revision r462
Edited wiki page through web user interface.
Revision r462
Edited wiki page through web user interface.
-
-
Last 30 days
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r460
Note how register names are established.
Revision r460
Note how register names are established.
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r459
Correct description of STACK WIN-based frame walking.
Revision r459
Correct description of STACK WIN-based frame walking.
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r458
Finished STACK WIN description.
Revision r458
Finished STACK WIN description.
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r457
Edited wiki page through web user interface.
Revision r457
Edited wiki page through web user interface.
-
SymbolFiles
(Breakpad's symbol file format) Wiki page edited by jimblandy
- Revision r456
Filled in descriptions of PUBLIC records.
Revision r456
Filled in descriptions of PUBLIC records.
-
r455
(fix a badly-applied patch, and also re-run automake which I ...) committed by ted.mielczarek
- fix a badly-applied patch, and also re-run automake which I forgot to do
fix a badly-applied patch, and also re-run automake which I forgot to do
-
-
r453
(Breakpad DWARF parser: Fix up documentation for DWARF reader...) committed by jimblandy
- Breakpad DWARF parser: Fix up documentation for DWARF reader classes.
Fix typos.
For CompilationUnit::Start, I was confused by the '-' in the original
comment, taking it for a parenthetic clause marker, assuming an
implicit "of the next compilation unit" at the end of the sentence.
The comments should refer to the ".debug_info" section, not the
"debug_info" section. The latter is not the section name actually used
on any system (ELF or Mach-O), and the former is the name prescribed
by the DWARF spec.
Some of the comments for ProcessAttribute* member functions claim that
OFFSET is from the start of the compilation unit, but that's not so:
the code has always passed an offset relative to the start of the
.debug_info section.
a=jimblandy, r=nealsid
Breakpad DWARF parser: Fix up documentation for DWARF reader classes.
Fix typos.
For CompilationUnit::Start, I was confused by the '-' in the original
comment, taking it for a parenthetic clause marker, assuming an
implicit "of the next compilation unit" at the end of the sentence.
The comments should refer to the ".debug_info" section, not the
"debug_info" section. The latter is not the section name actually used
on any system (ELF or Mach-O), and the former is the name prescribed
by the DWARF spec.
Some of the comments for ProcessAttribute* member functions claim that
OFFSET is from the start of the compilation unit, but that's not so:
the code has always passed an offset relative to the start of the
.debug_info section.
a=jimblandy, r=nealsid
-
-
r452
(Fix build break for 64-bit compilation.
A=Gregory Dardyk
R=n...) committed by nealsid
- Fix build break for 64-bit compilation.
A=Gregory Dardyk
R=nealsid
Fix build break for 64-bit compilation.
A=Gregory Dardyk
R=nealsid
-
-
-
-
r450
(Issue 41004: Breakpad DWARF parser: fixes to compile without...) committed by jimblandy
- Issue 41004: Breakpad DWARF parser: fixes to compile without warnings under GNU C++ 4.3.3.
a=jimblandy, r=nealsid
Issue 41004: Breakpad DWARF parser: fixes to compile without warnings under GNU C++ 4.3.3.
a=jimblandy, r=nealsid
-
r449
(Issue 41003: Breakpad DWARF parser: Include <cstdio>, since ...) committed by jimblandy
- Issue 41003: Breakpad DWARF parser: Include <cstdio>, since we use it
src/common/dwarf/dwarf2reader.cc uses the old-fashioned <stdio.h>
facilities to report errors. Ideally, we would add a 'Warning' message
to the handler and make the client responsible for dealing with the
errors, but this at least allows us to compile.
Ubuntu 9.10 uses GCC 4.4.1; under older versions of GCC, this wasn't a
problem, probably because stdio.h was being brought in inadvertently
somewhere else.
a=jimblandy, r=nealsid
Issue 41003: Breakpad DWARF parser: Include <cstdio>, since we use it
src/common/dwarf/dwarf2reader.cc uses the old-fashioned <stdio.h>
facilities to report errors. Ideally, we would add a 'Warning' message
to the handler and make the client responsible for dealing with the
errors, but this at least allows us to compile.
Ubuntu 9.10 uses GCC 4.4.1; under older versions of GCC, this wasn't a
problem, probably because stdio.h was being brought in inadvertently
somewhere else.
a=jimblandy, r=nealsid
-
r448
(Issue 42002: Breakpad DWARF parser: avoid using <stdint.h> t...) committed by jimblandy
- Issue 42002: Breakpad DWARF parser: avoid using <stdint.h> type
It seems that a use of the <stdint.h> type uintptr_t has crept into
the DWARF parser. This defines a workaround for the GNU compilers
(tested on both Mac and Linux) which will raise an error if it doesn't
work.
My personal preference would be just to assume that the <stdint.h>
header is available and use the standard types everywhere, but 1) that
would be a large change, likely to make merges with the other branches
of the DWARF parser more difficult, and 2) it would make it quite
difficult to build under Microsoft Visual Studio, which doesn't have
the <stdint.h> header; Microsoft has said they have no plans to
provide it, as they would rather "focus their efforts" on C++ and
.NET.
a=jimblandy, r=nealsid
Issue 42002: Breakpad DWARF parser: avoid using <stdint.h> type
It seems that a use of the <stdint.h> type uintptr_t has crept into
the DWARF parser. This defines a workaround for the GNU compilers
(tested on both Mac and Linux) which will raise an error if it doesn't
work.
My personal preference would be just to assume that the <stdint.h>
header is available and use the standard types everywhere, but 1) that
would be a large change, likely to make merges with the other branches
of the DWARF parser more difficult, and 2) it would make it quite
difficult to build under Microsoft Visual Studio, which doesn't have
the <stdint.h> header; Microsoft has said they have no plans to
provide it, as they would rather "focus their efforts" on C++ and
.NET.
a=jimblandy, r=nealsid
-
r447
(Issue 42001: Breakpad Linux Dumper: remove compilation warni...) committed by jimblandy
- Issue 42001: Breakpad Linux Dumper: remove compilation warnings in guid_creator.cc.
Building on Ubuntu 9.10 with the distributed compiler (GCC 4.4.1), we get
warnings like the following:
guid_creator.cc:56: warning: dereferencing type-punned pointer will break strict-aliasing rules
It doesn't matter in this case, but there's no crying need to use
reinterpret casts in an endian-dependent way when there are plenty of
well-defined ways to get the same effect.
a=jimblandy, r=nealsid
Issue 42001: Breakpad Linux Dumper: remove compilation warnings in guid_creator.cc.
Building on Ubuntu 9.10 with the distributed compiler (GCC 4.4.1), we get
warnings like the following:
guid_creator.cc:56: warning: dereferencing type-punned pointer will break strict-aliasing rules
It doesn't matter in this case, but there's no crying need to use
reinterpret casts in an endian-dependent way when there are plenty of
well-defined ways to get the same effect.
a=jimblandy, r=nealsid
-
r446
(Issue 39002: Breakpad DWARF parser: Move DWARF parser to pla...) committed by jimblandy
- Issue 39002: Breakpad DWARF parser: Move DWARF parser to platform-independent directory.
Move the DWARF parser, and the functioninfo.cc DWARF consumer, from
src/common/mac/dwarf to src/commmon/dwarf, so that it can be shared
between the Mac and Linux dumpers.
Fix up #include directives, multiple inclusion protection macros, and
Xcode build files.
a=jimblandy, r=nealsid
Issue 39002: Breakpad DWARF parser: Move DWARF parser to platform-independent directory.
Move the DWARF parser, and the functioninfo.cc DWARF consumer, from
src/common/mac/dwarf to src/commmon/dwarf, so that it can be shared
between the Mac and Linux dumpers.
Fix up #include directives, multiple inclusion protection macros, and
Xcode build files.
a=jimblandy, r=nealsid
-
r445
(Issue 26001: Linux dumper: fix comments in STABS reader
Typ...) committed by jimblandy
- Issue 26001: Linux dumper: fix comments in STABS reader
Typos; ambiguities; dangling references to arguments whose names got
changed.
a=jimblandy, r=nealsid
Issue 26001: Linux dumper: fix comments in STABS reader
Typos; ambiguities; dangling references to arguments whose names got
changed.
a=jimblandy, r=nealsid
-
r444
(Linux dumper: Add unit tests for google_breakpad::StabsReade...) committed by jimblandy
- Linux dumper: Add unit tests for google_breakpad::StabsReader.
The test system is based on Google C++ Testing Framework and the
Google C++ Mocking Framework.
This includes a parser that turns human-readable input files ("mock
stabs") into .stab and .stabstr section contents, which we can then
pass to a StabsReader instance, using a handler object written with
GoogleMock. The 'make check' target in src/tools/linux/dump_syms runs
this.
The supplied input file is pretty small, but I've done coverage
testing, and it does cover the parser.
I thought the mock stabs parser would be less elaborate than it turned
out to be. Lesson learned.
a=jimblandy, r=nealsid
Linux dumper: Add unit tests for google_breakpad::StabsReader.
The test system is based on Google C++ Testing Framework and the
Google C++ Mocking Framework.
This includes a parser that turns human-readable input files ("mock
stabs") into .stab and .stabstr section contents, which we can then
pass to a StabsReader instance, using a handler object written with
GoogleMock. The 'make check' target in src/tools/linux/dump_syms runs
this.
The supplied input file is pretty small, but I've done coverage
testing, and it does cover the parser.
I thought the mock stabs parser would be less elaborate than it turned
out to be. Lesson learned.
a=jimblandy, r=nealsid
-
-
r443
(Issue 25003: Linux dumper: Fix infinite loop in stabs parser...) committed by jimblandy
- Issue 25003: Linux dumper: Fix infinite loop in stabs parser.
If the input passed to a StabsReader instance contains a compilation
unit whose first entry is an N_SO with no name, the parser enters an
infinite loop. Since such entries mark the end of a compilation unit,
ProcessCompilationUnit should skip them.
a=jimblandy, r=nealsid
Issue 25003: Linux dumper: Fix infinite loop in stabs parser.
If the input passed to a StabsReader instance contains a compilation
unit whose first entry is an N_SO with no name, the parser enters an
infinite loop. Since such entries mark the end of a compilation unit,
ProcessCompilationUnit should skip them.
a=jimblandy, r=nealsid
-
r442
(Issue 25002: Linux symbol dumper: Require STABS consumers to...) committed by jimblandy
- Issue 25002: Linux symbol dumper: Require STABS consumers to provide a Warning member.
The StabsHandler class should not provide a fallback definition for
its Warning member function that just throws away warning messages.
It should require the consumer to provide an appropriate definition.
a=jimblandy, r=nealsid
Issue 25002: Linux symbol dumper: Require STABS consumers to provide a Warning member.
The StabsHandler class should not provide a fallback definition for
its Warning member function that just throws away warning messages.
It should require the consumer to provide an appropriate definition.
a=jimblandy, r=nealsid
-
r441
(Issue 39001: Breakpad Linux dumper: Refactor Makefile.
Use ...) committed by jimblandy
- Issue 39001: Breakpad Linux dumper: Refactor Makefile.
Use GNU Make features to make the dumper, unit tests, and maintenance
targets more independent, so I get fewer conflicts as I work on
different parts of the patch series.
In particular:
- Provide targets to run tests and produce test coverage reports.
- Gather C and C++ build rules in one place.
- Avoid variables that list object files, as pattern rules can compute
these values directly from the dependencies.
- Use VPATH to find sources in other directories.
a=jimb, r=nealsid
Issue 39001: Breakpad Linux dumper: Refactor Makefile.
Use GNU Make features to make the dumper, unit tests, and maintenance
targets more independent, so I get fewer conflicts as I work on
different parts of the patch series.
In particular:
- Provide targets to run tests and produce test coverage reports.
- Gather C and C++ build rules in one place.
- Avoid variables that list object files, as pattern rules can compute
these values directly from the dependencies.
- Use VPATH to find sources in other directories.
a=jimb, r=nealsid
-
r440
(Mozilla bug 532713 - OS X client code doesn't decoded extend...) committed by ted.mielczarek
- Mozilla bug 532713 - OS X client code doesn't decoded extended family ids in CPU info. Patch by Jeff
Muizelaar <jmuizelaar@mozilla.com>, r=me
Mozilla bug 532713 - OS X client code doesn't decoded extended family ids in CPU info. Patch by Jeff
Muizelaar <jmuizelaar@mozilla.com>, r=me
-
r439
(Fix some build warnings
A=zhurunz
R=nealsid
) committed by nealsid
- Fix some build warnings
A=zhurunz
R=nealsid
Fix some build warnings
A=zhurunz
R=nealsid
-
-
-
issue 355
(dump_syms dead loop) changed by jimblandy
-
Status:
Started
Owner:
jimblandy
Status:
Started
Owner:
jimblandy
-
-
-
-
-
-
|
