Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Do not use sudo on make install #17

Closed
ThomasHabets opened this issue Oct 10, 2014 · 4 comments
Closed

Do not use sudo on make install #17

ThomasHabets opened this issue Oct 10, 2014 · 4 comments

Comments

@ThomasHabets
Copy link
Contributor

Original issue 17 created by takahashi.shuhei on 2010-11-04T16:41:28.000Z:

"make install" invokes sudo to install PAM modules to /lib/security, but this is really bad behavior.
You should instruct users to type "sudo make install" instead, or just removing "sudo" is okay since it's a common manner to do that.

Reproduced in current hg head (74cba81d48).

@ThomasHabets
Copy link
Contributor Author

Comment #1 originally posted by brian@microcomaustralia.com.au on 2011-02-16T03:19:14.000Z:

I agree with this report. The current behaviour was very much unexpected; I don't expect processes to run with root privileges unless I specifically say so.

(not to mention the minor issue that not all my systems have sudo installed, so make install presumably will error out on these systems even though I might already have root privileges).

@ThomasHabets
Copy link
Contributor Author

Comment #2 originally posted by markus@google.com on 2011-03-09T20:18:11.000Z:

<empty>

@ThomasHabets
Copy link
Contributor Author

Comment #3 originally posted by markus@google.com on 2011-03-10T08:45:42.000Z:

We now print a message informing the user that we are about to invoke "sudo". Let me know, if that still results in problems.

@ThomasHabets
Copy link
Contributor Author

Comment #4 originally posted by vivek@khera.org on 2011-03-10T14:02:27.000Z:

That fix doesn't really address the issue. The user should invoke sudo on the make, not just be warned it is going to be invoked for them. It is just bad form to invoke sudo from within the makefile itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant