My favorites | Sign in
Google
             
New issue | Search
for
| Advanced search | Search tips
Issue 92: ValidateExemptionRequest fails to sanity check key resulting in exception
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  api.sgrinberg
Closed:  Nov 25
Type-Defect
Priority-Medium
Component-Core


Sign in to add a comment
 
Reported by michaelvmata, Nov 13, 2009
What steps will reproduce the problem?
1. Make an AdGroupAd Mutate ADD call with ExemptionRequests.

What is the expected output? What do you see instead?

Expect AdGroup Ad to be created with the exemption request.  Instead, we
get a KeyError exeption.

What version of the product are you using? On what operating system?

Version 7.2 with Windows Server 2003.

Please provide any additional information below.

The bug is located in aw_api/zsi_toolkit/SanityCheck.py.  If you look at
the ValidateExemptionRequest method, you'll notice that the code loops
through the key in the exemption then loops through the sub keys in each
key.  It then validates the exemption[subkey] instead of
exemption[key][subkey].
Comment 1 by api.sgrinberg, Nov 16, 2009
Good catch. Thanks! The fix you mentioned will be included in the next release.
Status: Accepted
Owner: api.sgrinberg
Comment 2 by api.sgrinberg, Nov 16, 2009
(No comment was entered for this change.)
Labels: Component-Core
Comment 3 by api.sgrinberg, Nov 25, 2009
(No comment was entered for this change.)
Status: Fixed
Sign in to add a comment