Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json.Unmarshaler misspelling #4595

Closed
gopherbot opened this issue Dec 28, 2012 · 4 comments
Closed

json.Unmarshaler misspelling #4595

gopherbot opened this issue Dec 28, 2012 · 4 comments
Milestone

Comments

@gopherbot
Copy link

by robert.gionea:

The encoding/xml package provides an interface called "Unmarshaler".
It seems like this is a misspelling, it should be called "Unmarshaller"
instead.
I tried asking in the go-nuts list but didn't get any relevant response.

You may find the interface in cause here:
http://golang.org/src/pkg/encoding/json/decode.go?s=2372:2431#L63
@gopherbot
Copy link
Author

Comment 1 by robert.gionea:

Obviously, I am talking about encoding/json, sorry for the confusion.

@rsc
Copy link
Contributor

rsc commented Dec 29, 2012

Comment 2:

Either spelling is acceptable. Go consistently uses the single l form.

Status changed to WontFix.

@gopherbot
Copy link
Author

Comment 3 by robert.gionea:

Sorry, I don't mean to be disrespectful, but could you at least point me to some
book/material/anything where it says that either spelling is acceptable? This are few
very basic grammar rules which contradict you:
1. "-er" as used here is an agentive ending;
2. when creating words using the "-er" agent suffix, for two-syllable verbs that end in
a single vowel followed by a single consonant other than w, x, or y, double the final
consonant then add the agent suffix.
I believe is fairly clear that you are wrong, and if you have no evidence to back this
(I admit that this could be something that I don't have knowledge about) you are
probably wrong.
If you find this as a too minor issue, I can take the time to submit a patch with the
correction...

@minux
Copy link
Member

minux commented Dec 29, 2012

Comment 4:

for example, http://www.merriam-webster.com/dictionary/marshaler

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants