Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/ld: include ba91b34fe212 in Go 1.0.3 #3180

Closed
davecheney opened this issue Mar 4, 2012 · 10 comments
Closed

cmd/ld: include ba91b34fe212 in Go 1.0.3 #3180

davecheney opened this issue Mar 4, 2012 · 10 comments

Comments

@davecheney
Copy link
Contributor

What steps will reproduce the problem?

gdb cannot locate the runtime-gdb.py helper on go installations which were built using
GOROOT_FINAL.

What is the expected output?

gdb can find runtime-gdp.py

What do you see instead?

lucky(~/devel/src/code.google.com/p/go.crypto/ssh) % gdb ./ssh.test 
GNU gdb (Ubuntu/Linaro 7.3-0ubuntu2) 7.3-2011.08
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>;
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://bugs.launchpad.net/gdb-linaro/>;...
Reading symbols from /home/dfc/devel/src/code.google.com/p/go.crypto/ssh/ssh.test...done.
warning: /build/buildd/golang-tip-12420/src/pkg/runtime/runtime-gdb.py (referenced in
.debug_gdb_scripts): No such file or directory
(gdb) quit
lucky(~/devel/src/code.google.com/p/go.crypto/ssh) % readelf ./ssh.test -p
.debug_gdb_scripts

String dump of section '.debug_gdb_scripts':
  [     1]  /build/buildd/golang-tip-12420/src/pkg/runtime/runtime-gdb.py

lucky(~/devel/src/code.google.com/p/go.crypto/ssh) % find /usr/lib/go -name
runtime-gdb.py
/usr/lib/go/src/pkg/runtime/runtime-gdb.py

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

linux

Which revision are you using?  (hg identify)

% go version
go version weekly.2012-02-22 +9dd9374109a9

Please provide any additional information below.

This is using the canonical provided golang-tip ppa, however I think the issue will
occur on any go installation where GOROOT and GOROOT_FINAL differ.
@dsymonds
Copy link
Contributor

dsymonds commented Mar 4, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

@minux
Copy link
Member

minux commented Mar 4, 2012

Comment 2:

See also: pprof and GOROOT_FINAL
( http://groups.google.com/group/golang-dev/browse_thread/thread/8e4059dc71fb78b2 )
I think this issue should be updated to "gc, ld: respect GOROOT_FINAL".

@davecheney
Copy link
Contributor Author

Comment 3:

Yes, they are ultimately the same, the original GOROOT leaks into the final installation.
Sent from my iPad

@rsc
Copy link
Contributor

rsc commented Mar 5, 2012

Comment 5:

Will fix this in the compiler.

@rsc
Copy link
Contributor

rsc commented Mar 5, 2012

Comment 6:

This issue was closed by revision 6e3a793.

Status changed to Fixed.

@gopherbot
Copy link

Comment 7 by rodseth:

Arch Linux maintainer for the Go package here. Please include this fix in Go 1.0.3.
Thanks. :)

@rsc
Copy link
Contributor

rsc commented Jun 25, 2012

Comment 8:

Labels changed: added priority-later, go1.0.3, removed priority-go1.

Status changed to Accepted.

@adg
Copy link
Contributor

adg commented Sep 12, 2012

Comment 9:

I'm confused. This change predates Go 1.0. How could it not be in Go 1.0.3?

@adg
Copy link
Contributor

adg commented Sep 12, 2012

Comment 10:

Labels changed: added priority-soon, removed priority-later.

Owner changed to @adg.

@rsc
Copy link
Contributor

rsc commented Sep 13, 2012

Comment 11:

You're right, it is already in the release branch. Sorry for not checking that.

Status changed to Invalid.

@rsc rsc added this to the Go1.0.3 milestone Apr 14, 2015
@rsc rsc removed the go1.0.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants