My favorites | Sign in
Project Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 36: Make gtkhotkey dependency really optional.
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  bertoldia
Closed:  Sep 2008
Type-Defect
Priority-Critical


Sign in to add a comment
 
Reported by serkankaba, Sep 02, 2008
Currently gtkhotkey dependendency is automagic meaning it can't be disabled
if gtkhotkey exists in the system. This makes it troublesome for source
based distros such as Gentoo. So please provide a flag or something (I
don't know how to do that in cmake) for disabling gtkhotkey dependency even
if it exists.

Thanks,

Serkan Kaba
Gentoo Developer

 
Comment 1 by serkankaba, Sep 02, 2008
I didn't think that cmake would be this simple. Here's a patch to disable gtkhotkey
detection by a flag.
file-browser-applet-0.5.8.patch
1.6 KB Download
Comment 2 by bertoldia, Sep 03, 2008
Hi there,

I make a few mistakes with the build system for 0.5.8, Including the gtkhotkey
dependency issue. My bad! I will be releasing either a fixed 0.5.8 or a 0.5.8 very soon.

Sorry!!!
Status: Started
Owner: bertoldia
Labels: -Priority-Medium Priority-Critical
Comment 3 by bertoldia, Sep 03, 2008
Fixed in 0.5.9
Status: Fixed
Comment 4 by serkankaba, Oct 29, 2008
which controls it? I can't see my patch being applied in 0.5.9 nor in SVN/trunk?
Comment 5 by bertoldia, Oct 29, 2008
Hey Man,

Not sure what you mean by "which controls it?"

The issue was fixed for 0.5.9. I don't remember if I actually applied your patch, but
it certainly made me aware of the problem so I'll include you in the contributors
list for the next one (or maybe an more correctly) add you to the 0.5.9 release notes.

Sorry I forgot to do it for 0.5.9 but I released it in a panic/rush. I didn't even
update the GnomeFiles site after that release!

Anyway, full name and email please so I can include it in the notes/code!

a.
Comment 6 by serkankaba, Nov 01, 2008
which controls it?
I meant to type "Which flag controls it?" here. My patch allowed to have a flag
-DGTKHOTKEY=ON (although -DWITH_GTKHOTKEY seems more logical to be similar to way 
KDE4 uses cmake flags)

For credits include the following info:

Serkan Kaba <serkan@gentoo.org>

Thanks.
Comment 7 by serkankaba, Nov 01, 2008
What I meant was it had an automagic dep. on gtkhotkey which means there's no way to
disable gtkhotkey integration if gtkhotkey exists in the system.
Comment 8 by bertoldia, Nov 02, 2008
    What I meant was it had an automagic dep. on gtkhotkey which means there's no way
    to disable gtkhotkey integration if gtkhotkey exists in the system.

Right, that's the way it's supposed to work. If gtkhotkey is installed on your system
then presumably you want applications to take advantage of that functionality.
Otherwise it wouldn't be installed. It seems odd to me that you'd have gtkhotkey
installed but not want an app to use it. In any case, if it's enabled you could just
not use it :-)

a.
Comment 9 by serkankaba, Nov 02, 2008
This makes packaging problematic for source based distros such as Gentoo. Here's a
documentation on why this causes problems for Gentoo.

http://www.gentoo.org/proj/en/qa/automagic.xml

My patch was in fact fixed this and introduced a flag to cmake for controlling
gtkhotkey dependency.
Comment 10 by serkankaba, Nov 03, 2008
Not in 0.6.0 either
Sign in to add a comment

Hosted by Google Code