My favorites | Sign in
Project Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 91: LabeledMarker is always clickable
1 person starred this issue and may be notified of changes. Back to list
Status:  FixedInRelease
Owner:  ----
Closed:  Feb 2009
Type-Defect
Class-LabeledMarker
Fixed-1.4


Sign in to add a comment
 
Reported by kris.breuker, Feb 24, 2009
What steps will reproduce the problem?
Create a LabeledMarker with "clickable: false" in the options object

What is the expected output? What do you see instead?
The marker's label should not be clickable, nor should it show a "pointer" cursor, but I still get a 
hand pointer cursor and the label is clickable. The marker itself behaves correctly.

What version of the product are you using? On what operating system?
labeledmarker.js version 1.3 (but this bug also exists in the developer version)

Please provide any additional information below.
In the LabeledMarker constructor, the line:

  this.clickable_ = opt_opts.clickable || true;

set this.clickable_ to true, if opt_opts.clickable == false (false || true == true). I think this should 
be changed to:

  this.clickable_ = opt_opts.clickable && true;

Also, the line:

  this.div_.style.cursor = "pointer";

set the cursor to a hand pointer, regardless of the clickable option. I think a check should be 
added:

  if (this.clickable_)
    this.div_.style.cursor = "pointer";

Kind regards,
Kris Breuker
Comment 1 by pamela.fox, Feb 27, 2009
Fixed in r933, by roughly following suggestions. Added example to check behavior as 
well.
http://gmaps-utility-library-
dev.googlecode.com/svn/trunk/labeledmarker/examples/unclickable.html

Status: FixedInDev
Labels: Type-Defect Class-LabeledMarker
Comment 2 by pamela.fox, Jun 23, 2009
This is released in 1.4
Status: FixedInRelease
Labels: Fixed-1.4
Sign in to add a comment

Hosted by Google Code