better? #70
better? #70
Conversation
…uceneIndexing (otherwise thread pool will be kept open for more than a minute, what hinders the start of another gitblit instance in the same jvm during selenium test case execution), fixed naming of xpath variables, added missing property to gitblit.properties and test-ui-gitblit.properties, changed naming of methods (according to decision that owners is a much shorter word than repository administrator and that owners is fits better if you think of collective responsibilities and collective ownership)
| boolean luceneIndexing = settings.getBoolean(Keys.web.allowLuceneIndexing, true); | ||
| logger.info("Lucene indexing is " + (luceneIndexing ? "" : "not") + " activated"); | ||
|
|
||
| if (luceneIndexing) { |
There was a problem hiding this comment.
It's better, although it is currently redundant.
https://github.com/gitblit/gitblit/blob/master/src/com/gitblit/LuceneExecutor.java#L161
If you think this is an improvement (I'm indifferent) then we should remove the check in the executor and also update gitblit.properties to indicate that this setting will now require a server restart.
https://github.com/gitblit/gitblit/blob/master/distrib/gitblit.properties#L572
Like, for example, https://github.com/gitblit/gitblit/blob/master/distrib/gitblit.properties#L704
There was a problem hiding this comment.
ScheduledThreadPoolExecutor.scheduleAtFixedRate calls delayedExecute thus there are still Threads running after gitblit has been terminated, but while the JVM is still running. So, for selenium test suites it will cause a test case fail for all test cases, but the first one. Anyway, I would prefer to keep the setting changeable on runtime (without a restart). I have another idea how to deal with this. See the next commit.
…or in test selenium test cases
seleniumFixV2: connected thread pool creation to condition web.allowLuceneIndexing (otherwise thread pool will be kept open for more than a minute, what hinders the start of another gitblit instance in the same jvm during selenium test case execution), fixed naming of xpath variables, added missing property to gitblit.properties and test-ui-gitblit.properties, changed naming of methods (according to decision that owners is a much shorter word than repository administrator and that owners is fits better if you think of collective responsibilities and collective ownership)