Hi Sarah, I have merged your contribution, but I did revise some of it because I prefer "owner" to "repository administrator". I do appreciate the extra effort you went through for translations.

I also have manually merged the selenium contribution. However, I know this is broken because of the rollback to "owner" from "repository administrator".

Hi James,

thanks. I will fix the selenium tests first before I continue to work on
the crowd authentication.
Will open a new pull request for the fixes soon.

While working on the crowd authentication I figured out, that it might
be best, to refactor authentication and user management first because it
is quite tightly coupled with the main Gitblit.java class. It would also
be great for administrators to be able to configure authentication
modules i.e. IUserService implementations over the web interface and
have an option to test connections on runtime. I will create some
documentation for you because the refactoring will change the interfaces
and the responsibilities of different classes and add some new classes
to the existing set. I just got a commit comment for the preparation
steps, but can't really see, what atsu85 exactly means by
ugly-factoring.
https://github.com/akquinet/gitblit/commit/13670069dc12899f985d2e1456a8e719e0b1b08d#commitcomment-2483899
(commit comment in src/com/gitblit/RpcServlet.java). So if you have any
idea, let me know because it will be more difficult to change things the
further I get.

The UX department will work on the collapse/expand dashboard feature
(repo list view) while I'm on vacation the next two weeks.

Sarah

On 01/23/2013 02:46 PM, James Moger wrote:

Hi Sarah, I have merged your contribution, but I did revise some of it
because I prefer "owner" to "repository administrator". I do
appreciate the extra effort you went through for translations.

I also have manually merged the selenium contribution. However, I know
this is broken because of the rollback to "owner" from "repository
administrator".

—
Reply to this email directly or view it on GitHub
#63 (comment).

Sarah Haselbauer
M.Sc. Information Systems

akquinet tech@spree GmbH

Bülowstraße 66
D-10783 Berlin

Tel. +49 (0)30 235 520 – 23
Fax +49 (0)30 217 520 – 12
E-Mail sarah.haselbauer@akquinet.de
Web http://www.akquinet.de

akquinet tech@spree GmbH, Berlin
Geschäftsführung: Martin Weber, Dr. Torsten Fink
Amtsgericht Berlin-Charlottenburg HRB 86780 B
USt.-Id. Nr.: DE 225 964 680

but can't really see, what atsu85 exactly means by

ugly-factoring.

https://github.com/akquinet/gitblit/commit/13670069dc12899f985d2e1456a8
e719e0b1b08d#commitcomment-2483899

He means that your IDE code formatter is breaking long lines into
shorter lines while there is no real change, other than line breaks. I
agree, actually, but I wouldn't have written "ugly". I don't always
use a formatter. I prefer that a complete thought (line) be expressed
as a single line unless it is longer than say 120 chars.

I'll try to take a look at your refactorings further.

-J