Maven packaging fixes + branch-level permissions filtering #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to allow pluggability (code+assets) into other containers / applications (i.e. Gerrit Code Review)
DisplayName used previously contained ONLY the last part of ref-spec: this would have not worked when looking for objects with full ref-spec.
gitblit
added a commit
that referenced
this pull request
May 7, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi James,
I have made fixes on the Maven packaging to include the static resources needed for running GitBlit inside Gerrit. (I've missed them last month whilst submitting the patch to you)
Additionally I've found bugs in the branch-level permissions (filtering + error notification): additional commits provide the fix for them.
Let me know if you need me to change or amend anything.
Thank you in advance.
Luca.