Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

would you consider a patch to release com.gitblit.util / com.gitblit.model code as a reuable library? #503

Closed
gitblit opened this issue Aug 12, 2015 · 5 comments
Closed

would you consider a patch to release com.gitblit.util / com.gitblit.model code as a reuable library? #503

gitblit opened this issue Aug 12, 2015 · 5 comments
Assignees
@gitblit
Labels
🐱 Defect Priority-Medium Status-Done

Comments

@gitblit
Copy link
Collaborator

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 207

We needed a little bit of jgit utility code to do version history & difference with
jgit on the hawtio project (http://hawt.io) & found the gitblit code very handy! Great
work!

As a quick hack we've just reused your source 
https://github.com/hawtio/hawtio/tree/master/hawtio-git/src/main/java/com/gitblit

but really would rather just depend on a com.gitblit util jar.

I'll happily try submit a patch to your build system to also generate a gitblit util
jar as part of your build if you're cool with the idea? Your call!

Mostly its just the models / utils packages (though the Constants.java is required
too - ideally moving that to util/model package would be cleaner but not a huge biggie).

Reported by james.strachan on 2013-02-17 14:07:02
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Hi James,

Thanks for the positive feedback.  I have realized for a while that my repo is too
monotlihic and I am slowly moving towards addressing that.  I'm open to the idea of
building a gitblit-common jar, but I wonder if it is the best fit for you.  Have you
considered Gitective? 

https://github.com/kevinsawicki/gitective

Gitective is a usability/api improvement over direct JGit, is available via Maven,
 and is maintained by one of the JGit/EGit contributors (a GitHub employee).

If I were starting over I would consider using Kevin's library rather than rolling
my own.

-James

Reported by James.Moger on 2013-02-17 16:56:46

@gitblit gitblit self-assigned this Aug 12, 2015
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Thanks for the heads up James - I'll have a look, thanks!

Reported by james.strachan on 2013-02-18 08:26:30

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

I've just about migrated to gitective - its pretty good stuff! Many thanks for the heads
up! We can close this issue now. 

The only issue I've found with gitective is I couldn't grok how to use the DiffFormatter
with the Collection<Edit> that is returned from gitective's BlobUtils.diff() - so I
reused the code from your DiffUtils :) other than that it works great. 

Took a little while to bend my brain around the CommitFinder (the CommitListFilter
wasn't terribly obvious at first ;) but I do like the way its easy to find various
commits by file extension / tag / person etc. Nice stuff.

Thanks again for the heads up!

Reported by james.strachan on 2013-02-18 09:52:03

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Nice.  Kevin may be open to improving the Gitective diff capability or at least the
documentation.  You should open an issue on his Github project to discuss it.

Reported by James.Moger on 2013-02-18 15:53:19

  • Status changed: Done

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Good idea - done: https://github.com/kevinsawicki/gitective/issues/8

Reported by james.strachan on 2013-02-18 15:59:00

@gitblit gitblit closed this as completed Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitblit gitblit

Labels
🐱 Defect Priority-Medium Status-Done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gitblit