Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow linking to line number on code view #426

Closed
gitblit opened this issue Aug 12, 2015 · 4 comments
Closed

Allow linking to line number on code view #426

gitblit opened this issue Aug 12, 2015 · 4 comments
Assignees
@gitblit
Labels
🐱 Feature Priority-Medium Status-Fixed
Milestone
1.2.0

Comments

@gitblit
Copy link
Collaborator

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 130

What steps will reproduce the problem?
Browse to a file in an repo

What is the expected output? What do you see instead?
Should be able to select a line number to link to that number directly

What version of the product are you using? On what operating system?
1.0.0 on ubuntu 12.04

Reported by lqdinternet on 2012-09-11 11:40:56
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-09-11 20:09:46

  • Status changed: Accepted
  • Labels added: Milestone-1.2.0

@gitblit gitblit self-assigned this Aug 12, 2015
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

This is mostly completed and live on the demo site.  There is a browser/dom bug which
I am currently seeking help with related to offset from top of the window because it
is currently incorrect by about 50px (the height of the top navbar).

example:
https://demo-gitblit.rhcloud.com/blob/gitblit.git/16e4747d3cb2c2a53a6bef554bca306d8594a080/src!com!gitblit!wicket!pages!BlobPage.java#L1

Reported by James.Moger on 2012-09-14 22:21:04

  • Status changed: Started

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

This is now working properly.

https://demo-gitblit.rhcloud.com/blob/gitblit.git/HEAD/src!com!gitblit!wicket!pages!BlobPage.java#L141

Reported by James.Moger on 2012-09-17 15:32:05

  • Status changed: Queued

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

v1.2.0 has been deployed.

Reported by James.Moger on 2013-01-01 01:06:25

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix modified the milestone: 1.2.0 Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitblit gitblit

Labels
🐱 Feature Priority-Medium Status-Fixed
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@gitblit @flaix