Looking at this change, I believe the code would act the same...so I wouldn't call this a fix. Actually, using the attribute directly (i.e. no ${} notation) is slightly more efficient (it doesn't have to loop over every LDAP Attribute). Was this not working for you?

Also, being a properties file, changing might mess with people who aren't customizing their properties, so this has a minor chance of causing a difficult upgrade (minor since it's confined to LDAP, and it's just an email attribute). I would vote to NOT include this change, but for you to customize the properties for your environment.

without the ${email} attribute don't work for me...

Hmmmm, have you had a chance to debug in your environment? LdapUserService L270 should be pulling out your email from an attribute on the LDAP entry. Your variable "email" (Line 262) should be "email" with the default settings.

It's been 8 months since the report and there is insufficient evidence that this change is necessary. Closing for now.