Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal error when trying to show summary page for linux kernel repository #321

Closed
gitblit opened this issue Aug 12, 2015 · 4 comments
Closed

Internal error when trying to show summary page for linux kernel repository #321

gitblit opened this issue Aug 12, 2015 · 4 comments
Assignees
@gitblit
Labels
🐱 Defect Priority-Medium Status-Fixed
Milestone
0.7.0

Comments

@gitblit
Copy link
Collaborator

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 25

What steps will reproduce the problem?
1. clone Linus' linux kernel repository into GitBlit's git folder
    git clone --bare git://github.com/torvalds/linux.git

2. open GitBlit's project list page and click the link for the linux kernel repository

What is the expected output? What do you see instead?

expected: summary page for linux kernel repository

instead: I hit an internal error:

ERROR Can't instantiate page using constructor public com.gitblit.wicket.pages.SummaryPage(org.apache.wicket.PageParameters)
and argument r = "linux/linux.git"
org.apache.wicket.WicketRuntimeException: Can't instantiate page using constructor
public com.gitblit.wicket.pages.SummaryPage(org.apache.wicket.PageParameters) and argument
r = "linux/linux.git"
    at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:212)
    at org.apache.wicket.session.DefaultPageFactory.newPage(DefaultPageFactory.java:89)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.newPage(BookmarkablePageRequestTarget.java:305)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.getPage(BookmarkablePageRequestTarget.java:320)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.processEvents(BookmarkablePageRequestTarget.java:234)
    at org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
    at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1252)
    at org.apache.wicket.RequestCycle.step(RequestCycle.java:1331)
    at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1438)
    at org.apache.wicket.RequestCycle.request(RequestCycle.java:546)
    at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:486)
    at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:319)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:476)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:517)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:225)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:937)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:406)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:183)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:871)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110)
    at org.eclipse.jetty.server.Server.handle(Server.java:346)
    at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:589)
    at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1048)
    at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:601)
    at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:214)
    at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:411)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:535)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:529)
    at java.lang.Thread.run(Thread.java:680)
Caused by: java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
    at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:188)
    ... 32 more
Caused by: java.lang.NullPointerException
    at com.gitblit.models.RefModel.getDate(RefModel.java:52)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:135)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:35)
    at java.util.Arrays.mergeSort(Arrays.java:1144)
    at java.util.Arrays.mergeSort(Arrays.java:1155)
    at java.util.Arrays.mergeSort(Arrays.java:1155)
    at java.util.Arrays.mergeSort(Arrays.java:1155)
    at java.util.Arrays.mergeSort(Arrays.java:1155)
    at java.util.Arrays.mergeSort(Arrays.java:1155)
    at java.util.Arrays.mergeSort(Arrays.java:1155)
    at java.util.Arrays.sort(Arrays.java:1079)
    at java.util.Collections.sort(Collections.java:117)
    at com.gitblit.utils.JGitUtils.getRefs(JGitUtils.java:1199)
    at com.gitblit.utils.JGitUtils.getTags(JGitUtils.java:1109)
    at com.gitblit.utils.MetricUtils.getDateMetrics(MetricUtils.java:95)
    at com.gitblit.wicket.pages.SummaryPage.<init>(SummaryPage.java:71)
    ... 37 more


What version of the product are you using? On what operating system?
0.6 on Mac OSX 10.6.8

Please provide any additional information below.

Reported by matthias.sohn on 2011-10-16 23:43:20
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Ok you got me.  I didn't test with the kernel repository because its so large.  The
reason for the failure is the first 11 tags (2.6.11, 2.6.12) in the repository either
predate the official "tag" capability of Git or the tags were manually created with
plumbing commands (or both).  Either way, those first tags do not have the "tagger"
metadata that normal tags have.  This creates nullpointer exceptions.

This will be fixed for the next release.

Reported by James.Moger on 2011-10-17 14:48:51

  • Status changed: Accepted
  • Labels added: Milestone-0.7.0

@gitblit gitblit self-assigned this Aug 12, 2015
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

In JGit and EGit we made the experience that it's always a good idea to test new stuff
with the linux kernel repository as it contains almost everything git is able to do
and it also contains objects created by very old git versions which may behave a bit
different than objects created by modern git versions. So it often reveals problems
which otherwise may sleep a long time until they bite some user.

Reported by matthias.sohn on 2011-10-17 18:59:49

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

It's sage advice.  Now that I have cloned the beast I'll test against it.  :)  I plan
to have a new release by the end of the month.

Reported by James.Moger on 2011-10-17 21:20:46

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Fix deployed in v0.7.0.

Reported by James.Moger on 2011-11-11 23:15:55

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix modified the milestone: 0.7.0 Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitblit gitblit

Labels
🐱 Defect Priority-Medium Status-Fixed
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@gitblit @flaix