Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository owner now has default access. #2

Closed
wants to merge 1 commit into from
Closed

Repository owner now has default access. #2

wants to merge 1 commit into from

Conversation

dadalar
Copy link

@dadalar dadalar commented Nov 11, 2011

There is no need to give repository owner separate access. Like an admin account, they will have access over their repositories.

@gitblit
Copy link
Collaborator

gitblit commented Nov 11, 2011

Lets do this.

  1. Create a new method in UserModel.canAccessRepository(RepositoryModel model) which checks ownership in addition to the current conditions.
  2. Find all references to the old method and replace most calls with your new method (i.e. the ones that have a RepositoryModel in the calling location).
  3. Leave the ones that only have strings (unit tests and AuthenticatedRequest). I'll think some more on how to handle those.

@gitblit
Copy link
Collaborator

gitblit commented Nov 11, 2011

Hi. I decided to just go ahead and implement this as I outlined above and it will be part of the 0.7.0 release. Keep plugging away on the sources. I'd be happy to merge in other good ideas.

@gitblit gitblit closed this Nov 11, 2011
gitblit pushed a commit that referenced this pull request Nov 18, 2016
Merge pull request #2 from gitblit/master
77898a1 
merge updates from gitblit master into this wicket-7 branch
@thomass4t thomass4t mentioned this pull request Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dadalar @gitblit