Custom Defined Repository Properties (Issue #92) #16
Conversation
…is makes getting specialized settings in hooks much easier.
…writing of all other properties
…t with "custom" instead of "user"
|
Where did you get VerticalFlowLayout? I can't merge that because it looks like copy-and-paste from somewhere else without any license information nor attribution. |
|
Sorry, I grabbed it originally from Stack Overflow (http://stackoverflow.com/questions/8196530/java-vertical-flowlayout-with-horizontal-scrolling). Looks like it originally came from a google code (http://code.google.com/p/verticalflowlayout/source/browse/trunk/src/VerticalFlowLayout.java - LGPL license) which is a slight modification of FlowLayout from Sun. I can use a different implementation if you prefer, but this one looked the most visually appealing. Or if you prefer me to slap copyrights, I can do that too. |
|
IANAL, but IMHO the application of LGPL here is invalid. The "verticalflowlayout" project can't take Sun code, tweak it, and relicense as LGPL because they want to. Especially when you read the first 4 lines of the header: /*
I think we'll need a different approach for laying out this panel. |
|
Yeah, I totally agree. I should have dug into that a bit deeper before, my apologies. I'll get that fixed right up ASAP. |
|
Alright, I've moved to a standard BoxLayout. However, to get rid of some really ugly gaps on the UI, I had to do some "swing math" to add a filler. |
Custom Defined Repository Properties (Issue #92)
This is a full solution for custom fields as discussed in issue #92 (mainly used for groovy hooks). Please see http://code.google.com/p/gitblit/issues/detail?id=92 for details.