Retrieve LDAP groups with dereferencing aliases. #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the LDAP user service will not dereference aliases when searching for groups. This patch enables dereferencing aliases for the group search. This is benefitial if groups are defined in the DIT in a common place but only certain ones shall play a role in Gitblit. These can now be linked under a group that can be provided as search base for groups, without having to recreate the existing groups under the search base. In addition, the new doSearch() method implemented in this patch also limits the attributes returned for the gruop search to the "cn" attribute, which is the only one used. That prevents returning all the members of the result groups, which can be a lot.
gitblit
pushed a commit
that referenced
this pull request
Nov 22, 2013
Currently the LDAP user service will not dereference aliases when searching for groups. This patch enables dereferencing aliases for the group search. This is benefitial if groups are defined in the DIT in a common place but only certain ones shall play a role in Gitblit. These can now be linked under a group that can be provided as search base for groups, without having to recreate the existing groups under the search base. In addition, the new doSearch() method implemented in this patch also limits the attributes returned for the group search to the "cn" attribute, which is the only one used. That prevents returning all the members of the result groups, which can be a lot. Change-Id: I29e1560390810304386dcea5ca40aaf78601b3a9
|
Thanks Florian, I manually merged your patch. |
gitblit
added a commit
that referenced
this pull request
Jul 2, 2014
gitblit
added a commit
that referenced
this pull request
Jul 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the LDAP user service will not dereference aliases when searching for groups. This patch enables
dereferencing aliases for the group search. This is benefitial if groups are defined in the DIT in a common
place but only certain ones shall play a role in Gitblit. These can now be linked under a group that can be
provided as search base for groups, without having to recreate the existing groups under the search base.
In addition, the new doSearch() method implemented in this patch also limits the attributes returned for
the gruop search to the "cn" attribute, which is the only one used. That prevents returning all the members
of the result groups, which can be a lot.