Make prefix for user repositories directory configurable #116
Conversation
|
Beginner question: what would be the impact if I were to rebase this branch onto v1.3.2? I know the "don't rebase pushed commits" mantra. I am wondering though if it really applies that unconditionally. As long as you haven't merged this branch, or have added commits, would it still cause trouble if I would rebase and push again? |
|
I don't think Github can handle rebasing a pull request. Would be nice if it could. I think you'd have to create a new pull request. This is where Gerrit's workflow becomes attractive. |
|
Hmm, if you don't mind, i.e. you haven't done anything with the branch yet, I'll try it and see how this is handled. |
Gather logic for building the path/name of a personal user repository into one class.
Set the user repository name space from settings when starting Gitblit.
|
Go for it. I want to know too. |
|
I believe Github handles a rebase pretty nicely. Still four commits, but the rebased ones. Apparently it only looks at the branch and uses whatever is the current content of it. Well, of course only as long as it hasn't been merged. |
|
Did you just re-push to your feature branch? Or did you also have to |
|
I simply rebased locally and force pushed to Github. |
Make the currently fixed prefix for the user repositories directory ('~') configurable. Refactor code to gather all uses of the prefix into a new class (for lack of a better name called 'ModelUtils').
An empty prefix is not allowed. The prefix can also be a path relative to the repositories folder. An absolute path is made relative by removing the first '/'. Currently requires reload. I'm not sure if it makes sense to make this dynamically updatable. It should be possible, though.