Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply PageParameters(final Map<String, ?> parameterMap), encode filename... #108

Merged
merged 1 commit into from Jul 31, 2013
Merged

apply PageParameters(final Map<String, ?> parameterMap), encode filename... #108

merged 1 commit into from Jul 31, 2013

Conversation

guriguri
Copy link
Contributor

Problem

  1. BlobPage has been an error by filename with comma(,).
  2. Downloaded filename is broken. because non-ascii. e.g. korean (한글테스트.pdf)

Proposal

  1. new PageParameters(final String keyValuePairs) -> new PageParameters(final Map<String, ?> parameterMap) on WicketUtils.java
  2. encoding filename according to browser (ie, ff, chrome, …) on RawPage.java

Appendix

  1. add pptx on WicketUtils.getFileImage()

@gitblit gitblit merged commit d80588d into gitblit-org:master Jul 31, 2013
gitblit added a commit that referenced this pull request Jun 18, 2014
@gitblit
Merged #108 "Fix NPE when there are two repositories which only diffe…
b4ee41a 
…r in case"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guriguri @gitblit