My favorites ▼ | Sign in
Project Home Downloads Issues Source
Repository:
Checkout   Browse   Changes   Clones    
 
Committed Changes
Branch:
Tag:
Other:
Rev Commit log message Date Author
1ae8c53498f5
Add missing header for suggest.accounts documentation Change-Id: I6f70d56fcfe4c41376a026ac84391fd5d2414051
Mar 9 (2 days ago)
1c4013638518
Implement an overall timeout for ReceiveCommits ReceiveCommits does a lot of work, potentially involving RPCs to remote servers that may have long timeouts. If something really goes off the rails, e.g. a database RPC hanging forever, we want to be able to kill stalled ReceiveCommits threads. Note that the timeout is only for ReceiveCommits, not for the various steps in receive-pack processing that happen before that, like actually reading the data from the wire or indexing the pack. So the amo
Mar 2, 2012
06cb1d25266b
Implement a multi-sub-task progress monitor for ReceiveCommits Because there are a lot of file and database accesses, having a progress monitor is useful. Moreover, we no longer rely on JGit for ref updates, so we can't depend on its progress meter. This is a special progress meter implementation that multiplexes output from the various sub-tasks that ReceiveCommits performs. We need this multiplexing because we don't know ahead of time how much of most kinds of work must be performed. For exa
Feb 29, 2012
3643ac6ec57e
Buffer message output in ReceiveCommits Soon, we will have a progress monitor for ReceiveCommits, and we don't want to interleave informational messages with the progress monitor output. So, buffer all message output in ReceiveCommits until the end of processCommands. Change-Id: Id5010161f7a3e6498778224a34dabb6313db2e78
Mar 5 (6 days ago)
234734a5f57e
Run ReceiveCommits in a shared thread pool Since the work ReceiveCommits may take a long, potentially unbounded amount of time, we would like to have it run in the background so it can be monitored for timeouts and cancelled, and have stalls reported to the user from the main thread. Wraps ReceiveCommits in a new PreReceiveHook, AsyncReceiveCommits, that runs its delegated ReceiveCommits in a WorkQueue.Executor. The default implementation sizes the thread pool to the number of available proce
Mar 1, 2012
227fe30f2a71
Merge changes Icbb9d55c,I093fbae9,Iaac64301,I45cad57e,I415c54c8 * changes: Abstract out the message-sending parts of ReceiveCommits Use ReceiveCommitsAdvertiseRefsHook in a chain Make ReceiveCommits only a PreReceiveHook Make ReceiveCommitsAdvertiseRefsHook public Update to latest JGit to get AdvertiseRefsHook
Mar 9 (2 days ago)
904e0c6b043c
Merge changes I471cd6c4,I586cd1c9 * changes: Asynchronously send email. Add a class for propagating request scoping to different threads
Mar 9 (2 days ago)
c26eafc64322
Asynchronously send email. On gerrit-review.googlesource.com, an email is taking about 3 seconds to create and send. The CommentSender is complex and difficult to optimize, so I wrapped the email generation/sending in a request scoped runnable and submitted it to the default WorkQueue for PublishComments, MergeOp, and ReceiveCommits. Change-Id: I471cd6c45af9ec851654b2b23c385081afe3de04
Mar 8 (3 days ago)
f04aa729feda
Abstract out the message-sending parts of ReceiveCommits For the RPC server case, we want to send the output from ReceiveCommits back over the wire via the RPC protocol, and the underlying ReceivePack has no connection to the server. Change-Id: Icbb9d55cb42be601c349c0ab2e82d2d52b3ce95a
Feb 29, 2012
2a2d8b9fea0a
Use ReceiveCommitsAdvertiseRefsHook in a chain Replaces the manual chaining with the included facility in JGit. Change-Id: I093fbae9fe87b8e214f25f133078c6e26509f887
Feb 14, 2012
18ef23414654
Make ReceiveCommits only a PreReceiveHook Previously, ReceiveCommits.onPostReceive() depended on state set up by onPreReceive(), making this class inappropriate for implementing a stateless RPC. The only benefit to splitting up the pre/post-receive steps was to let the ref updates fall through to core JGit in a few cases. Now that JGit has been refactored to make these ref updates trivial, just handle everything from within ReceiveCommits. Change-Id: Iaac64301c3ac3a33052cc30b2bb0b5cf61d4b1bd
Feb 13, 2012
9012b2c2d746
Make ReceiveCommitsAdvertiseRefsHook public Change-Id: I45cad57e5b125ad84ae9b6cc464c11cd262f463a
Feb 15, 2012
57a420bd1078
Update to latest JGit to get AdvertiseRefsHook Convert VisibleRefFilter and ReceiveCommitsRefFilter to be AdvertiseRefsHooks. For now, the basic functionality remains the same. Change-Id: I415c54c8a5ee657f41e5ff2ca4a8f9c7b7a16c1b
Feb 13, 2012
3e7ef3cc5f41
Add a class for propagating request scoping to different threads Request scopes are all implemented with ThreadLocals, which meant that RequestScoped data would not be available in any new threads created from the main request thread. Add a class to wrap Runnables and Callables so tasks that depend on request scoped objects can be inserted in a WorkQueue. Include ScopePropagator implementations for all request scope types. The GuiceRequestScopePropagator will forward materialized instances of
Mar 2, 2012
26ad9940283c
Update JGit to 1.3.0.201202151440-r Lots of fixes have been integrated in JGit since the previous version (1.1.0.201109151100-r.141-gcd958ba) and we are due for another version bump. I am perticulary interested in this one: https://git.eclipse.org/r/#/c/4757/ This change solves the issue where Gerrit would just throw a "Change not found" error for certain conflicting merges (RuntimeException) instead of displaying the change screen. Change-Id: Ie984bc2ccd371cf82e2ec640d0680f243b4ba9c1
Mar 5, 2012
2e6622019077
Fix build: Change class was moved into another package Change I6cd6125eddcb1dd2b5c5e353edf163544248026b moved the Change class into a new package, but some new files in change Iaa0a9a2faece760f3b54f6e204f268d9d6ef2c5b still imported the Change class from the old package. There was no conflict on submit and the merge succeeded, but the build got broken. Change-Id: I50b7dfe3df3b7dda2d807b80862ab867eed76f13 Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Mar 8 (4 days ago)
02854fa0b220
Merge "Create a ChangeCache for ChangeDetails in ChangeScreen"
Mar 8 (4 days ago)
b6c912cc0da2
Create a ChangeCache for ChangeDetails in ChangeScreen Create a ChangeCache as a general place to hold client side data about changes. Having a common place to store change data will allow multiple UI widgets to refer to the same data without having to be connected to or aware of other widgets. In this change, the ChangeCache only holds ChangeDetailCaches, but in the future it may hold more Change data. Combining all Change related objects into a single ChangeCache and placing them in a Map
Dec 29, 2011
09b06824992f
Update URL for m2eclipse The project is now under the Eclipse Foundation umbrella. Change-Id: I044abfc41175a32912fea85c68d8ab993fde14d0
Mar 7 (4 days ago)
b30883860d44
Updated to gwtorm 1.4. Refactored the GWT client code to include only what the gerrit GWT client. The gerrit GWT build was giving build warnings since the getAsync() signature and implementation used types that were not available to GWT. Split the reviewdb into a client and server package. Organized the imports to ease the migration. Change-Id: I6cd6125eddcb1dd2b5c5e353edf163544248026b
Mar 7 (4 days ago)
2a437a70264f
Merge "Updated to Guice 3.0."
Mar 7 (4 days ago)
90e96be4d1bb
Merge "Only compute AccountVisibility during startup"
Mar 7 (4 days ago)
15182323b4c1
Merge "Remove perl from commit-msg hook"
Mar 6 (6 days ago)
4c55b0866b2e
Merge "Add visible-to-all flag in the documentation for cmd-create-group"
Mar 5 (6 days ago)
c5201bf3874f
Remove perl from commit-msg hook Removing perl from the commit-msg hook reduces the dependencies gerrit imposes on its users. Change-Id: I2ad3c4cf199fdece8a80384712381a7c4fe72d6e
Jul 2, 2011
 
Powered by Google Project Hosting