SemanticMediaWiki throws ImportError if BeautifulSoup is not present, and BeautifulSoup warning is removed #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geopy gives a warning to all its users if the optional dependency BeautifulSoup is not installed. It would be better if only users who touched functionality needing BeautifulSoup were affected; and, that users who attempt to use functionality needing BeautifulSoup see an
ImportError
on initialization, rather than a warning on initialization followed by an undefined variable exception.This pull request defines BeautifulSoup as either the package or, if not available,
None
, and if the consumingSemanticMediaWiki
geocoder is used with a BeautifulSoup ofNone
, anImportError
is thrown.