Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticMediaWiki throws ImportError if BeautifulSoup is not present, and BeautifulSoup warning is removed #22

Merged
merged 1 commit into from Oct 23, 2013

Conversation

ijl
Copy link
Member

@ijl ijl commented Sep 4, 2013

geopy gives a warning to all its users if the optional dependency BeautifulSoup is not installed. It would be better if only users who touched functionality needing BeautifulSoup were affected; and, that users who attempt to use functionality needing BeautifulSoup see an ImportError on initialization, rather than a warning on initialization followed by an undefined variable exception.

This pull request defines BeautifulSoup as either the package or, if not available, None, and if the consuming SemanticMediaWiki geocoder is used with a BeautifulSoup of None, an ImportError is thrown.

ijl added a commit that referenced this pull request Oct 23, 2013
SemanticMediaWiki throws ImportError if BeautifulSoup is not present, and BeautifulSoup warning is removed
@ijl ijl merged commit 30f2b81 into geopy:master Oct 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant