frogr - Project Hosting on Google Code

Last 30 days Nov 17, 2009 issue 1 (Use accesor funtions instead direct acces) commented on by mariospr - Committed. Thanks! Committed. Thanks! Nov 17, 2009 issue 4 (Patch to ensure that your are not using deprecated code) Status changed by mariospr - Committed. Thanks! Status: Fixed Committed. Thanks! Status: Fixed Nov 16, 2009 issue 4 (Patch to ensure that your are not using deprecated code) reported by Javierjc1982 - Patch attached The patch added some rules to autotools to check if your are using deprecated GLIB/GTK+ code. Regards Patch attached The patch added some rules to autotools to check if your are using deprecated GLIB/GTK+ code. Regards Nov 16, 2009 issue 1 (Use accesor funtions instead direct acces) commented on by Javierjc1982 - Hey Mario, here a new patch to fix some code recently added Regards Hey Mario, here a new patch to fix some code recently added Regards Earlier this year Oct 13, 2009 frogr_0.2-0jaunty1_i386.deb (frogr 0.2 release - ubuntu jaunty) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 13, 2009 frogr_0.2-0intrepid1_i386.deb (frogr 0.2 release - ubuntu intrepid) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 13, 2009 frogr_0.2-0hardy1_i386.deb (frogr 0.2 release - ubuntu hardy) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 13, 2009 frogr-0.2.tar.gz (frogr 0.2 release - source tarball (gzip)) file uploaded by mariospr - Labels: Type-Archive OpSys-Linux Featured Labels: Type-Archive OpSys-Linux Featured Oct 13, 2009 frogr-0.2.tar.bz2 (frogr 0.2 release - source tarball (bzip2)) file uploaded by mariospr - Labels: Type-Archive OpSys-Linux Featured Labels: Type-Archive OpSys-Linux Featured Oct 13, 2009 frogr-0.2-1.fc11.i386.rpm (frogr 0.2 release - fedora 11 (i386)) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 12, 2009 frogr-0.2.tar.bz2 (frogr 0.2 release - source tarball (bzip2)) file uploaded by mariospr - Labels: Type-Archive OpSys-Linux Featured Labels: Type-Archive OpSys-Linux Featured Oct 12, 2009 frogr-0.2.tar.gz (frogr 0.2 release - source tarball (gzip)) file uploaded by mariospr - Labels: Type-Archive OpSys-Linux Featured Labels: Type-Archive OpSys-Linux Featured Oct 12, 2009 frogr-0.2-1.fc11.i386.rpm (frogr 0.2 release - fedora 11 (i386)) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 12, 2009 frogr_0.2-0jaunty1_i386.deb (frogr 0.2 release - ubuntu jaunty) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 12, 2009 frogr_0.2-0intrepid1_i386.deb (frogr 0.2 release - ubuntu intrepid) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Oct 12, 2009 frogr_0.2-0hardy1_i386.deb (frogr 0.2 release - ubuntu hardy) file uploaded by mariospr - Labels: Type-Package OpSys-Linux Featured Labels: Type-Package OpSys-Linux Featured Sep 24, 2009 issue 3 (Support silent build rules with automake 1.11) Status changed by mariospr - WTF?? Javier please accept my apologies and forgot about my silly question of not getting the proper output with your patch. I was so much sure about having automake 1.11 installed in my machine that I jsut did not double check it and today (when I finally manage to get some spare time to hack on this) I found out I had automake 1.10 installed X'D. Hence, applied your patch right now: commit e94a25e3f9e355d54b562838dbdfc7ae96d83769 Author: Javier Jardón <javierjc1982@gmail.com> Date: Sat Sep 5 21:30:46 2009 +0200 Support silent build rules with automake 1.11 * configure.ac: Support silent build rules, requires at least automake-1.11. Disable by either passing --disable-silent-rules to configure or passing V=1 to make. Thanks a lot mario Status: Fixed WTF?? Javier please accept my apologies and forgot about my silly question of not getting the proper output with your patch. I was so much sure about having automake 1.11 installed in my machine that I jsut did not double check it and today (when I finally manage to get some spare time to hack on this) I found out I had automake 1.10 installed X'D. Hence, applied your patch right now: commit e94a25e3f9e355d54b562838dbdfc7ae96d83769 Author: Javier Jardón <javierjc1982@gmail.com> Date: Sat Sep 5 21:30:46 2009 +0200 Support silent build rules with automake 1.11 * configure.ac: Support silent build rules, requires at least automake-1.11. Disable by either passing --disable-silent-rules to configure or passing V=1 to make. Thanks a lot mario Status: Fixed Sep 07, 2009 issue 3 (Support silent build rules with automake 1.11) commented on by mariospr - Thanks for your patch, see some comments below... Regarding to forcing Automake 1.11 for building frogr, I do not like that very much, as it would make frogr to stop building in some widely used distros such as Debian Lenny or Ubuntu Hardy (I think testing and intrepid also would fail), since they come wieh Automake 1.10. However, reading documentation about silent building [1], I realize that your patch should work with prior versions to 1.11, because of the m4_ifdef statement, bot tested yet though. If that was the case then I would recommend to change some comments included both in the configure.ac file and the git log message suggesting that "at least" automake 1.11 is needed before pusing anything ;-) Btw, although perhaps my fault at some extent, I was not able to see any difference after applying your patch and running configure (well, autogen.sh in this case) plus make. I thought I was supposed to find something like this: test-hellow % make V=0 make all-am make[1]: Entering directory `/home/flame/test-hellow' CC hellow.o CCLD hellow make[1]: Leaving directory `/home/flame/test-hellow' ... and I still got the usual verbose compilation lines: test-hellow % make V=1 make all-am make[1]: Entering directory `/home/flame/test-hellow' gcc -DHAVE_CONFIG_H -I. -g -O2 -MT hellow.o -MD -MP -MF .deps/hellow.Tpo -c -o hellow.o hellow.c mv -f .deps/hellow.Tpo .deps/hellow.Po gcc -g -O2 -o hellow hellow.o make[1]: Leaving directory `/home/flame/test-hellow' Looking forward to hearing from you. Thanks! Mario [1] http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html Thanks for your patch, see some comments below... Regarding to forcing Automake 1.11 for building frogr, I do not like that very much, as it would make frogr to stop building in some widely used distros such as Debian Lenny or Ubuntu Hardy (I think testing and intrepid also would fail), since they come wieh Automake 1.10. However, reading documentation about silent building [1], I realize that your patch should work with prior versions to 1.11, because of the m4_ifdef statement, bot tested yet though. If that was the case then I would recommend to change some comments included both in the configure.ac file and the git log message suggesting that "at least" automake 1.11 is needed before pusing anything ;-) Btw, although perhaps my fault at some extent, I was not able to see any difference after applying your patch and running configure (well, autogen.sh in this case) plus make. I thought I was supposed to find something like this: test-hellow % make V=0 make all-am make[1]: Entering directory `/home/flame/test-hellow' CC hellow.o CCLD hellow make[1]: Leaving directory `/home/flame/test-hellow' ... and I still got the usual verbose compilation lines: test-hellow % make V=1 make all-am make[1]: Entering directory `/home/flame/test-hellow' gcc -DHAVE_CONFIG_H -I. -g -O2 -MT hellow.o -MD -MP -MF .deps/hellow.Tpo -c -o hellow.o hellow.c mv -f .deps/hellow.Tpo .deps/hellow.Po gcc -g -O2 -o hellow hellow.o make[1]: Leaving directory `/home/flame/test-hellow' Looking forward to hearing from you. Thanks! Mario [1] http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html Sep 05, 2009 issue 3 (Support silent build rules with automake 1.11) reported by Javierjc1982 - Automake 1.11 supports Linux-kernel like silent build rules with easy ways to switch to the more verbose output either at configure time: ./configure --disable-silent-rules or at make time: make V=1 The attached patch enables silent build rules by default. Automake 1.11 supports Linux-kernel like silent build rules with easy ways to switch to the more verbose output either at configure time: ./configure --disable-silent-rules or at make time: make V=1 The attached patch enables silent build rules by default. Aug 25, 2009 issue 2 (Remove deprecates GTK+ symbols) Status changed by mariospr - Great! Patch pushed, this time there was only one detail left I already ammended in the commit message, while keeping you as Author: 80 col limit exceeded. This is how the log message looks now (quite similar, isn't it?): Remove deprecated GTK+ symbols * src/frogr-main-window.c (_ctxt_menu_create): Substitute gtk_menu_append () with gtk_menu_shell_append () function Sorry for the nitpicking and thanks a lot for your contribution! Status: Fixed Great! Patch pushed, this time there was only one detail left I already ammended in the commit message, while keeping you as Author: 80 col limit exceeded. This is how the log message looks now (quite similar, isn't it?): Remove deprecated GTK+ symbols * src/frogr-main-window.c (_ctxt_menu_create): Substitute gtk_menu_append () with gtk_menu_shell_append () function Sorry for the nitpicking and thanks a lot for your contribution! Status: Fixed Aug 25, 2009 issue 2 (Remove deprecates GTK+ symbols) commented on by Javierjc1982 - Hello! Thank you for apply my patch :). Here the new one with the new commit message. Anyway I think that this format is not used anymore, at least in Gnome. See http://live.gnome.org/Git/CommitMessages Hello! Thank you for apply my patch :). Here the new one with the new commit message. Anyway I think that this format is not used anymore, at least in Gnome. See http://live.gnome.org/Git/CommitMessages Aug 25, 2009 issue 1 (Use accesor funtions instead direct acces) commented on by Javierjc1982 - Hello! Thank you for apply my patch :). Here the new one with the new commit message. I followed the Gnome guidelines for the commit message in the previous patches http://live.gnome.org/Git/CommitMessages , sorry. Hello! Thank you for apply my patch :). Here the new one with the new commit message. I followed the Gnome guidelines for the commit message in the previous patches http://live.gnome.org/Git/CommitMessages , sorry. Aug 25, 2009 issue 2 (Remove deprecates GTK+ symbols) commented on by mariospr - Urgh! I forgot to ask you another little favour: could you write the git message log so it would be more ChangeLog-style? I mean, it would be great to do it this way: - One short line (less than 74 cols) briefly describing the patch - One blank line - ChangeLog-style entries describing changes in the code, for instance, as it was done with patch for Issue 1 (http://code.google.com/p/frogr/issues/detail?id=1): Use accesor functions instead direct access * src/frogr-auth-dialog.c (frogr_auth_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. * src/frogr-details-dialog.c (frogr_details_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. Something like that would work. Thanks! Urgh! I forgot to ask you another little favour: could you write the git message log so it would be more ChangeLog-style? I mean, it would be great to do it this way: - One short line (less than 74 cols) briefly describing the patch - One blank line - ChangeLog-style entries describing changes in the code, for instance, as it was done with patch for Issue 1 (http://code.google.com/p/frogr/issues/detail?id=1): Use accesor functions instead direct access * src/frogr-auth-dialog.c (frogr_auth_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. * src/frogr-details-dialog.c (frogr_details_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. Something like that would work. Thanks! Aug 25, 2009 issue 1 (Use accesor funtions instead direct acces) Status changed by mariospr - Great! Patch pushed to master branch. I've only changed commit message to be more ChangeLog-style compliant :-): Use accesor functions instead direct access * src/frogr-auth-dialog.c (frogr_auth_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. * src/frogr-details-dialog.c (frogr_details_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. As from frogr 0.2 on we automatically generate the ChangeLog in "make dist" based on git log, is a good practice to write git logs that way from now on. Thanks! Status: Fixed Great! Patch pushed to master branch. I've only changed commit message to be more ChangeLog-style compliant :-): Use accesor functions instead direct access * src/frogr-auth-dialog.c (frogr_auth_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. * src/frogr-details-dialog.c (frogr_details_dialog_init): Use gtk_dialog_get_content_area() instead of directly accessing to the dialog's vbox if Gtk+ >= 2.14. As from frogr 0.2 on we automatically generate the ChangeLog in "make dist" based on git log, is a good practice to write git logs that way from now on. Thanks! Status: Fixed Aug 25, 2009 issue 2 (Remove deprecates GTK+ symbols) Cc changed by mariospr - You're right. It was in the plan to change it by I just forgot about that. However, I'd like to apply your patch in master and it does not apply because now there's another item ("add_tags_item") which would need the same kind of fix. Could you please then resend this patch done against latest commit in master? I could do the required changes on top of your patch myself, but I'd rather see your name as the Author of the commit by just applying it :-) Cc: mariospr You're right. It was in the plan to change it by I just forgot about that. However, I'd like to apply your patch in master and it does not apply because now there's another item ("add_tags_item") which would need the same kind of fix. Could you please then resend this patch done against latest commit in master? I could do the required changes on top of your patch myself, but I'd rather see your name as the Author of the commit by just applying it :-) Cc: mariospr Aug 25, 2009 frogr_0.1.1-0lenny1_i386.deb (frogr 0.1.1 release - debian lenny (i386)) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 25, 2009 frogr_0.1.1-0squeeze1_amd64.deb (frogr 0.1.1 release - debian squeeze (x86_64)) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 24, 2009 frogr-0.1.1-0.fc11.x86_64.rpm (frogr 0.1.1 release - fedora 11 (x86_64)) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 24, 2009 frogr-0.1.1-0.fc11.i386.rpm (frogr 0.1.1 release - fedora 11) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 24, 2009 frogr-0.1.1-1.fc11.i386.rpm (frogr 0.1.1 release - fedora 11) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 24, 2009 frogr_0.1.1-0hardy1_i386.deb (frogr 0.1.1 release - ubuntu hardy) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 24, 2009 frogr-0.1.1-0.fc11.i386.rpm (frogr 0.1.1 release - fedora 11) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 24, 2009 frogr-0.1.1-1.fc11.i386.rpm (frogr 0.1.1 release - fedora 11) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 22, 2009 issue 2 (Remove deprecates GTK+ symbols) reported by Javierjc1982 - I've removed gtk_menu_append and use gtk_menu_shell_append instead I've removed gtk_menu_append and use gtk_menu_shell_append instead Aug 22, 2009 issue 1 (Use accesor funtions instead direct acces) reported by Javierjc1982 - To be ready for GNOME 3 frogr should be able to build with -DGSEAL_ENABLE See http://live.gnome.org/GnomeGoals/UseGseal To be ready for GNOME 3 frogr should be able to build with -DGSEAL_ENABLE See http://live.gnome.org/GnomeGoals/UseGseal Aug 22, 2009 frogr-0.1.1.tar.gz (frogr 0.1.1 release - source tarball (gzip)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.bz2 (frogr 0.1.1 release - source tarball (bzip2)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.gz (frogr 0.1.1 release - source tarball (gzip)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.bz2 (frogr 0.1.1 release - source tarball (bzip2)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.gz (frogr 0.1.1 release - source tarball (gzip)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.bz2 (frogr 0.1.1 release - source tarball (bzip2)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.bz2 (frogr 0.1.1 release - source tarball (bzip2)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr-0.1.1.tar.gz (frogr 0.1.1 release - source tarball (gzip)) file uploaded by mariospr - Labels: OpSys-Linux Type-Archive Featured Labels: OpSys-Linux Type-Archive Featured Aug 22, 2009 frogr_0.1.1-0jaunty1_i386.deb (frogr 0.1.1 release - ubuntu jaunty) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 22, 2009 frogr_0.1.1-0intrepid1_i386.deb (frogr 0.1.1 release - ubuntu jaunty) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 22, 2009 frogr_0.1.1-0intrepid1_i386.deb (frogr 0.1.1 release - ubuntu intrepid) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 22, 2009 frogr_0.1.1-0hardy2_i386.deb (frogr 0.1.1 release - ubuntu hardy) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 22, 2009 frogr_0.1-0hardy2_i386.deb (frogr 0.1 release - ubuntu hardy) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 21, 2009 frogr_0.1-0testing1_amd64.deb (frogr 0.1 release - debian testing (squeeze)) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured Aug 21, 2009 frogr_0.1-0jaunty1_i386.deb (frogr 0.1 release - ubuntu jaunty) file uploaded by mariospr - Labels: OpSys-Linux Type-Package Featured Labels: OpSys-Linux Type-Package Featured

issue 3 (Support silent build rules with automake 1.11) commented on by mariospr - Thanks for your patch, see some comments below... Regarding to forcing Automake 1.11 for building frogr, I do not like that very much, as it would make frogr to stop building in some widely used distros such as Debian Lenny or Ubuntu Hardy (I think testing and intrepid also would fail), since they come wieh Automake 1.10. However, reading documentation about silent building [1], I realize that your patch should work with prior versions to 1.11, because of the m4_ifdef statement, bot tested yet though. If that was the case then I would recommend to change some comments included both in the configure.ac file and the git log message suggesting that "at least" automake 1.11 is needed before pusing anything ;-) Btw, although perhaps my fault at some extent, I was not able to see any difference after applying your patch and running configure (well, autogen.sh in this case) plus make. I thought I was supposed to find something like this: test-hellow % make V=0 make all-am make[1]: Entering directory `/home/flame/test-hellow' CC hellow.o CCLD hellow make[1]: Leaving directory `/home/flame/test-hellow' ... and I still got the usual verbose compilation lines: test-hellow % make V=1 make all-am make[1]: Entering directory `/home/flame/test-hellow' gcc -DHAVE_CONFIG_H -I. -g -O2 -MT hellow.o -MD -MP -MF .deps/hellow.Tpo -c -o hellow.o hellow.c mv -f .deps/hellow.Tpo .deps/hellow.Po gcc -g -O2 -o hellow hellow.o make[1]: Leaving directory `/home/flame/test-hellow' Looking forward to hearing from you. Thanks! Mario [1] http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html

Thanks for your patch, see some comments below... Regarding to forcing Automake 1.11 for building frogr, I do not like that very much, as it would make frogr to stop building in some widely used distros such as Debian Lenny or Ubuntu Hardy (I think testing and intrepid also would fail), since they come wieh Automake 1.10. However, reading documentation about silent building [1], I realize that your patch should work with prior versions to 1.11, because of the m4_ifdef statement, bot tested yet though. If that was the case then I would recommend to change some comments included both in the configure.ac file and the git log message suggesting that "at least" automake 1.11 is needed before pusing anything ;-) Btw, although perhaps my fault at some extent, I was not able to see any difference after applying your patch and running configure (well, autogen.sh in this case) plus make. I thought I was supposed to find something like this: test-hellow % make V=0 make all-am make[1]: Entering directory `/home/flame/test-hellow' CC hellow.o CCLD hellow make[1]: Leaving directory `/home/flame/test-hellow' ... and I still got the usual verbose compilation lines: test-hellow % make V=1 make all-am make[1]: Entering directory `/home/flame/test-hellow' gcc -DHAVE_CONFIG_H -I. -g -O2 -MT hellow.o -MD -MP -MF .deps/hellow.Tpo -c -o hellow.o hellow.c mv -f .deps/hellow.Tpo .deps/hellow.Po gcc -g -O2 -o hellow hellow.o make[1]: Leaving directory `/home/flame/test-hellow' Looking forward to hearing from you. Thanks! Mario [1] http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html

Last 30 days

Earlier this year