Export to GitHub

formalchemy - issue #64

I suggest to extract PylonsTemplate class in "formalchemy/templates.py" to "formalchemy.ext.pastertemplate.py"


Posted on Feb 15, 2009 by Swift Bird

File "formalchemy/templates.py" contain two main things :

  1. mako_template function :
    • used if you have Make Template
    • used in :
      • formalchemy/forms.py
      • formalchemy/tables.py
  2. PylonsTemplate class used by paster_create_template

outcome :

  • when forms or table are rendered with make template useless PylonsTemplate class is loaded

I suggest to :

  • extract PylonsTemplate class to formalchemy.ext.paster_template.py or formalchemy.ext.pastertemplate.py

What are your comments ?

Regards, Stephane

Comment #1

Posted on Feb 15, 2009 by Swift Bird

Sorry, I've would like to say formalchemy.ext.pylons.pastertemplate.py

Comment #2

Posted on Feb 15, 2009 by Swift Bird

This my patch.

Attachments

Comment #3

Posted on Feb 16, 2009 by Swift Bird

Fix mistakes :

  1. mako_template function :
    • used if you have Mako Template <= MakO
    • used in :
      • formalchemy/forms.py
      • formalchemy/tables.py
  2. PylonsTemplate class used by paster_create_template

outcome :

  • when forms or table are rendered with mako template useless PylonsTemplate class is loaded <= makO

Comment #4

Posted on Feb 20, 2009 by Grumpy Cat

applied, thanks

Status: Fixed