My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 7036: Firebug bugs when updating the DOM every 29 ms or less
2 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by florent....@gmail.com, Dec 10, 2013
Firebug bugs when the DOM is udpated every 29 ms or less.
Open the attached test case and follow the instructions on it. 
To sum up: 
- The command line expressions are never displayed
- The action through the HTML panel never updates the HTML panel itself
- (and maybe other impacts)

This is due to the context.throttle method which clears the current timeout before pushing the message into the queue and creating a new timeout of 30 ms [1]. 
Therefore the timeout is never triggered.

I attach a simple patch that solves the issue but needs to be tested with the FBTests (to ensure there is no regression). 

I think we should backport this fix.

Florent

[1] See: https://github.com/firebug/firebug/blob/46dc55b/extension/content/firebug/chrome/tabContext.js#L560
throttle_bug.html
2.4 KB   View   Download
Dec 10, 2013
Project Member #1 simon.lindholm10
Patch file is empty.

> - (and maybe other impacts)
Console logs never appearing seems like a serious one.

Agreed that we may want to port this.
Dec 10, 2013
Project Member #2 sebastia...@gmail.com
Sounds like we should split this issue into two, one for the Console and one for the HTML panel.
I marked this issue as a 1.12 blocker.

Sebastian
Labels: -1.12a5 1.12.5 blocks-1.12
Dec 10, 2013
Project Member #3 simon.lindholm10
> Sounds like we should split this issue into two, one for the Console and one for the HTML panel.
No, it only needs changes in tabContext.throttle.
Dec 10, 2013
Project Member #4 florent....@gmail.com
> Patch file is empty.
Oops, that's fixed.

> Sounds like we should split this issue into two, 
> one for the Console and one for the HTML panel.

No because the fix is the same for both (see attached).

Florent
fix_throttle.patch
805 bytes   Download
Dec 10, 2013
Project Member #5 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: port-1.12
Dec 10, 2013
Project Member #6 florent....@gmail.com
No regression, so here is the commit: https://github.com/firebug/firebug/commit/8b1e107c3a273d656b54c30bbb2daa81a3ad464b

I'll backport if no one objects. 
I am preparing the FBTest. I might not finish for this evening.

Florent
Status: Commit
Labels: FBTest-wanted
Dec 10, 2013
Project Member #7 florent....@gmail.com
I got rid off the "HTML" part of the FBTest (evaluating the command should be sufficient to detect regressions): https://github.com/firebug/firebug/commit/e34c88d90af757d1f0fa2b5a55959ee619f15291

Florent
Labels: -FBTest-wanted FBTest-available
Dec 13, 2013
Project Member #8 odva...@gmail.com
This issue has been fixed in Firebug 1.13 alpha 7
https://getfirebug.com/releases/firebug/1.13/firebug-1.13.0a7.xpi

Please let us know if it works for you.

Thanks for the help!

Honza
Status: Fixed
Labels: fixed-1.13-a7
Dec 19, 2013
Project Member #10 florent....@gmail.com
(No comment was entered for this change.)
Labels: -porter-1.12 ported-1.12
Jan 7, 2014
Project Member #11 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: -port-1.12
Jan 20, 2014
Project Member #12 odva...@gmail.com
This issue has been fixed in Firebug 1.12.6
https://getfirebug.com/releases/firebug/1.12/firebug-1.12.6.xpi

Please try it and let us know if it works for you.

Thanks for the help!
Honza
Labels: fixed-1.12.6
Sign in to add a comment

Powered by Google Project Hosting