My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 6256: Auto-completion is slow
1 person starred this issue and may be notified of changes. Back to list
 
Project Member Reported by simon.lindholm10, Feb 8, 2013
What steps will reproduce the problem?
1. Bring up the Command Line, type "d".
-> it takes like 200-300ms to bring up the completion popup on my machine, which is way too slow (it should seem immediate).

Turns out most of this is in these lines in autoCompleter.js/autoCompleteEval:
out.completions = Arr.sortUnique(out.completions, comparePropertyNames);
out.hiddenCompletions = Arr.sortUnique(out.hiddenCompletions, comparePropertyNames);

Apparently JSD is slowing down chrome code and the calls to comparePropertyNames from built-in sort, because I don't see this without it enabled. We should work around this somehow (until JSD2).

Honza, is it possible to get some fix for this into 1.11.2 still?
Feb 9, 2013
Project Member #1 simon.lindholm10
https://github.com/firebug/firebug/commit/ed4df1a05755e9f49e1e3393d1ffc1bb8e53866e
https://github.com/firebug/firebug/commit/e2d30766175f87a372eb10474f30af323f257986 (1.11)

So yeah, is it possible to get this into 1.11.2? It's a large improvement for the command line (and very local and thus safe, but we could wait for testbot results), and I would prefer not to wait a month or so to get it out.
Status: Commit
Owner: simon.lindholm10
Labels: ported-1.11
Feb 10, 2013
Project Member #2 sebastia...@gmail.com
> So yeah, is it possible to get this into 1.11.2?
No, Honza already uploaded 1.11.2 to AMO on Wednesday:
https://addons.mozilla.org/de/firefox/addon/firebug/versions/

When you think, it's that important, it could be part of 1.11.3.

Sebastian
Cc: sebastia...@gmail.com
Feb 10, 2013
Project Member #3 simon.lindholm10
I know, but I was asking about a possible reupload since there is no official release yet (still waiting on review?).
Feb 11, 2013
Project Member #4 odva...@gmail.com
I think we should avoid 'last minute changes' (except of crashes/security or another critical issues) even if it's tempting and we know it makes the product better. We can yet discuss tomorrow.
My first suggestion would be to do another beta-final release cycle round.

Honza
Feb 11, 2013
Project Member #5 simon.lindholm10
I guess I can respect such a view. I do think though that you should try typing in the command line before/after so you can get a feel for roughly how much value it adds, and again note that it's a very safe fix.
Feb 11, 2013
Project Member #6 sebastia...@gmail.com
Note that for me there is no difference in speed. The Completion List Popup appears immediately when I press the key. And I tested on two different machines.

Sebastian
Feb 12, 2013
Project Member #7 simon.lindholm10
Hm, ok. For me the big auto-completion FBTest goes from 20s to 17s, which is quite notable... But that might mean it's not that high priority, at least.
Feb 22, 2013
Project Member #8 odva...@gmail.com
This issue has been fixed in Firebug 1.12 alpha 3
https://getfirebug.com/releases/firebug/1.12/firebug-1.12.0a3.xpi

Please try it and let us know how it works for you.

Thanks for the help!
Honza

Status: Fixed
Labels: fixed fixed-1.12-a3
Mar 28, 2013
Project Member #9 simon.lindholm10
Maybe it was https://bugzilla.mozilla.org/show_bug.cgi?id=848665. Ah well.
Apr 12, 2013
Project Member #10 odva...@gmail.com
This issue has been fixed in Firebug 1.11.3 beta 1
https://getfirebug.com/releases/firebug/1.11/firebug-1.11.3b1.xpi

Honza
Labels: fixed-1.11.3-b1
Apr 16, 2013
Project Member #11 simon.lindholm10
(No comment was entered for this change.)
Labels: -fixed
Sep 4, 2013
Project Member #12 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: fixed-1.11.3
Sign in to add a comment

Powered by Google Project Hosting