My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 6213: Clearing console doesn't work when throwy proxies are logged
1 person starred this issue and may be notified of changes. Back to list
 
Reported by sdavidgo...@gmail.com, Jan 24, 2013

1)Navigate to: https://getfirebug.com/tests/manual/issues/4979/issue4979.html
2)Enable and switch to the Console panel
3)Reload the page
4)click in "Clear"

What is the expected result? 
	The console must be cleared

What do you see instead?
	The console is partially cleaned. 
	In FF error console appears: Error: uncaught exception: 0

Firebug version: 1.11.1
Browser version: Firefox 18.0.1
Operating system: W-7

Jan 24, 2013
Project Member #1 sebastia...@gmail.com
Good catch. I can reproduce that issue using FF 18.0.1 + FB 1.11.1 on Win7.
Though I see another error inside the Firefox Error Console:

Error: TypeError: iter is undefined
Source file: chrome://firebug/content/lib/domplate.js
Line: 481

Sebastian
Status: Triaged
Cc: sebastia...@gmail.com odva...@gmail.com
Labels: Type-Defect console 1.11.1 Test-case-available
Jan 24, 2013
Project Member #2 simon.lindholm10
I'd say the main problem here is that context.flushThrottleQueue doesn't try-catch callbacks. When the throwy proxies get logged (with throttling) and that explicably throws, the throttling queue doesn't get cleared at all from slightly before that point. Hence clearing, which throttles things, makes the previous queued timeouts run again.

Fixing a rep for throwy proxies also seems like a good idea.
Cc: simon.lindholm10
Jan 24, 2013
Project Member #3 odva...@gmail.com
I did that try-catch in ConsolePanel.appendObject, which is underneath of the throttle queue.

https://github.com/firebug/firebug/commit/4369a09082f69b56345fd79017566521c0cf2edc

The patch is also, checking the iter in domplate.

Any more tips how to fix the rep (Rep.Obj in this case)?

Honza



Status: Started
Owner: odva...@gmail.com
Cc: -odva...@gmail.com
Jan 24, 2013
Project Member #4 simon.lindholm10
> I did that try-catch in ConsolePanel.appendObject, which is underneath of the throttle queue.
Why not in flushThrottleQueue? Seems like a place where we do want exception munging, especially considering those symptoms of total breakage.

> Any more tips how to fix the rep (Rep.Obj in this case)?
Add a try-catch in `Firebug.Rep.getTitle` (it touches .constructor). (Also: s/FBL/Str/ there.)

> The patch is also, checking the iter in domplate.
Did you see it happening in any other case than this of invalid input? Seems like slightly bad API design.
Jan 24, 2013
Project Member #5 odva...@gmail.com
> Why not in flushThrottleQueue? Seems like a place where we do
> want exception munging, especially considering those symptoms of total breakage.
both, I think it's safer to try-catch directly the rep.tag.append since it's underneath of throttle (sync) and flushThrottleQueue (async)

But, agree the async queue flushing should be save too so, could you please add it?

> Add a try-catch in `Firebug.Rep.getTitle` (it touches .constructor).
> (Also: s/FBL/Str/ there.)
Nice, done!

https://github.com/firebug/firebug/commit/4369a09082f69b56345fd79017566521c0cf2edc

> Seems like slightly bad API design.
I thought the same, but then I noticed that the same is in the other __loop__ in compileMarkup...


Honza

Jan 24, 2013
Project Member #6 odva...@gmail.com
Also, at some point we could improve the default return value from Str.safeToString.
Honza
Jan 25, 2013
Project Member #7 sebastia...@gmail.com
At least the issue is fixed for the test case already. Thanks.
I changed the summary to reflect better what's happening here.

Sebastian
Summary: Clearing console doesn't work when throwy proxies are logged (was: Clear console not work)
Jan 30, 2013
Project Member #8 odva...@gmail.com
Guard message throttling at:
https://github.com/firebug/firebug/commit/5e0740665f8fb3dd6d116d4f1bfdb376654d1ac4

Honza
Status: Commit
Feb 1, 2013
Project Member #9 odva...@gmail.com
This issue has been fixed in Firebug 1.12 beta 2
https://getfirebug.com/releases/firebug/1.12/firebug-1.12.0a2.xpi

Please try it and let us know how it works for you.

Thanks for the help!
Honza

Status: Fixed
Labels: fixed-1.12.0-b2
Feb 1, 2013
Project Member #10 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: -fixed-1.12.0-b2 fixed-1.12.0-a2
Feb 2, 2013
Project Member #11 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: -fixed-1.12.0-a2 fixed-1.12-a2
Feb 5, 2013
#12 sdavidgo...@gmail.com
Works for me. Thanks
Feb 5, 2013
Project Member #13 sebastia...@gmail.com
Thanks for verifying!

Sebastian
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting