My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 6185: Closure Inspector: .% syntax doesn't work when execution is stopped in frame
1 person starred this issue and may be notified of changes. Back to list
 
Project Member Reported by simon.lindholm10, Jan 11, 2013
From https://code.google.com/p/fbug/issues/detail?id=5873#c73. I'll see if I can reproduce.
Jan 12, 2013
Project Member #1 simon.lindholm10
I can't. Sebastian, any STR, testcase, special setup, Firebug extensions?
Status: NeedInfo
Jan 14, 2013
Project Member #2 sebastia...@gmail.com
Steps are:
1. Open Firebug on http://jqueryui.com/menu/
2. Enable and switch to the Script panel
3. Reload the page
4. Enable Break On Next
5. Hover the menu on the page
6. Switch to the Watch side panel
7. Type "jQuery.%_$" (without quotes) into the "New watch expression..." field and hit Enter

=> The watch expression is added but displays "ReferenceError: __fb_scopedVars is not defined". The same happens when you enter the expression into the Command Line.

Sebastian
Status: Triaged
Jan 14, 2013
Project Member #3 simon.lindholm10
Ah, thanks.
Summary: Closure Inspector: .% syntax doesn't work when execution is stopped in frame (was: Closure Inspector: .% syntax doesn't work when execution is stopped)
Labels: Test-case-available
Jan 14, 2013
Project Member #4 sebastia...@gmail.com
I missed that this just happens when you're inside a frame. Good catch!

Sebastian
Jan 14, 2013
Project Member #5 simon.lindholm10
Thoughts on this? (Any non-tabContext.js contexts to worry about?) https://github.com/simonlindholm/firebug/compare/6185-stopped-global
Jan 15, 2013
Project Member #6 simon.lindholm10
(note for if we port this: the patch depends on wrapObject introduced in b335cb9)
Jan 15, 2013
Project Member #7 simon.lindholm10
(preemptive so we don't miss it)
Labels: port-1.11
Jan 17, 2013
Project Member #8 odva...@gmail.com
> Thoughts on this? (Any non-tabContext.js contexts to worry about?)
> https://github.com/simonlindholm/firebug/compare/6185-stopped-global

0) I like the new approach, it looks cleaner than before. I don't know about
any other non-tabContexts.js instances.

1) Instead of "(win && win.location)" (commandLine.js) we should use:
Win.safeGetWindowLocation

2) I am seeing a lot of test failures
https://getfirebug.com/testresults/?dburi=http://firebug.couchone.com/&dbname=firebug2&userheaderid=dc5a2ac3f11d2665876272de15000af5

(e.g. almost all command line API fails)

Honza


Jan 17, 2013
Project Member #9 simon.lindholm10
> 2) I am seeing a lot of test failures
Ah, sorry, fixed. "var" bit me. ( https://github.com/simonlindholm/firebug/commit/d30eb7bed3f7fc85c7dd41d38279629eb8c6180f )

Should I commit/port it?
Jan 18, 2013
Project Member #10 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: -closure-inspector closureinspector
Jan 18, 2013
Project Member #11 simon.lindholm10
> Labels: -closure-inspector closureinspector
Thanks, that was bugging me. :)

So what do we do with this? Port a safe fix to 1.11.2 final?
Jan 21, 2013
Project Member #12 odva...@gmail.com
I tested this and it looks good.

I think you can commit and port back to 1.11

Honza
Jan 21, 2013
Project Member #13 sebastia...@gmail.com
>> Labels: -closure-inspector closureinspector
> Thanks, that was bugging me. :)
I know it's just a little thing but I want to keep the labels consistent.

Sebastian
Jan 28, 2013
Project Member #15 sebastia...@gmail.com
Works fine now, thanks.

Sebastian
Feb 1, 2013
Project Member #16 odva...@gmail.com
This issue has been fixed in Firebug 1.12 beta 2
https://getfirebug.com/releases/firebug/1.12/firebug-1.12.0a2.xpi

Please try it and let us know how it works for you.

Thanks for the help!
Honza

Status: Fixed
Labels: fixed-1.12.0-b2
Feb 1, 2013
Project Member #17 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: -fixed-1.12.0-b2 fixed-1.12.0-a2
Feb 1, 2013
Project Member #18 simon.lindholm10
Ported to 1.11: https://github.com/firebug/firebug/commit/15fa818ca71bb6eff0a9379dcc1554260fae1115
Labels: -port-1.11 ported-1.11
Feb 2, 2013
Project Member #19 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: -fixed-1.12.0-a2 fixed-1.12-a2
Feb 25, 2013
Project Member #20 odva...@gmail.com
(No comment was entered for this change.)
Labels: fixed-1.11.2
Sign in to add a comment

Powered by Google Project Hosting