What should be implemented/improved? When the browser makes a HTTP PATCH method request, there is no option in the Firebug net tab to view the request body (or "payload"). This is available for POST and PUT requests.
The most you can infer about the body is the content length header.
Viewing the request body/payload works correctly in Chrome Developer tools "net" tab
Firebug version: 1.11.1 Browser version: 17.0.1 Operating system: Ubuntu/12.11
Comment #1
Posted on Jan 4, 2013 by Grumpy GiraffeI should add the Response body from the server is viewable.
Comment #2
Posted on Jan 7, 2013 by Helpful WombatCould you please provide a test case with steps to reproduce?
Sebastian
Comment #3
Posted on May 6, 2013 by Helpful WombatCreated a test case for this[1], which is working for me (FF 20.0.1 + FB 1.11.2 + Win7). Because there was no further feedback until now, I finally close this issue.
Sebastian
[1] https://getfirebug.com/tests/manual/issues/6175/issue6175.html
Comment #4
Posted on May 20, 2013 by Massive RabbitThe issue is that, "request" body is not visible. What was the PATCH payload sent from the browser. This works in chrome inspector. Attaching screenshots below : Patch in Chrome Inspector : https://dl.dropboxusercontent.com/u/204155/dontdelete/patchinchrome.jpg
Patch in Firebug : https://dl.dropboxusercontent.com/u/204155/dontdelete/patchinfirebug.jpg
Comment #5
Posted on May 20, 2013 by Helpful WombatNow I see. Thanks for the clarification, Sid. I adjusted the test case accordingly.
Honza, I guess that's something for you. A simple fix would be to add a check for "PATCH" to the hidePost() function[1]. Though I believe we also need to adjust the tab name to "Request Body" and some function names, which are currently named with "Post".
This issue is related to issue 6411.
Sebastian
Comment #6
Posted on Jun 14, 2013 by Massive RabbitIs this going to get fixed in a coming build ?
Comment #7
Posted on Jun 17, 2013 by Helpful WombatYes. Fixed that in https://github.com/firebug/firebug/commit/415f47a4c678d35ad10ff00629d734ceb4aa2ee6 by simply adding a "Patch" tab.
Regarding the refactoring I created issue 6537, so this fix isn't blocked by that.
Sebastian
Comment #8
Posted on Jun 28, 2013 by Massive WombatThis issue has been fixed in Firebug 1.12 beta 1 https://getfirebug.com/releases/firebug/1.12/firebug-1.12.0b1.xpi
Please try it and let us know if it works for you.
Thanks for the help! Honza
Status: Fixed
Labels:
Type-Defect
net
1.11.3
Test-case-available
FBTest-wanted
fixed-1.12-b1