Export to GitHub

fbug - issue #5625

Filter "character encoding" warnings


Posted on Jun 27, 2012 by Swift Rhino

1) Download the attached file 2a) Open exampleCharacterEncodingFrame.html with Firefox 3a) In console panel appears an error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must to be declared in the document or in the transfer protocol."

2b) Open exampleCharacterEncoding.html with Firefox 3b) In console panel appears an warning: "The character encoding of a framed document was not declared. The document may appear different if viewed without the document framing it.."

4) In console panel uncheck option "Show XML Errors"

What is the expected result? The messages should not appear

This filter with de extension https://addons.mozilla.org/en-US/firefox/addon/console%C2%B2/ works fine

Firebug version (1.10b1): Browser version:Firefox FIREFOX_14_0b9 Operating system: W-XP, W-7

Note: if you go to https://dl.dropbox.com/u/245317/exampleCharacterEncoding.html https://dl.dropbox.com/u/245317/exampleCharacterEncodingFrame.html the messages does not appear, and the files are same.

Best regards

Attachments

Comment #1

Posted on Jun 27, 2012 by Helpful Wombat

I attached a patch for this putting it into the XML error category. Though I'm unsure if this should be put into that category or another one or if Firebug should just suppress them completely since they seem more or less pointless to me when it's logged locally but not online.

Honza, your opinion?

Sebastian

Attachments

Comment #2

Posted on Jul 23, 2012 by Swift Rhino

it's logged locally but not online.

No, actually also appears online, but dropbox added to the header as follows: "Content-Type text / html; charset = ascii"

I didnĀ“t see this when I sent the bug

If you try a server that does not modify the header, the error also appears

David

Comment #3

Posted on Jul 23, 2012 by Helpful Wombat

I see. Thanks for the info. I also missed that.

Sebastian

Comment #4

Posted on Aug 1, 2012 by Massive Wombat

The patch in comment #1 looks good to me, just couple of comments:

Honza

Comment #5

Posted on Aug 3, 2012 by Helpful Wombat
  • Shouldn't we change "Show XML Errors" option to "Show XML/HTML Errors"? There can be more error categories with "HTML" key (e.g. "DOM:HTML"), see: https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIScriptError#Categories Agree. Will change it.

  • Could/should we somehow display the context.droppedErrors info to the user? So, it's easier to figure out why some errors don't appear? Consider that a hint like that would almost always be shown because most pages generate errors and warnings. And I could be wrong but I don't believe we had that many complaints about that.

Sebastian

Comment #6

Posted on Aug 3, 2012 by Massive Wombat

And I could be wrong but I don't believe we had that many complaints about that. It happens quite often that developer are looking for a problem and not seeing any errors that could help them to identify the problem. If there would be a simple way (and playing with hidden options is not) to see that there are some additional errors, but not currently reported, I believe, it would definitely help.

Honza

Comment #7

Posted on Aug 3, 2012 by Helpful Wombat

I believe, it would definitely help. Well, I'm not holding you from creating a new issue for that. :-)

Sebastian

Comment #8

Posted on Aug 3, 2012 by Massive Wombat

Well, Sebastian, that's my feedback you asked for.

Honza

Comment #9

Posted on Aug 5, 2012 by Helpful Wombat

Added the modified patch at https://github.com/firebug/firebug/commit/142d07b0605c28388f3964caf074950aee00aee1.

Added issue 5789 for letting people know about filtered error messages.

Sebastian

Comment #10

Posted on Aug 17, 2012 by Massive Wombat

This issue has been fixed in Firebug 1.11a1 https://getfirebug.com/releases/firebug/1.11/firebug-1.11.0a1.xpi

Please check it out and let us know if it works for you.

Thanks for the help! Honza

Comment #11

Posted on Aug 17, 2012 by Swift Rhino

It works for me

Thanks

Comment #12

Posted on Aug 17, 2012 by Helpful Wombat

Thanks for the confirmation.

Sebastian

Status: Verified

Labels:
Type-Enhancement console 1.10-b1 FF-14 Test-case-available FBTest-wanted fixed-1.11-a1