My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 4885: Allow to black box scripts while debugging
5 people starred this issue and may be notified of changes. Back to list
 
Reported by wheresr...@gmail.com, Oct 4, 2011
I find "break on next" largely useless at the moment as I, like many javascript developers, use jQuery or another library to attach listeners. Normally what I want to see when I turn on "break on next" is the next line of MY code that runs, not the next line inside jQuery, which results in having to step through lots of code I didn't write and have no need to debug. 

So what I think would be useful would be something like the following
- a drop-down menu/dialog from break on next which has a list of current javascript src files (like the list available in the script panel to choose which script to view).
- each of these files would be ticked initially to include them in the break on next feature by default
- unticking one of the src files (by clicking on its name in the list) would result in that file being ignored when "break on next" is turned on. i.e. Break on next would break at the first line to run that isn't in that source file.

I haven't included a test case as I'm not sure what one would look like for this feature



Oct 4, 2011
#1 sebastia...@gmx.de
This could be related to issue 3996 and issue 1711.

A popup menu may be a good solution. Another idea would be to enhance the Location Menu (list of JS source files) for this purpose. So unchecking a script there would mean to ignore it. This could then also be used to ignore the script while stepping through the code. So Step Into would then just step over the functions of the unchecked scripts.
While the location menu might not be as obvious to be related to the Break On ... feature, it would avoid conflicts with other suggested changes like in issue 2562.

Regarding issue 2811 we could then implement this "ignore script" feature using the same UI as for disabling CSS properties. So by hovering a script an ignore symbol would be displayed. Clicking it will then have the same effect as described above by unchecking a script.

As a test case we need an explanation with step by step instructions of how this feature should work in your eyes. I imagine it so:
1. Open Firebug on this page
2. Enable and switch to the Script panel
3. Reload the page
4. Click the Break On Next button
   => Script execution will halt in "dit_scripts.js"
5. Click the Continue button
6. Click the Location Menu button
   => All scripts should have a check to signalize, that they will be regarded when BON is enabled
7. Uncheck "dit_scripts.js"
8. Click the Break On Next button again

=> Script execution should not stop in "dit_scripts.js" anymore
Status: Triaged
Cc: sebastia...@gmx.de
Labels: Type-Enhancement script Test-case-available
Jun 25, 2012
Project Member #2 simon.lindholm10
An "ignore script" function could also make e.g. XHR source links point to the highest non-ignored line in the stack, instead of into jQuery or so.
http://stackoverflow.com/questions/11143159/what-does-this-line-mean-in-firebug-blue-writing-on-right-hand-side
Mar 23, 2013
Project Member #3 sebastia...@gmail.com
(No comment was entered for this change.)
Cc: sebastia...@gmail.com
Apr 4, 2013
Project Member #4 sebastia...@gmail.com
(No comment was entered for this change.)
Summary: Add file filter for Break On Next (was: Break on next: add a filter by src file feature)
Cc: -sebastia...@gmx.de
Labels: debugger
Jul 23, 2013
Project Member #5 sroussey
(No comment was entered for this change.)
Cc: sroussey
Sep 23, 2013
Project Member #6 sebastia...@gmail.com
As described in  issue 4888  the DevTools team calls this feature "black boxing".

Regarding comment 2, I believe that deserves a follow-up issue. Could you please create one, Simon?

Sebastian
Cc: simon.lindholm10 odva...@gmail.com florent....@gmail.com
Labels: priority-high
Sep 23, 2013
Project Member #7 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: jsd2
Blockedon: fbug:5421
Sep 26, 2013
Project Member #8 sebastia...@gmail.com
 Issue 4888  has been merged into this issue.
Sep 26, 2013
Project Member #9 sebastia...@gmail.com
As described in  issue 4888  this feature shouldn't be limited to Break On Next but allow to completely ignore scripts while debugging. So I changed the summary to reflect that.

Sebastian
Summary: Allow to black box scripts while debugging (was: Add file filter for Break On Next)
Oct 15, 2013
Project Member #10 simon.lindholm10
(No comment was entered for this change.)
Blocking: fbug:6868
Oct 17, 2013
Project Member #11 odva...@gmail.com
@Farshid: this will be useful for the final implementation
https://github.com/firebug/firebug/commit/850c7d18b3ef05683c1e4dbe5b9b1b93e7c67d7a

Honza
Cc: farshid....@gmail.com
Oct 30, 2013
Project Member #12 sebastia...@gmail.com
I just realized that issue 2955 already mentioned this black boxing feature before. I turned that one into an issue for black boxing files inside the Console panel.

Sebastian
Apr 16, 2014
Project Member #13 sebastia...@gmail.com
(No comment was entered for this change.)
Labels: breakon
Sign in to add a comment

Powered by Google Project Hosting