My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 4425: Better support for Domplate templates inheritance
2 people starred this issue and may be notified of changes. Back to list
 
Reported by sebastia...@gmx.de, May 11, 2011
Domplate needs better support for template inheritance.
Currently the base template is changed by the derived template due to https://code.google.com/p/fbug/source/browse/branches/firebug1.8/content/firebug/domplate.js?spec=svn10401&r=10397#46

This would allow us to create a hierarchy of templates/widgets.
May 11, 2011
Project Member #1 odva...@gmail.com
(No comment was entered for this change.)
Labels: FBTest-wanted
Aug 8, 2011
#2 sebastia...@gmx.de
(No comment was entered for this change.)
Blocking: 4378
Aug 8, 2011
#3 sebastia...@gmx.de
Chris, maybe you could help here?
Cc: -sebastia...@gmx.de christ...@christophdorn.com
Aug 8, 2011
Project Member #4 christ...@christophdorn.com
The way many domplate templates are written assumes that inherited templates get merged. Changing this will break a lot of code (unless prototypical inheritance is used but that will not avoid conflicts between templates) and require other changes in the domplate lib I think. It would be nice, but realistically the current domplate implementation is too cryptic to make it practical to add to. It really needs to be re-implemented or refactored first.

I hope to write a new implementation that is based on an inherited modular template system I have been re-implementing and improving over the years which will be compatible with domplates at some point.
Aug 10, 2011
#5 sebastia...@gmx.de
> I hope to write a new implementation that is based on an inherited modular template 
> system I have been re-implementing and improving over the years which will be 
> compatible with domplates at some point.

Great to hear that. Any idea of when you expect this to be done?
Aug 10, 2011
Project Member #6 christ...@christophdorn.com
I hope to have a workable solution some time next year.
Aug 17, 2011
#7 sebastia...@gmx.de
Ok, I wished the answer included something like one or two months, but though it's great you're working on this! :-)

Honza and I already discussed about a workaround for this for issue 4378. I posted his suggestion there.
Nov 3, 2011
Project Member #8 odva...@gmail.com
I managed to find a solution for this problem (you may call it a workaround)
R12187

All Firebug tests pass for me.

I tested with my own test case (automated test case yet to come)

We need yet try issue 4378

Honza

Status: Commit
Owner: odva...@gmail.com
Cc: -odva...@gmail.com
Nov 6, 2011
Project Member #9 odva...@gmail.com
FBTest at R12202

Honza
Nov 11, 2011
Project Member #10 odva...@gmail.com
Marking as started since this is not fixed yet.
Honza
Status: Started
Apr 23, 2013
Project Member #11 sebastia...@gmail.com
(No comment was entered for this change.)
Blocking: -fbug:4378 fbug:4378 fbug:4378
Sign in to add a comment

Powered by Google Project Hosting