My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 2458: Firebug does not stop JS when debugging events
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  johnjbar...@johnjbarton.com
Closed:  Nov 06
Type-Defect
debugger
Test-case-available
1.5


Sign in to add a comment
 
Reported by sroussey, Nov 04, 2009
Try this when running chromebug/firebug: set a
breakpoint in firebug/content/editor.js at the beginning of the update
method (around line 164 in my copy). Edit a text node on the page. It
will stop at the breakpoint. If you step through, it will throw an
exception at currentEditor.layout() because currentEditor is
undefined.

Now move the breakpoint to the if(saveNow) line. Again edit some text
node. Again you will be at the breakpoint, just after
currentEditor.layout(). So that line ran just fine and did not throw
an error. But if you look at the value of currentEditor it is still
undefined. There is an illusion that nothing has happened between the
two statements, though obviously something did
Comment 1 by johnjbar...@johnjbarton.com, Nov 04, 2009
I don't think this is caused by JS running somehow out of the thread or what ever.
Rather I guess that the breakpoint is interacting with the runtime. I've not seen
this but maybe because did not notice it.
Status: Triaged
Cc: johnjbar...@johnjbarton.com
Labels: Test-case-available 1.5
Comment 2 by johnjbar...@johnjbarton.com, Nov 04, 2009
Ok, I guess you can be right. The editor is exiting when the breakpoint hits, and
that is clearing the currentEditor value. Maybe this event is getting in before the
JS is stopped.
Comment 3 by sroussey, Nov 04, 2009
Right -- and you can see it happen visually too.
Comment 4 by johnjbar...@johnjbarton.com, Nov 04, 2009
Asking for info.
http://groups.google.com/group/mozilla.dev.platform/browse_thread/thread/7116f8aa5dd69339#
Comment 5 by johnjbar...@johnjbarton.com, Nov 05, 2009
R4780 on branches/firebug1.5, may not work for Chromebug
Status: Commit
Comment 6 by sroussey, Nov 05, 2009
Can you step through firebug code in chromebug with this patch?
Comment 7 by johnjbar...@johnjbarton.com, Nov 05, 2009
yes, and the mysterious currentEditor problem is fixed.
Comment 8 by sroussey, Nov 05, 2009
Ah, beautiful! Silly me only updated Firebug, not Chromebug. I was crossing my
fingers that it would fix Issue #2461 too, but it was not to be. Still, very very
excited! Thanks!
Comment 9 by johnjbar...@johnjbarton.com, Nov 06, 2009
Firebug 1.5b3
Status: Fixed
Owner: johnjbar...@johnjbarton.com
Cc: -johnjbar...@johnjbarton.com
Sign in to add a comment

Hosted by Google Code