1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266

/*
 * Copyright 2010 eBusinessInformation
 * 
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not
 * use this file except in compliance with the License. You may obtain a copy of
 * the License at
 * 
 * http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations under
 * the License.
 */
package com.excilys.blog.refactoring.initial;

import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.FutureTask;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

import junit.framework.Assert;

import org.junit.Before;
import org.junit.Test;

import com.excilys.blog.refactoring.GeoPoint;
import com.excilys.blog.refactoring.HullHelper;

public class InitialHullHelperTest {

    private HullHelper hullHelper;

    @Before
    public void setup() {
        hullHelper = new InitialHullHelper();
    }

    /* BEHAVIOR TESTS */

    @Test
    public void threePointsHullContainsAllPoints() {
        Set<GeoPoint> points = createThreePointsSet();

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        for (GeoPoint point : points) {
            Assert.assertTrue("Each point should be part of the hull", convexHull.contains(point));
        }
    }

    @Test
    public void hullLoopsOnItself() {
        Set<GeoPoint> points = createThreePointsSet();

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        Assert.assertEquals("Hull should contain one more point to loop", points.size() + 1, convexHull.size());

        Assert.assertSame("First point should be last point", convexHull.get(0), convexHull.get(convexHull.size() - 1));
    }

    @Test
    public void hullExcludesInnerPoints() {
        GeoPoint inner = new GeoPoint(0, 0);
        Set<GeoPoint> points = createTriangleSetAroundInner(inner);

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        Assert.assertFalse("Hull should not contain inner point", convexHull.contains(inner));

    }

    @Test
    public void hullIncludesOuterPoints() {
        GeoPoint inner = new GeoPoint(0, 0);
        Set<GeoPoint> points = createTriangleSetAroundInner(inner);

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        for (GeoPoint point : points) {
            if (point != inner) {
                Assert.assertTrue("Hull should contain all outer points", convexHull.contains(point));
            }
        }
    }

    @Test
    public void twoPointsHullContainsAllPoints() {

        final Set<GeoPoint> points = createTwoPointsSet();

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        for (GeoPoint point : points) {
            Assert.assertTrue("Each point should be part of the hull", convexHull.contains(point));
        }
    }

    @Test
    public void twoPointsHullLoopsOnItself() {
        Set<GeoPoint> points = createTwoPointsSet();

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        Assert.assertEquals("Hull should contain one more point to loop", points.size() + 1, convexHull.size());

        Assert.assertSame("First point should be last point", convexHull.get(0), convexHull.get(convexHull.size() - 1));
    }

    @Test
    public void rotationAntiClockWise() {
        Set<GeoPoint> points = new HashSet<GeoPoint>();

        GeoPoint northWest = new GeoPoint(10, 5);
        GeoPoint southWest = new GeoPoint(0, 0);
        GeoPoint southEast = new GeoPoint(5, 10);
        GeoPoint northEast = new GeoPoint(15, 15);

        points.add(northWest);
        points.add(southWest);
        points.add(southEast);
        points.add(northEast);

        List<GeoPoint> convexHull = hullHelper.computeConvexHull(points);

        Assert.assertSame("rotation should be anti clockwise", southWest, convexHull.get(0));
        Assert.assertSame("rotation should be anti clockwise", southEast, convexHull.get(1));
        Assert.assertSame("rotation should be anti clockwise", northEast, convexHull.get(2));
        Assert.assertSame("rotation should be anti clockwise", northWest, convexHull.get(3));

    }

    // @Test
    // public void pointsWithSameLongitude() {
    // Set<GeoPoint> points = new HashSet<GeoPoint>();
    //
    // GeoPoint northWest = new GeoPoint(10, 5);
    // GeoPoint southWest = new GeoPoint(0, 0);
    // GeoPoint southEast = new GeoPoint(5, 10);
    // GeoPoint northEast = new GeoPoint(15, 10);
    //
    // points.add(northWest);
    // points.add(southWest);
    // points.add(southEast);
    // points.add(northEast);
    //
    // List<GeoPoint> hull = hullHelper.computeConvexHull(points);
    //
    // Assert.assertEquals(5, hull.size());
    // }

    /* ERROR TESTS */

    @Test(expected = IllegalArgumentException.class)
    public void emptyPointsThrowsIllegalArgumentException() {
        hullHelper.computeConvexHull(new HashSet<GeoPoint>());
        Assert.fail("Empty set should throw an IllegalArgumentException");
    }

    // @Test(expected = IllegalArgumentException.class)
    // public void pointsNullThrowsIllegalArgumentException() {
    // hullHelper.computeConvexHull(null);
    // Assert.fail("Null set should throw an IllegalArgumentException");
    // }

    // @Test
    // public void onePointReturnsOnePointList() {
    // Set<GeoPoint> points = new HashSet<GeoPoint>();
    // GeoPoint geoPoint = new GeoPoint(10, 10);
    // points.add(geoPoint);
    // List<GeoPoint> hull = hullHelper.computeConvexHull(points);
    // Assert.assertEquals(1, hull.size());
    // Assert.assertSame(geoPoint, hull.get(0));
    // }

    /* TESTS THAT DEMONSTRATE BUGS */

    @Test(expected = NullPointerException.class)
    public void pointsNullThrowsNullPointerException() {
        hullHelper.computeConvexHull(null);
        Assert.fail("Null set should throw a NullPointerException");
    }

    @Test(expected = TimeoutException.class)
    public void onePointSetLoopEndlessly() throws Exception {
        final Set<GeoPoint> points = new HashSet<GeoPoint>();
        points.add(new GeoPoint(10, 10));

        timeoutAfterDelay(300, new Runnable() {
            public void run() {
                hullHelper.computeConvexHull(points);
            }
        });
        Assert.fail("One point set should loop endlessly (timeout from tests after 300 ms)");
    }

    @Test(expected = RuntimeException.class)
    public void computationFail() {
        Set<GeoPoint> points = new HashSet<GeoPoint>();

        GeoPoint northWest = new GeoPoint(10, 5);
        GeoPoint southWest = new GeoPoint(0, 0);
        GeoPoint southEast = new GeoPoint(5, 10);
        GeoPoint northEast = new GeoPoint(15, 10);

        points.add(northWest);
        points.add(southWest);
        points.add(southEast);
        points.add(northEast);

        hullHelper.computeConvexHull(points);

        Assert.fail("Should fail when there are two eastern points with same longitude");
    }

    /* HELPER METHODS */

    private Set<GeoPoint> createTwoPointsSet() {
        Set<GeoPoint> points = new HashSet<GeoPoint>();
        points.add(new GeoPoint(0, 0));
        points.add(new GeoPoint(0, 10));
        return points;
    }

    private void timeoutAfterDelay(int delayInMs, Runnable codeToRun) throws TimeoutException, InterruptedException,
            ExecutionException {

        ExecutorService executor = Executors.newCachedThreadPool();

        FutureTask<?> future = new FutureTask<Object>(codeToRun, null);

        executor.submit(future);

        future.get(delayInMs, TimeUnit.MILLISECONDS);
    }

    private Set<GeoPoint> createThreePointsSet() {
        Set<GeoPoint> points = new HashSet<GeoPoint>();
        points.add(new GeoPoint(0, 0));
        points.add(new GeoPoint(0, 10));
        points.add(new GeoPoint(10, 0));
        return points;
    }

    private Set<GeoPoint> createTriangleSetAroundInner(GeoPoint inner) {

        double latitude = inner.getLatitude();
        double longitude = inner.getLongitude();

        Set<GeoPoint> points = new HashSet<GeoPoint>();

        points.add(inner);
        points.add(new GeoPoint(latitude - 10, longitude - 10));
        points.add(new GeoPoint(latitude + 10, longitude - 10));
        points.add(new GeoPoint(latitude, longitude + 10));

        return points;
    }
}