My favorites | Sign in
Project Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 39: Lyrics - when there's only one track with lyrics available for an artist @leoslyrics, it gets displayed for every song of that artist
1 person starred this issue and may be notified of changes. Back to list
Status:  Started
Owner:  rockstar.dev
Type-Defect
Priority-Medium


Sign in to add a comment
 
Reported by dominikowski, Feb 26, 2008
I can confirm this with the artist Boards of Canada, who only has one song
with lyrics: One Very Important Thought.

These lyrics are found on http://www.leoslyrics.com

Now, for every track of Boards of Canada, I'm getting these lyrics
displayed. The track "One Very Important Thought" doesn't even have to be
in a currently playing album, the lyrics get displayed for every song of
this artist.

 
Comment 1 by charclo.michael, Mar 26, 2008
This is because entertainer looks for the lyrics at leoslyrics.com and if the lyrics
for that song don't exist it takes the next best thing. For example if you have a
song with artist "Boards of Canada" and title "test" it will give you the lyrics of
"One Very Important
Thought"(http://api.leoslyrics.com/api_search.php?auth=Entertainer&artist=Boards%20of%20Canada&songtitle=test).
There could be an extra to see if the lyrics are an exact match.
Comment 2 by rockstar.dev, Mar 26, 2008
Looking at the result of doing a GET on the url, charclo.michael is correct.  That's
the search interface, and the current code does the equivalent of google's "I'm
feeling lucky" button, which turns out not so lucky in the end.

I'll wait for a patch from charclo.michael
Status: Started
Owner: rockstar.dev
Comment 3 by rockstar.dev, Mar 26, 2008
Attached is charclo.michael's patch
lyrics_patch.diff
935 bytes   Download
Sign in to add a comment

Hosted by Google Code