issue 1
(String.prototype monkeypatching) Status changed by JustinBMeyer
- The new version is coming out w/o this.
Status: Accepted
The new version is coming out w/o this.
Status: Accepted
Oct 28, 2009
issue 2
(Comments) commented on by JustinBMeyer
- You can't just do <% /* abc */ %>
You can't just do <% /* abc */ %>
Oct 28, 2009
r70
(new, faster version, extracted from JMVC) committed by JustinBMeyer
- new, faster version, extracted from JMVC
new, faster version, extracted from JMVC
Oct 13, 2009
issue 2
(Comments) reported by xanatos78
- Would it be possible to add the <%-- --%> comment "escape"?
Thanks
Would it be possible to add the <%-- --%> comment "escape"?
Thanks
May 09, 2009
issue 1
(String.prototype monkeypatching) reported by Zack.Carter
- rsplit and chop are unnecessary additions to String.prototype, considering
they are only used a combined 3 times, and only within the library. Locally
scoped functions would suffice and would avoid modifications to the global
namespace (important when writing library code.) It seems these additions
are an artifact of the Ruby port, but are unnecessary and potentially
harmful here.
Patch is attached.
rsplit and chop are unnecessary additions to String.prototype, considering
they are only used a combined 3 times, and only within the library. Locally
scoped functions would suffice and would avoid modifications to the global
namespace (important when writing library code.) It seems these additions
are an artifact of the Ruby port, but are unnecessary and potentially
harmful here.
Patch is attached.