Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags in instr to indicate if an instruction read/write memory. #293

Open
derekbruening opened this issue Nov 27, 2014 · 1 comment
Open

Comments

@derekbruening
Copy link
Contributor

From qin.zhao@gmail.com on April 19, 2010 15:41:02

Add flag in instr to indicate if an instruction reads or writes memory.
This is to improve the performance of instr_reads_memory and
instr_writes_memory.
We should have flag to show read/write and unknown, so functions only need
iterate the operands if it is unknown.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=293

@derekbruening
Copy link
Contributor Author

From derek.br...@gmail.com on April 19, 2010 12:45:23

I believe the 32-bit flags field has all bit positions already taken.
it may not be worth the extra space to optimize this if can't fit into existing fields.
but yes this is something common in clients, to call these routines and then proceed
to do a second iteration over opnds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant