Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cmake 2.8's STRINGS property for tri-state boolean option vars #170

Open
derekbruening opened this issue Nov 27, 2014 · 2 comments
Open

use cmake 2.8's STRINGS property for tri-state boolean option vars #170

derekbruening opened this issue Nov 27, 2014 · 2 comments
Labels
Component-Build Migrated Priority-Low

Comments

@derekbruening
Copy link
Contributor

From qin.zhao@gmail.com on July 16, 2009 22:47:38

When using CMake GUI to configure the compilation option for DEBUG build,
switch DEBUG ON only makes later compilation failure. This is because KSTAT
is not switched ON.
DEBUG and KSTAT options should be associated together.

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=170
@derekbruening
Copy link
Contributor Author

From derek.br...@gmail.com on August 08, 2009 13:07:13

I'll fix this.
The issue is that KSTAT is user-exposed and the system thinks the user
set it to OFF. What we want is to determine whether the user set it or
whether it's at its default value. The suggestion from a CMake expert is
to set it to an empty string and make the user type ON or OFF to change it
(should be very rare to do so), and if set to empty string we then
shadow it with a local var set to the default value. In CMake 2.8 we can use
an enum which will become a drop-down list in the GUI.

Owner: derek.bruening

@derekbruening
Copy link
Contributor Author

From derek.br...@gmail.com on August 08, 2009 18:12:06

fixed in r196 leaving issue open to cover switching to enum values once cmake 2.8 is out

Summary: use cmake 2.8's STRINGS property for tri-state boolean option vars
Labels: Component-Build

@fhahn fhahn mentioned this issue May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component-Build Migrated Priority-Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derekbruening