Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make linux signal handling more robust when interrupting lock holder #150

Open
derekbruening opened this issue Nov 27, 2014 · 3 comments
Open

make linux signal handling more robust when interrupting lock holder #150

derekbruening opened this issue Nov 27, 2014 · 3 comments
Labels
Migrated OpSys-Linux Priority-Low

Comments

@derekbruening
Copy link
Contributor

From derek.br...@gmail.com on May 28, 2009 18:56:39

this was PR 205795

typically due to the signal handler needing to query something that
uses a lock: in_fcache, stats increment, etc. some of this was fixed long
ago but in_fcache is still used in a few places w/o earlier heuristic
lockless guards.

xref bugs where the culprit may be SIGALRMs interrupting DR in bad spots
(will file as Issues eventually):
xref PR 314391
xref PR 313561
xref PR 314081

also xref pc profiling issues w/ stats lock (PR 205860)

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=150
@derekbruening
Copy link
Contributor Author

From derek.br...@gmail.com on May 28, 2009 15:58:02

in r163 :

  • added safe_is_in_fcache() to improve the situation (eliminates the hang
    that I encountered)

leaving open for further work

@derekbruening
Copy link
Contributor Author

From cjm...@gmail.com on June 02, 2009 04:41:22

Hello,
I have a question when calling the functions of instr_reads_memory(instr_t
*instr) and instr_writes_memory. It seems that "pop eax" is a memory reading
instruction, for the instr_reads_memory function reture TRUE when encourting that
insturction, why?
I need help, and I have no idea now.

@derekbruening
Copy link
Contributor Author

From qin.zhao@gmail.com on June 02, 2009 07:13:38

Did I miss anything?
It is perfectly reasonable that "pop eax" reads memory and instr_reads_memory
function returns TRUE for that instruction.

@derekbruening derekbruening mentioned this issue Nov 28, 2014
Open
@groleo groleo mentioned this issue Dec 17, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Migrated OpSys-Linux Priority-Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derekbruening