dotnetportmapper - Project Hosting on Google Code

Last 30 days Dec 12, 2009 issue 4 (dependency DLLs don't appear to work on Windows 7 x64 ) commented on by Micheal.M.5089 - I'm running 32 bit and I was having tht esame problem with that DLL not loading. I changed it to AnyCPU config and it worked just fine. I'm running 32 bit and I was having tht esame problem with that DLL not loading. I changed it to AnyCPU config and it worked just fine. Dec 12, 2009 issue 4 (dependency DLLs don't appear to work on Windows 7 x64 ) commented on by Micheal.M.5089 - Try building it in AnyCPU config. Worked for me. Try building it in AnyCPU config. Worked for me. Dec 12, 2009 issue 5 (Invoke) reported by Micheal.M.5089 - Great work, only one issue. using invoke doesn't work in wpf projects. I removed your invoke calls and just called the delegates straight up. This may cause some cross threading issues but its better than nothing working at all. Try to keep form/gui out of external DLL's if all possible. Also I'm running 32 bit Windows 7, I changed it build in AnyCPU config and it worked just fine. I was having the same problems as the other guy with not loading the dll, after changing it to AnyCPU config it fixed it. Everything is running great now. Great work, only one issue. using invoke doesn't work in wpf projects. I removed your invoke calls and just called the delegates straight up. This may cause some cross threading issues but its better than nothing working at all. Try to keep form/gui out of external DLL's if all possible. Also I'm running 32 bit Windows 7, I changed it build in AnyCPU config and it worked just fine. I was having the same problems as the other guy with not loading the dll, after changing it to AnyCPU config it fixed it. Everything is running great now. Older Dec 01, 2009 issue 4 (dependency DLLs don't appear to work on Windows 7 x64 ) commented on by rosspirtle - Further, the application works correctly on Windows XP (service pack 3). Further, the application works correctly on Windows XP (service pack 3). Dec 01, 2009 issue 4 (dependency DLLs don't appear to work on Windows 7 x64 ) reported by rosspirtle - I've compiled my application using Microsoft Visual Studio 2008 (sp1) on Windows 7 (64bit). I get the following error when I try to add a port mapping: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B) on line 400 of TCMNATPMPPortMapper.cs which reads: r = NATPMP.initnatpmp(ref natpmp); As further information, the "Port Map 1.0" example application also fails (not sure what the error is, but I assume it is the same problem). The two DLL files and the oui.txt file are in the bin/debug directory with the EXE and the latest were downloaded today 12/01/2009. Any suggestions? Thanks, Ross I've compiled my application using Microsoft Visual Studio 2008 (sp1) on Windows 7 (64bit). I get the following error when I try to add a port mapping: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B) on line 400 of TCMNATPMPPortMapper.cs which reads: r = NATPMP.initnatpmp(ref natpmp); As further information, the "Port Map 1.0" example application also fails (not sure what the error is, but I assume it is the same problem). The two DLL files and the oui.txt file are in the bin/debug directory with the EXE and the latest were downloaded today 12/01/2009. Any suggestions? Thanks, Ross Oct 04, 2009 issue 3 (Doesn't detect my modem) commented on by CTSSTC - Now it seems that it doesn't detect when I use the SVN version and just locks up with the downloaded zip version. Now it seems that it doesn't detect when I use the SVN version and just locks up with the downloaded zip version. Oct 04, 2009 issue 3 (Doesn't detect my modem) commented on by CTSSTC - Just I think re-ran the 1.0 download and it worked, so now I'm thinking maybe I didn't have libraries when I was compiling? But main point is... I saw it work, and it was amazing, : ) Just I think re-ran the 1.0 download and it worked, so now I'm thinking maybe I didn't have libraries when I was compiling? But main point is... I saw it work, and it was amazing, : ) Oct 04, 2009 issue 3 (Doesn't detect my modem) reported by CTSSTC - Summary pretty much explains it I've tried an open source C++ project and it worked, so maybe this needs updating? I'd love to see something in C# though : ) Also at my friend's house same thing, it might have seen more responsive but all in all it didn't work at his house either. I have an actiontec pk-5000 and he had some white fancy looking netgear Thanks Summary pretty much explains it I've tried an open source C++ project and it worked, so maybe this needs updating? I'd love to see something in C# though : ) Also at my friend's house same thing, it might have seen more responsive but all in all it didn't work at his house either. I have an actiontec pk-5000 and he had some white fancy looking netgear Thanks Oct 02, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by iltafas - Is it possible for anyone to build the latest source and put it up to be available for download? Is it possible for anyone to build the latest source and put it up to be available for download? Oct 02, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by iltafas - Is it possible for anyone to build the latest source and put it up to be available for download? Is it possible for anyone to build the latest source and put it up to be available for download? Apr 06, 2009 issue 2 (UPnPPortMapper AccessViolation it is cause by MiniUPnP.UPNP_...) Status changed by deusty - Thank you very much for this patch! Your changes have been committed. Sorry it took us forever to do it! Status: Fixed Thank you very much for this patch! Your changes have been committed. Sorry it took us forever to do it! Status: Fixed Apr 06, 2009 r24 (Bug fix for issue #2) committed by deusty - Bug fix for issue #2 Bug fix for issue #2 Apr 04, 2009 issue 2 (UPnPPortMapper AccessViolation it is cause by MiniUPnP.UPNP_...) commented on by jfkotlow - Yes, that's why there are try...catch in the code each time the dll is called. Yes, that's why there are try...catch in the code each time the dll is called. Apr 03, 2009 issue 2 (UPnPPortMapper AccessViolation it is cause by MiniUPnP.UPNP_...) commented on by robbieha...@deusty.com - I'm working on integrating this change into the project. Was this bug causing the application to crash? I'm working on integrating this change into the project. Was this bug causing the application to crash? Jan 23, 2009 issue 2 (UPnPPortMapper AccessViolation it is cause by MiniUPnP.UPNP_...) reported by jfkotlow - What version of the product are you using? On what operating system? Vista pro edition - AMD Turion64 The problem: In: TCUPnPPortMapper.cs Procedure: RefreshExternalIPThread() The call of "MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length)" corrupt the program memory. The each time you use "urls" you have an access violation. Why: If you watch in miniupnpc.c GetIGDFromUrl call GetUPNPUrls witch make malloc on urls. C# seem to not like that. Probably "urls" is not well declared but i can't find the good way to make it run. Be aware that a malloc is done so after use you must call FreeUPNPUrls (struct UPNPUrls * urls) in the dll!!! Solution I've tested its works (no more accessviolation....) -> In Class MiniUPnP (MiniUPnP.cs) i've created: [StructLayout(LayoutKind.Sequential)] public unsafe struct UPNPUrls_2 { public char controlURL; public char ipcondescURL; public char* controlURL_CIF; } and [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public unsafe static extern void FreeUPNPUrls([In] UPNPUrls_2* urls); and add a new declaration of [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public static unsafe extern int UPNP_GetIGDFromUrl ([In] String rootDescUrl, [In] UPNPUrls_2 urls, [In, Out] ref IGDdatas datas, [MarshalAs(UnmanagedType.LPArray, SizeParamIndex = 4)] byte[] lanAddr, [In] int lanAddrLength); -> In TCUPnPPortMapper.cs: Relace the call of MiniUPnP.UPNP_GetIGDFromUrl by try { //r = MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.UPNPUrls_2 urls_2 = new MiniUPnP.UPNPUrls_2(); unsafe { r = MiniUPnP.UPNP_GetIGDFromUrl(url, &urls_2, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.FreeUPNPUrls(&urls_2); } // Renseigne urls GetUPNPUrls(url); // On se subsitue a miniUpnp pour renseigner urls } Then create GetUPNPUrls (wich replace what it made in dll) private void GetUPNPUrls(String url) { // Copie de l'URL de Base if (igddata.urlbase != string.Empty) urls.ipcondescURL = igddata.urlbase; else urls.ipcondescURL = url; // On enleve tout apres l'URL de base int index_fin_url = urls.ipcondescURL.IndexOf('/', 7); // 7 = http:// if (index_fin_url >= 0) urls.ipcondescURL = urls.ipcondescURL.Substring(0, index_fin_url); urls.controlURL = urls.ipcondescURL + igddata.controlurl; urls.controlURL_CIF = urls.ipcondescURL + igddata.controlurl_CIF; urls.ipcondescURL += igddata.scpdurl; } --------------------------------------------------- This solution is not very nice but it works. I think the best way of correct the bug is to redeclare UPNPUrls but i can't find how to do that. An other way is to modify the miniupnp.dll (remove the malloc) and create the function GetUPNPUrls int the c# code Let me know if you find something better !!!!! What version of the product are you using? On what operating system? Vista pro edition - AMD Turion64 The problem: In: TCUPnPPortMapper.cs Procedure: RefreshExternalIPThread() The call of "MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length)" corrupt the program memory. The each time you use "urls" you have an access violation. Why: If you watch in miniupnpc.c GetIGDFromUrl call GetUPNPUrls witch make malloc on urls. C# seem to not like that. Probably "urls" is not well declared but i can't find the good way to make it run. Be aware that a malloc is done so after use you must call FreeUPNPUrls (struct UPNPUrls urls) in the dll!!! Solution I've tested its works (no more accessviolation....) -> In Class MiniUPnP (MiniUPnP.cs) i've created: [StructLayout(LayoutKind.Sequential)] public unsafe struct UPNPUrls_2 { public char controlURL; public char ipcondescURL; public char* controlURL_CIF; } and [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public unsafe static extern void FreeUPNPUrls([In] UPNPUrls_2* urls); and add a new declaration of [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public static unsafe extern int UPNP_GetIGDFromUrl ([In] String rootDescUrl, [In] UPNPUrls_2 urls, [In, Out] ref IGDdatas datas, [MarshalAs(UnmanagedType.LPArray, SizeParamIndex = 4)] byte[] lanAddr, [In] int lanAddrLength); -> In TCUPnPPortMapper.cs: Relace the call of MiniUPnP.UPNP_GetIGDFromUrl by try { //r = MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.UPNPUrls_2 urls_2 = new MiniUPnP.UPNPUrls_2(); unsafe { r = MiniUPnP.UPNP_GetIGDFromUrl(url, &urls_2, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.FreeUPNPUrls(&urls_2); } // Renseigne urls GetUPNPUrls(url); // On se subsitue a miniUpnp pour renseigner urls } Then create GetUPNPUrls (wich replace what it made in dll) private void GetUPNPUrls(String url) { // Copie de l'URL de Base if (igddata.urlbase != string.Empty) urls.ipcondescURL = igddata.urlbase; else urls.ipcondescURL = url; // On enleve tout apres l'URL de base int index_fin_url = urls.ipcondescURL.IndexOf('/', 7); // 7 = http:// if (index_fin_url >= 0) urls.ipcondescURL = urls.ipcondescURL.Substring(0, index_fin_url); urls.controlURL = urls.ipcondescURL + igddata.controlurl; urls.controlURL_CIF = urls.ipcondescURL + igddata.controlurl_CIF; urls.ipcondescURL += igddata.scpdurl; } --------------------------------------------------- This solution is not very nice but it works. I think the best way of correct the bug is to redeclare UPNPUrls but i can't find how to do that. An other way is to modify the miniupnp.dll (remove the malloc) and create the function GetUPNPUrls int the c# code Let me know if you find something better !!!!! Jan 04, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) Status changed by deusty - Awesome! Status: Verified Awesome! Status: Verified Jan 04, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - I downloaded the latest source, everything seems to be ok now, I can confirm that the problem is resolved, thank you! I downloaded the latest source, everything seems to be ok now, I can confirm that the problem is resolved, thank you! Jan 04, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by robbieha...@deusty.com - Ok, I just recompiled the dll's using "gcc -shared" instead of "dllwrap". According to users on the mingw lists, this should help solve the problem. These changes were just committed. Let me know if this fixes it. Ok, I just recompiled the dll's using "gcc -shared" instead of "dllwrap". According to users on the mingw lists, this should help solve the problem. These changes were just committed. Let me know if this fixes it. Jan 04, 2009 r23 (Switching to dll's compiled with "gcc -shared" as opposed to...) committed by deusty - Switching to dll's compiled with "gcc -shared" as opposed to "dllwrap". Switching to dll's compiled with "gcc -shared" as opposed to "dllwrap". Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by robbieha...@deusty.com - Very interesting. Both dll's were created using dllwrap. I'll see if I can create them without it... Very interesting. Both dll's were created using dllwrap. I'll see if I can create them without it... Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - It looks very similar to this case http://lists-archives.org/mingw-users/11142-net- interface-with-dll-0x800703e6.html It looks very similar to this case http://lists-archives.org/mingw-users/11142-net- interface-with-dll-0x800703e6.html Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by robbieha...@deusty.com - miniupnp.dll is correct. I was under the impression that the application would look in the same directory as the application: http://msdn.microsoft.com/en-us/library/ms682586.aspx But perhaps we should be calling SetDllDirectory, or setting Environment.CurrentDirectory? miniupnp.dll is correct. I was under the impression that the application would look in the same directory as the application: http://msdn.microsoft.com/en-us/library/ms682586.aspx But perhaps we should be calling SetDllDirectory, or setting Environment.CurrentDirectory? Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - Here are the contents of my build folder: Volume in drive D is Data Volume Serial Number is *-* Directory of D:\Temp\NewUpnp01\PortMap\bin\x86\Debug 04.01.2009 13:37 <DIR> . 04.01.2009 13:37 <DIR> .. 03.01.2009 16:38 40 197 miniupnp.dll 03.01.2009 16:38 25 076 natpmp.dll 03.01.2009 16:38 339 576 oui.txt 03.01.2009 21:13 36 864 PortMap.exe 03.01.2009 21:13 58 880 PortMap.pdb 03.01.2009 21:13 14 848 PortMap.vshost.exe 21.07.2007 01:33 490 PortMap.vshost.exe.manifest 03.01.2009 21:13 48 640 TCMPortMapper.dll 03.01.2009 21:13 97 792 TCMPortMapper.pdb 10 File(s) 662 363 bytes As you can see, everything gets copied in it. (You meant miniupnp.dll , not upnp.dll , right?) Here are the contents of my build folder: Volume in drive D is Data Volume Serial Number is **-* Directory of D:\Temp\NewUpnp01\PortMap\bin\x86\Debug 04.01.2009 13:37 <DIR> . 04.01.2009 13:37 <DIR> .. 03.01.2009 16:38 40 197 miniupnp.dll 03.01.2009 16:38 25 076 natpmp.dll 03.01.2009 16:38 339 576 oui.txt 03.01.2009 21:13 36 864 PortMap.exe 03.01.2009 21:13 58 880 PortMap.pdb 03.01.2009 21:13 14 848 PortMap.vshost.exe 21.07.2007 01:33 490 PortMap.vshost.exe.manifest 03.01.2009 21:13 48 640 TCMPortMapper.dll 03.01.2009 21:13 97 792 TCMPortMapper.pdb 10 File(s) 662 363 bytes As you can see, everything gets copied in it. (You meant miniupnp.dll , not upnp.dll , right?) Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by robbieha...@deusty.com - Right, and the natpmp.dll and upnp.dll files should get copied into the build folder right next to the executable. Is this not happening on your machine? Right, and the natpmp.dll and upnp.dll files should get copied into the build folder right next to the executable. Is this not happening on your machine? Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - I did as you suggested: restarted VS, rebuilt the project, it didn't help, rebooted pc, rebuilt the project again, but still getting the same error. I have searched for natpmp.dll in all drives, the only place it was found is dotnetportmapper's source folder, so it is not a dll hell problem. I did as you suggested: restarted VS, rebuilt the project, it didn't help, rebooted pc, rebuilt the project again, but still getting the same error. I have searched for natpmp.dll in all drives, the only place it was found is dotnetportmapper's source folder, so it is not a dll hell problem. Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by robbieha...@deusty.com - I occasionally get these crashes too, but I don't think it has to do with 64-bit because I experience the problem in both 32 and 64 bit windows. I think it's a windows and/or visual studio problem. Here's how I usually solve it: Without making any code changes, shut down visual studio, and then reopen the project, and rebuild the solution. This solves the problem about 25% of the time for me. If this doesn't work, reboot windows. This solves the problem the other 75% of the time. Is this a windows dll hell problem? I occasionally get these crashes too, but I don't think it has to do with 64-bit because I experience the problem in both 32 and 64 bit windows. I think it's a windows and/or visual studio problem. Here's how I usually solve it: Without making any code changes, shut down visual studio, and then reopen the project, and rebuild the solution. This solves the problem about 25% of the time for me. If this doesn't work, reboot windows. This solves the problem the other 75% of the time. Is this a windows dll hell problem? Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - deusty, I did some more testing, revision 22 is still crashing on 64-bit Windows Vista (I am using Visual Studio 2008) System.DllNotFoundException: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) at TCMPortMapper.NATPMP.initnatpmp(natpmp_t& p) at TCMPortMapper.NATPMPPortMapper.RefreshExternalIPThread() in D:\Temp \NewUpnp01\TCMPortMapper\TCMNATPMPPortMapper.cs:line 399 at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() private void RefreshExternalIPThread() { Monitor.Enter(multiThreadLock); OnDidBeginWorking(); NATPMP.natpmp_t natpmp = new NATPMP.natpmp_t(); NATPMP.natpmpresp_t response = new NATPMP.natpmpresp_t(); int r; Win32.TimeValue timeout = new Win32.TimeValue(); Win32.FileDescriptorSet fds = new Win32.FileDescriptorSet(1); bool didFail = false; Exception here --> r = NATPMP.initnatpmp(ref natpmp); <--Exception here if (r < 0) { didFail = true; } ... deusty, I did some more testing, revision 22 is still crashing on 64-bit Windows Vista (I am using Visual Studio 2008) System.DllNotFoundException: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) at TCMPortMapper.NATPMP.initnatpmp(natpmp_t& p) at TCMPortMapper.NATPMPPortMapper.RefreshExternalIPThread() in D:\Temp \NewUpnp01\TCMPortMapper\TCMNATPMPPortMapper.cs:line 399 at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() private void RefreshExternalIPThread() { Monitor.Enter(multiThreadLock); OnDidBeginWorking(); NATPMP.natpmp_t natpmp = new NATPMP.natpmp_t(); NATPMP.natpmpresp_t response = new NATPMP.natpmpresp_t(); int r; Win32.TimeValue timeout = new Win32.TimeValue(); Win32.FileDescriptorSet fds = new Win32.FileDescriptorSet(1); bool didFail = false; Exception here --> r = NATPMP.initnatpmp(ref natpmp); <--Exception here if (r < 0) { didFail = true; } ... Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - deusty, I did some more testing, revision 22 is still crashing on 64-bit Windows Vista (I am using Visual Studio 2008) System.DllNotFoundException: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) at TCMPortMapper.NATPMP.initnatpmp(natpmp_t& p) at TCMPortMapper.NATPMPPortMapper.RefreshExternalIPThread() in D:\Temp \NewUpnp01\TCMPortMapper\TCMNATPMPPortMapper.cs:line 399 at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() private void RefreshExternalIPThread() { Monitor.Enter(multiThreadLock); OnDidBeginWorking(); NATPMP.natpmp_t natpmp = new NATPMP.natpmp_t(); NATPMP.natpmpresp_t response = new NATPMP.natpmpresp_t(); int r; Win32.TimeValue timeout = new Win32.TimeValue(); Win32.FileDescriptorSet fds = new Win32.FileDescriptorSet(1); bool didFail = false; Exception here --> r = NATPMP.initnatpmp(ref natpmp); <--Exception here if (r < 0) { didFail = true; } ... Add a Comment deusty, I did some more testing, revision 22 is still crashing on 64-bit Windows Vista (I am using Visual Studio 2008) System.DllNotFoundException: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) at TCMPortMapper.NATPMP.initnatpmp(natpmp_t& p) at TCMPortMapper.NATPMPPortMapper.RefreshExternalIPThread() in D:\Temp \NewUpnp01\TCMPortMapper\TCMNATPMPPortMapper.cs:line 399 at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() private void RefreshExternalIPThread() { Monitor.Enter(multiThreadLock); OnDidBeginWorking(); NATPMP.natpmp_t natpmp = new NATPMP.natpmp_t(); NATPMP.natpmpresp_t response = new NATPMP.natpmpresp_t(); int r; Win32.TimeValue timeout = new Win32.TimeValue(); Win32.FileDescriptorSet fds = new Win32.FileDescriptorSet(1); bool didFail = false; Exception here --> r = NATPMP.initnatpmp(ref natpmp); <--Exception here if (r < 0) { didFail = true; } ... Add a Comment Jan 03, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - deusty, I did some more testing, revision 22 is still crashing on 64-bit Windows Vista (I am using Visual Studio 2008) System.DllNotFoundException: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) at TCMPortMapper.NATPMP.initnatpmp(natpmp_t& p) at TCMPortMapper.NATPMPPortMapper.RefreshExternalIPThread() in D:\Temp \NewUpnp01\TCMPortMapper\TCMNATPMPPortMapper.cs:line 399 at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() private void RefreshExternalIPThread() { Monitor.Enter(multiThreadLock); OnDidBeginWorking(); NATPMP.natpmp_t natpmp = new NATPMP.natpmp_t(); NATPMP.natpmpresp_t response = new NATPMP.natpmpresp_t(); int r; Win32.TimeValue timeout = new Win32.TimeValue(); Win32.FileDescriptorSet fds = new Win32.FileDescriptorSet(1); bool didFail = false; <--Exception herer = NATPMP.initnatpmp(ref natpmp); <--Exception here if (r < 0) { didFail = true; } ... deusty, I did some more testing, revision 22 is still crashing on 64-bit Windows Vista (I am using Visual Studio 2008) System.DllNotFoundException: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) at TCMPortMapper.NATPMP.initnatpmp(natpmp_t& p) at TCMPortMapper.NATPMPPortMapper.RefreshExternalIPThread() in D:\Temp \NewUpnp01\TCMPortMapper\TCMNATPMPPortMapper.cs:line 399 at System.Threading.ThreadHelper.ThreadStart_Context(Object state) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.ThreadHelper.ThreadStart() private void RefreshExternalIPThread() { Monitor.Enter(multiThreadLock); OnDidBeginWorking(); NATPMP.natpmp_t natpmp = new NATPMP.natpmp_t(); NATPMP.natpmpresp_t response = new NATPMP.natpmpresp_t(); int r; Win32.TimeValue timeout = new Win32.TimeValue(); Win32.FileDescriptorSet fds = new Win32.FileDescriptorSet(1); bool didFail = false; <--Exception herer = NATPMP.initnatpmp(ref natpmp); <--Exception here if (r < 0) { didFail = true; } ... Jan 02, 2009 issue 1 (Program doesn't work on 64-bit Windows Vista) commented on by rekl...@val.udm.ru - deusty, thank you very much for the fix. I tested the revision 22, everything is OK now. Roman deusty, thank you very much for the fix. I tested the revision 22, everything is OK now. Roman Dec 30, 2008 issue 1 (Program doesn't work on 64-bit Windows Vista) changed by deusty - I verified the problem on 64-bit Windows, and it crashed just like you said. In visual studio, I changed the solution platform to x86 (as opposed to the project platform). This fixed the problem for me. I then removed the "Any CPU" platform to prevent the same problem from popping up again. The changes were checked in as revision 21. Please verify the problem was fixed. Status: Started Labels: Priority-High −Priority-Medium I verified the problem on 64-bit Windows, and it crashed just like you said. In visual studio, I changed the solution platform to x86 (as opposed to the project platform). This fixed the problem for me. I then removed the "Any CPU" platform to prevent the same problem from popping up again. The changes were checked in as revision 21. Please verify the problem was fixed. Status: Started Labels: Priority-High −Priority-Medium Dec 30, 2008 r22 (The method NATPMP.getdefaultgateway is now deprecated.) committed by deusty - The method NATPMP.getdefaultgateway is now deprecated. The method NATPMP.getdefaultgateway is now deprecated. Dec 30, 2008 r21 (Changed the platform to x86 so the project will compile and ...) committed by deusty - Changed the platform to x86 so the project will compile and run properly on 64-bit windows. Changed the platform to x86 so the project will compile and run properly on 64-bit windows. Dec 22, 2008 issue 1 (Program doesn't work on 64-bit Windows Vista) reported by rekl...@val.udm.ru - What steps will reproduce the problem? 1. Try to run port mapper executable from "Port Map 1.0.zip" on 64-bit Windows What is the expected output? What do you see instead? What version of the product are you using? On what operating system? Latest version from svn, revision 20 Please provide any additional information below. I tried to compile the program myself in x86 mode, but every time I try to run the program I am getting this error: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) What steps will reproduce the problem? 1. Try to run port mapper executable from "Port Map 1.0.zip" on 64-bit Windows What is the expected output? What do you see instead? What version of the product are you using? On what operating system? Latest version from svn, revision 20 Please provide any additional information below. I tried to compile the program myself in x86 mode, but every time I try to run the program I am getting this error: Unable to load DLL 'natpmp.dll': Invalid access to memory location. (Exception from HRESULT: 0x800703E6) Dec 12, 2008 r20 (Fixing bugs related to getdefaultgateway code. Should now pr...) committed by deusty - Fixing bugs related to getdefaultgateway code. Should now properly retrieve the router IP address in the .Net code. Special thanks to Jahanzeb Sherwani for providing code to help fix this bug. Fixing bugs related to getdefaultgateway code. Should now properly retrieve the router IP address in the .Net code. Special thanks to Jahanzeb Sherwani for providing code to help fix this bug. Aug 21, 2008 r19 (Adding try/catch around MiniUPNP.UPNP_DeletePortMapping meth...) committed by deusty - Adding try/catch around MiniUPNP.UPNP_DeletePortMapping methods. Adding try/catch around MiniUPNP.UPNP_DeletePortMapping methods. Aug 14, 2008 r18 (Added try/catch around add/remove system event delegates. I'...) committed by deusty - Added try/catch around add/remove system event delegates. I've witnessed exceptions from these method calls, although I have no idea why. It's .Net, what else can I say... Added try/catch around add/remove system event delegates. I've witnessed exceptions from these method calls, although I have no idea why. It's .Net, what else can I say... Aug 13, 2008 r17 (Added refresh button to port map application.) committed by deusty - Added refresh button to port map application. Added refresh button to port map application. Aug 13, 2008 r16 (Added ability to remove existing upnp port mappings (that do...) committed by deusty - Added ability to remove existing upnp port mappings (that don't belong to the application). Added ability to remove existing upnp port mappings (that don't belong to the application). Aug 13, 2008 r16 (Added ability to remove existing upnp port mappings (that do...) committed by deusty - Added ability to remove existing upnp port mappings (that don't belong to the application). Added ability to remove existing upnp port mappings (that don't belong to the application). Aug 13, 2008 r16 (Added ability to remove existing upnp port mappings (that do...) committed by deusty - Added ability to remove existing upnp port mappings (that don't belong to the application). Added ability to remove existing upnp port mappings (that don't belong to the application). Aug 13, 2008 r15 (Incrementing version number of framework.) committed by deusty - Incrementing version number of framework. Incrementing version number of framework. Aug 13, 2008 r14 (RequestUPnPMappingTable now doesn't bother updating port map...) committed by deusty - RequestUPnPMappingTable now doesn't bother updating port mappings. It simply updates the list of existing mappings. Added framework support to remove existing upnp port mappings (that don't belong to the application). RequestUPnPMappingTable now doesn't bother updating port mappings. It simply updates the list of existing mappings. Added framework support to remove existing upnp port mappings (that don't belong to the application). Aug 13, 2008 r14 (RequestUPnPMappingTable now doesn't bother updating port map...) committed by deusty - RequestUPnPMappingTable now doesn't bother updating port mappings. It simply updates the list of existing mappings. Added framework support to remove existing upnp port mappings (that don't belong to the application). RequestUPnPMappingTable now doesn't bother updating port mappings. It simply updates the list of existing mappings. Added framework support to remove existing upnp port mappings (that don't belong to the application). Aug 13, 2008 r13 (Commenting out udp client stuff until a solution is found fo...) committed by deusty - Commenting out udp client stuff until a solution is found for the problem. Commenting out udp client stuff until a solution is found for the problem. Aug 13, 2008 r12 (Minor bug fixes and improvements to the port map application...) committed by deusty - Minor bug fixes and improvements to the port map application. Minor bug fixes and improvements to the port map application. Aug 12, 2008 r11 (Bug fix (hopefully) for various exceptions related to call t...) committed by deusty - Bug fix (hopefully) for various exceptions related to call to MiniUPnP.UPNP_GetIGDFromUrl() method. Bug fix (hopefully) for various exceptions related to call to MiniUPnP.UPNP_GetIGDFromUrl() method. Jul 28, 2008 r10 (Forgot to increment the version number for the dll.) committed by deusty - Forgot to increment the version number for the dll. Forgot to increment the version number for the dll. Jul 28, 2008 r9 (Fixed bug related to a UPnP call somehow returning multiple ...) committed by deusty - Fixed bug related to a UPnP call somehow returning multiple port mappings for the same port. That is, multiple UDP port mappings for external port X, or multiple TCP port mappings for external port Y. This may be possible if there were multiple UPnP routers from the same vendor on the local network (maybe). Fixed bug related to a UPnP call somehow returning multiple port mappings for the same port. That is, multiple UDP port mappings for external port X, or multiple TCP port mappings for external port Y. This may be possible if there were multiple UPnP routers from the same vendor on the local network (maybe).

issue 2 (UPnPPortMapper AccessViolation it is cause by MiniUPnP.UPNP_...) reported by jfkotlow - What version of the product are you using? On what operating system? Vista pro edition - AMD Turion64 The problem: In: TCUPnPPortMapper.cs Procedure: RefreshExternalIPThread() The call of "MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length)" corrupt the program memory. The each time you use "urls" you have an access violation. Why: If you watch in miniupnpc.c GetIGDFromUrl call GetUPNPUrls witch make malloc on urls. C# seem to not like that. Probably "urls" is not well declared but i can't find the good way to make it run. Be aware that a malloc is done so after use you must call FreeUPNPUrls (struct UPNPUrls * urls) in the dll!!! Solution I've tested its works (no more accessviolation....) -> In Class MiniUPnP (MiniUPnP.cs) i've created: [StructLayout(LayoutKind.Sequential)] public unsafe struct UPNPUrls_2 { public char *controlURL; public char *ipcondescURL; public char* controlURL_CIF; } and [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public unsafe static extern void FreeUPNPUrls([In] UPNPUrls_2* urls); and add a new declaration of [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public static unsafe extern int UPNP_GetIGDFromUrl ([In] String rootDescUrl, [In] UPNPUrls_2 *urls, [In, Out] ref IGDdatas datas, [MarshalAs(UnmanagedType.LPArray, SizeParamIndex = 4)] byte[] lanAddr, [In] int lanAddrLength); -> In TCUPnPPortMapper.cs: Relace the call of MiniUPnP.UPNP_GetIGDFromUrl by try { //r = MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.UPNPUrls_2 urls_2 = new MiniUPnP.UPNPUrls_2(); unsafe { r = MiniUPnP.UPNP_GetIGDFromUrl(url, &urls_2, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.FreeUPNPUrls(&urls_2); } // Renseigne urls GetUPNPUrls(url); // On se subsitue a miniUpnp pour renseigner urls } Then create GetUPNPUrls (wich replace what it made in dll) private void GetUPNPUrls(String url) { // Copie de l'URL de Base if (igddata.urlbase != string.Empty) urls.ipcondescURL = igddata.urlbase; else urls.ipcondescURL = url; // On enleve tout apres l'URL de base int index_fin_url = urls.ipcondescURL.IndexOf('/', 7); // 7 = http:// if (index_fin_url >= 0) urls.ipcondescURL = urls.ipcondescURL.Substring(0, index_fin_url); urls.controlURL = urls.ipcondescURL + igddata.controlurl; urls.controlURL_CIF = urls.ipcondescURL + igddata.controlurl_CIF; urls.ipcondescURL += igddata.scpdurl; } --------------------------------------------------- This solution is not very nice but it works. I think the best way of correct the bug is to redeclare UPNPUrls but i can't find how to do that. An other way is to modify the miniupnp.dll (remove the malloc) and create the function GetUPNPUrls int the c# code Let me know if you find something better !!!!!

What version of the product are you using? On what operating system? Vista pro edition - AMD Turion64 The problem: In: TCUPnPPortMapper.cs Procedure: RefreshExternalIPThread() The call of "MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length)" corrupt the program memory. The each time you use "urls" you have an access violation. Why: If you watch in miniupnpc.c GetIGDFromUrl call GetUPNPUrls witch make malloc on urls. C# seem to not like that. Probably "urls" is not well declared but i can't find the good way to make it run. Be aware that a malloc is done so after use you must call FreeUPNPUrls (struct UPNPUrls * urls) in the dll!!! Solution I've tested its works (no more accessviolation....) -> In Class MiniUPnP (MiniUPnP.cs) i've created: [StructLayout(LayoutKind.Sequential)] public unsafe struct UPNPUrls_2 { public char *controlURL; public char *ipcondescURL; public char* controlURL_CIF; } and [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public unsafe static extern void FreeUPNPUrls([In] UPNPUrls_2* urls); and add a new declaration of [DllImport("miniupnp.dll", CallingConvention = CallingConvention.Cdecl)] public static unsafe extern int UPNP_GetIGDFromUrl ([In] String rootDescUrl, [In] UPNPUrls_2 *urls, [In, Out] ref IGDdatas datas, [MarshalAs(UnmanagedType.LPArray, SizeParamIndex = 4)] byte[] lanAddr, [In] int lanAddrLength); -> In TCUPnPPortMapper.cs: Relace the call of MiniUPnP.UPNP_GetIGDFromUrl by try { //r = MiniUPnP.UPNP_GetIGDFromUrl(url, ref urls, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.UPNPUrls_2 urls_2 = new MiniUPnP.UPNPUrls_2(); unsafe { r = MiniUPnP.UPNP_GetIGDFromUrl(url, &urls_2, ref igddata, lanAddr, lanAddr.Length); MiniUPnP.FreeUPNPUrls(&urls_2); } // Renseigne urls GetUPNPUrls(url); // On se subsitue a miniUpnp pour renseigner urls } Then create GetUPNPUrls (wich replace what it made in dll) private void GetUPNPUrls(String url) { // Copie de l'URL de Base if (igddata.urlbase != string.Empty) urls.ipcondescURL = igddata.urlbase; else urls.ipcondescURL = url; // On enleve tout apres l'URL de base int index_fin_url = urls.ipcondescURL.IndexOf('/', 7); // 7 = http:// if (index_fin_url >= 0) urls.ipcondescURL = urls.ipcondescURL.Substring(0, index_fin_url); urls.controlURL = urls.ipcondescURL + igddata.controlurl; urls.controlURL_CIF = urls.ipcondescURL + igddata.controlurl_CIF; urls.ipcondescURL += igddata.scpdurl; } --------------------------------------------------- This solution is not very nice but it works. I think the best way of correct the bug is to redeclare UPNPUrls but i can't find how to do that. An other way is to modify the miniupnp.dll (remove the malloc) and create the function GetUPNPUrls int the c# code Let me know if you find something better !!!!!

Last 30 days

Older