Issue 182 - dotnetopenid - NullReferenceException in Yadis.XrdElement.searchForServiceTypeUris()

Issue 182:	NullReferenceException in Yadis.XrdElement.searchForServiceTypeUris()
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	andrewarnott
Closed:	Jan 2009
Type-Defect
Priority-Medium
Release-2.5

Reported by wumpus1, Jan 06, 2009

latest dotnetopenid, with AOL hotfix.

when using OpenID:

dbrweb.co.uk

(only one example I know if)

this user experiences:

System.NullReferenceException: Object reference not set to an instance of
an object.
   at DotNetOpenId.Yadis.XrdElement.searchForServiceTypeUris(Func`2 p)
   at
DotNetOpenId.Yadis.XrdsDocument.<findOPIdentifierServices>d__2f.MoveNext()
   at
DotNetOpenId.Yadis.XrdsDocument.<generateOPIdentifierServiceEndpoints>d__a.MoveNext()
   at System.Collections.Generic.List`1.InsertRange(Int32 index,
IEnumerable`1 collection)
   at System.Collections.Generic.List`1.AddRange(IEnumerable`1 collection)
   at DotNetOpenId.Yadis.XrdsDocument.CreateServiceEndpoints(UriIdentifier
claimedIdentifier)
   at DotNetOpenId.UriIdentifier.Discover()
   at DotNetOpenId.RelyingParty.AuthenticationRequest.Create(Identifier
userSuppliedIdentifier, OpenIdRelyingParty relyingParty, Realm realm, Uri
returnToUrl)
   at DotNetOpenId.RelyingParty.OpenIdRelyingParty.CreateRequest(Identifier
userSuppliedIdentifier, Realm realm, Uri returnToUrl)
   at
StackOverflow.Controllers.UsersController.RedirectToOpenIDProvider(OpenIdRelyingParty
openid)

Comment 1 by andrewarnott, Jan 06, 2009

Of course the NullReferenceException itself is a bug, but more interesting is that 
this particular OpenID demonstrated that an OP returns the XRDS document at the Yadis 
location only if the Accept-Types HTTP header is set to the XRDS type.  Fixing this 
resolved the issue.  

This fix will get checked into the 2.5 branch.

Status: Started
Owner: andrewarnott
Labels: Release-2.5

Comment 2 by andrewarnott, Jan 06, 2009

Fixed in two part commits
3ab85f11d69a3059cebac203f77a05fe083d7b65 (branch v2.3)
7fb2d79d903590755ef1005ed28c525a8e1e4f73 (branch v2.5)

The commit v2.3 will need to be merged into v2.5 before v2.5 is fully fixed.

Status: FixedNeedsMerge

Comment 3 by andrewarnott, Jan 07, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 4 by wumpus1, Jan 07, 2009

excellent! Is this checked in and fixed in the latest binaries on top of the AOL fix? 
If so I'd like to deploy it so Technorati users can log in again..

Comment 5 by andrewarnott, Jan 07, 2009

Yes, this shipped with v2.5.2, and that release included the AOL hotfix.