My favorites | Sign in
Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 17: openid.mode persisted across individual login attempts, corrupts later attempts
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  andrewarnott
Closed:  Jan 2008
Type-Defect
Priority-High
Release-0.1


Sign in to add a comment
 
Reported by andrewarnott, Jul 11, 2007
What steps will reproduce the problem?
1. Run the JanRain.OpenID.ConsumerPortal web site project in the source 
tree.
2. Enter a valid OpenID and click Login.
3. Within your OpenID Provider, click Cancel.
4. Again, enter your same valid OpenID and click Login.
5. Continue through your OpenID Provider to complete login.
** Login still fails **

What is the expected output? What do you see instead?
Login should succeed on the second attempt.

Part of what's going wrong here is that the openid.mode parameter in the 
querystring is being persisted across requests, so instead of being a 
simple "cancel" or "id_res", it's concatenated as a comma-delimited 
array: "cancel,id_res".  GenericConsumer.cs:64 is not equipped to handle 
this, as it counts on just a simple string being there.
But the bug may be that we send the openid.mode back to the Provider 
between attempts in the first place.

Please use labels and text to provide additional information.


Comment 1 by andrewarnott, Jan 17, 2008
I've got a fix ready.  I'll check it in later tonight.
Status: Started
Comment 2 by andrewarnott, Jan 17, 2008
Fix checked in r71
Status: Fixed
Comment 3 by andrewarnott, Jan 30, 2008
(No comment was entered for this change.)
Labels: Milestone-Release0.1
Comment 4 by andrewarnott, Feb 11, 2008
(No comment was entered for this change.)
Labels: -Milestone-Release0.1 Release-0.1
Sign in to add a comment

Hosted by Google Code