My favorites | Sign in
Project Home Downloads Wiki Issues Source
Repository:
Checkout   Browse   Changes   Clones  
Revision: 82729fcc8f7e
Author:  comex <comexk>
Date:  Oct 31, 2013
Committer:  comex <comexk>
Commit Date:  Oct 31, 2013
Review scores:
+2 
 -1
Positive:
ExtremeD...@gmail.com,
rachelbryk
Neutral:
yxml...@gmail.com,
tue...@hotmail.com
Negative:
cooooooo...@gmail.com
 

Log message

Merge remote-tracking branch 'shuffle2/vc12'

Conflicts:
        Source/Core/Common/Common.vcxproj
        Source/Core/Common/Common.vcxproj.filters

Affected files

    expand all   collapse all
Modify/Source/Core/Common/Common.vcxprojdiff
Modify/Source/Core/Common/Common.vcxproj.filtersdiff
Modify/Source/Core/VideoBackends/D3D/Src/Render.cppdiff
Modify/Source/VSProps/Base.propsdiff
Comment by yxml...@gmail.com, Nov 1, 2013
vs2013
error C1189: #error :  You are building this module against the wrong version of DirectX. You probably need to remove DXSDK_DIR from your include path and/or _WIN32_WINNT is wrong.

I have installed dxsdk 2010 June
Comment by pascal.j...@hotmail.fr, Nov 1, 2013
Compilation fails from this build on dolphin-emu.org
Can we still build Dolphin on VS 2010 & VS 2012?
Comment by yxml...@gmail.com, Nov 1, 2013
VS 2010 & VS 2012 - - 
this's vs2013 project
vs2010/vs2012 has been removed
Comment by pascal.j...@hotmail.fr, Nov 1, 2013
Well, if earlier versions have been dropped, then the WindowsBuild wiki should be updated.
BTY, was it really necessary to drop those great versions of VS? Couldn't we keep and update the .SLN files?
Comment by ExtremeD...@gmail.com, Nov 1, 2013
Well afaik, soon it won't compile in those versions
Comment by project member comexk@gmail.com, Nov 1, 2013
I may or may not have been hasty in committing this, but most of my motivation to switching from VS2010 to VS2013 is so that Dolphin can use the many C++ features supported by the latter and not the former (and not have to worry about the bugs in the former and not the latter :).  Yes, the wiki page needs to be updated.
Comment by project member comexk@gmail.com, Nov 1, 2013
Apparently I can't grammar tonight.
Comment by tue...@hotmail.com, Nov 1, 2013
If you're going to comment out a call to an unavailable function it's probably wise to set the return value to anything other than S_OK...
Comment by project member godisgovernment, Nov 2, 2013
tueidj: see "hasty", above :)
but, maybe it will give impetus to someone to fix that issue (D3DX11 not available on current DX SDK).
However, that is the only (currently known) regression.
Comment by ExtremeD...@gmail.com, Nov 5, 2013
Is there any advantage to only building for win 8?
Comment by cooooooo...@gmail.com, Nov 17, 2013
XP is dead ...? , dejavu.

Sign in to write a code review
Powered by Google Project Hosting