Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dpi checker does not look at the units #15

Closed
ospalh opened this issue Mar 15, 2015 · 3 comments
Closed

The dpi checker does not look at the units #15

ospalh opened this issue Mar 15, 2015 · 3 comments

Comments

@ospalh
Copy link
Contributor

ospalh commented Mar 15, 2015

I did run mogrify with the LANG environment variable set to German (or rather de_DE.utf8), and when i looked at the output of identify -f "%x" i got 236.22 PixelsPerCentimeter, which, when you convert it, is 599.9988 dpi. (One pixel less for every 21 m than 600 dpi 😕)
That pixel/cm value, or rather the decimal, confused djvubind here. Somehow the ValueError did get caught but the processing just stopped anyway.

P.S.: maybe i’ll try to fix this myself, too.

@ospalh
Copy link
Contributor Author

ospalh commented Mar 15, 2015

<nitpick>I couldn’t help it when i looked at the code, but supplement, two es, no i.</nitpick>
eta:
<nitpick>dto. increment</nitpick>

@Frenzie
Copy link

Frenzie commented Mar 15, 2015

If you're nitpicking anyway, I don't think the word supplement really refers to any of those things. I'd probably use paratext. :-P

@ospalh
Copy link
Contributor Author

ospalh commented Mar 15, 2015

Turns out it hasn’t really to do with language settings but with the fact that i converted from PNGs to TIFFs. I just learned, via Wikipedia, that you can give a pixel density in PNGs, but only pixel/meter.

Personally, i approve of metrications. Don’t get me started on the American non-system of units.

(edited, i tried it with LANG = en_US, same story)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants