Export to GitHub

django-tinymce - issue #63

Import error with Django 1.2 alpha, critical


Posted on Jan 7, 2010 by Massive Panda

Since the release of Django 1.2 alpha, there is an import error on smart_unicode in widgets which is previously imported from django.forms.util and should now be imported from django.utils.encoding, see the attached patch for details.

Attachments

Comment #1

Posted on Jan 7, 2010 by Grumpy Wombat

Agreed, this is critical and the patch above fixes it. Here's a patch without Git's 'a/' and 'b/' paths.

Attachments

Comment #2

Posted on Jan 8, 2010 by Swift Bird

Fixed in r96. Thanks larlet!

Comment #3

Posted on Jan 8, 2010 by Swift Bird

Issue 64 has been merged into this issue.

Comment #4

Posted on May 8, 2010 by Happy Elephant

do note that the fix no longer works with the latest rc1 released. it should be:

from django.utils.encoding import smart_unicode

Comment #5

Posted on May 10, 2010 by Happy Kangaroo

i'm looking at django-tinymce trunk running on "Django version 1.2 rc 1 SVN-13188, using settings 'testtinymce.settings'" with no errors. could you provide more details?

Comment #6

Posted on May 11, 2010 by Swift Bird

I thought that was fixed.

Comment #7

Posted on May 11, 2010 by Happy Kangaroo

i think it is fixed, check http://code.google.com/p/django- tinymce/source/browse/trunk/tinymce/widgets.py

Comment #8

Posted on Jun 12, 2010 by Quick Bear

But it certainly is still broken for django-tinymce 1.5 - I got fooled by "Don't use trunk, use 1.5 release." and ended fixing this on my own, even before I checked this page. So please - change above sentence on the main page to something like that:

"Don't use trunk, use 1.5 release - unless you have Django 1.2".

Please? ;)

Comment #9

Posted on Jun 17, 2010 by Happy Kangaroo

changed project main page text, released dev version of django-tinymce available via PyPI. django-tinymce 1.5.1.dev100 matches r100.

Comment #10

Posted on Jan 10, 2011 by Happy Kangaroo

available in django-tinymce-1.5.1a1 - please reopen issue if problems still exists

Comment #11

Posted on Apr 6, 2011 by Quick Giraffe

Problem exists in Django 1.3 with django-tinymce release 1.5.

Comment #12

Posted on Apr 12, 2011 by Helpful Giraffe

Comment deleted

Comment #13

Posted on Jul 30, 2011 by Happy Rabbit

same thing here, still broken Release 1.5 (2009-02-13) & django 1.3

Comment #14

Posted on Jul 30, 2011 by Happy Rabbit

sorry, my prior comment don't apply actually it's working with from django.utils.encoding import smart_unicode from widgets.py

Status: Fixed

Labels:
Type-Defect Priority-Medium