| Issue 23: | Registering for moderation shouldn't raise an exception | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Similar to the issue in newforms-admin, registering a model for moderation twice shouldn't raise an exception - it's far too easy for things to be imported multiple times just through django's normal operation, and it doesn't seem like anything is gained by throwing an Exception instead of merely ignoring the duplicate registration. If there are options that can be provided with registration like in newforms-admin, perhaps it could merely update the registration if things don't match? |
|
,
Mar 07, 2008
Personally, I think this is largely an issue of people not grokking Python imports and so doing things in ways that put the same thing into sys.modules twice under different names, so I'm feeling like this will be a "no", but I'll think about it a bit. |
|
,
Mar 07, 2008
Well, things like manage.py do that without you even trying, so it's not exactly something you account for all the time :) I've seen that error as well as the one in newforms-admin show up with no sign of any incorrect setup on the part of the user, so it appears to be quite easy to get tripped up by it. |
|
,
Apr 11, 2008
For what is worth, I run into the "is already being moderated" error, but it was indeed a PEBKAC issue due to mismatch in an import (took over someone's else code). So: no idea about newforms-admin, but comment-utils won't raise it unless you actually mess with imports (most frequent being "import projectname.appname.whatever" here and "import appname.whatever" there or some variant to the theme :) |
|
 Sign in to add a comment
|
