Issue 10 - distcc - distcc build fail in filename.c

Issue 10:	distcc build fail in filename.c
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	fergus.henderson
Closed:	Jul 2008
Type-Defect
Priority-Medium

Reported by caffe...@m13.alpha-net.ne.jp, Jun 30, 2008

Building distcc-3.0rc2 fails on i686-pc-linux-gnu with GCC 4.2.3.

Configure with:
CFLAGS="-O3" ../distcc-3.0rc2/configure --prefix=/usr --sysconfdir=/etc
--with-docdir=/usr/doc/distcc-3.0rc2 --with-included-popt --with-gtk
--without-gnome

Console output:

gcc -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/etc\""
-DPKGDATADIR="\"/usr/share/distcc\"" -Isrc -I"../distcc-3.0rc2/src"
-I"../distcc-3.0rc2/lzo" -I"../distcc-3.0rc2/popt" -Werror -O3 -MD -W -Wall
-Wimplicit -Wuninitialized -Wshadow -Wpointer-arith -Wcast-align
-Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes
-Wnested-externs -Wmissing-declarations -pthread -o src/help.o -c
../distcc-3.0rc2/src/help.c
gcc -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/etc\""
-DPKGDATADIR="\"/usr/share/distcc\"" -Isrc -I"../distcc-3.0rc2/src"
-I"../distcc-3.0rc2/lzo" -I"../distcc-3.0rc2/popt" -Werror -O3  -MD -W
-Wall -Wimplicit -Wuninitialized -Wshadow -Wpointer-arith -Wcast-align
-Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes
-Wnested-externs -Wmissing-declarations -pthread -o src/filename.o -c
../distcc-3.0rc2/src/filename.c
cc1: warnings being treated as errors
../distcc-3.0rc2/src/filename.c: In function 'dcc_is_object':
../distcc-3.0rc2/src/filename.c:263: warning: passing argument 1 of
'dcc_find_ex
tension' discards qualifiers from pointer target type
make: *** [src/filename.o] Error 1

Comment 1 by fergus.henderson, Jun 30, 2008

Work-around is to pass WERROR_CFLAGS= to make, e.g.

   sh configure
   make WERROR_CFLAGS=
   make WERROR_CFLAGS= install

Owner: fergus.henderson

Comment 2 by fergus.henderson, Jun 30, 2008

(No comment was entered for this change.)

Status: Accepted

Comment 3 by fergus.henderson, Jul 29, 2008

Hi,

Thanks for the bug report.

I can't reproduce the bug myself, but I think the attached patch will fix it.
Could you please test it?

Cheers,
  Fergus.

	patch
	761 bytes Download

Comment 4 by fergus.henderson, Jul 29, 2008

(No comment was entered for this change.)

Status: Started

Comment 5 by caffe...@m13.alpha-net.ne.jp, Jul 30, 2008

Thank you for your reply Fergus.
This patch seems to works good for me, but build fails in another line.

I got error:

gcc -DHAVE_CONFIG_H -D_GNU_SOURCE -DSYSCONFDIR="\"/etc\""
-DPKGDATADIR="\"/usr/share/distcc\"" -Isrc -I"../distcc-3.0rc2/src"
-I"../distcc-3.0rc2/lzo" -I"../distcc-3.0rc2/popt" -Werror -O3 -MD -W -Wall
-Wimplicit -Wuninitialized -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings
-Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wmissing-declarations -pthread -o src/filename.o -c ../distcc-3.0rc2/src/filename.c
cc1: warnings being treated as errors
../distcc-3.0rc2/src/filename.c: In function 'dcc_is_object':
../distcc-3.0rc2/src/filename.c:274: warning: passing argument 1 of
'dcc_find_extension' discards qualifiers from pointer target type
make: *** [src/filename.o] Error 1

Comment 6 by fergus.henderson, Jul 30, 2008

Thanks for testing it.
Here's another patch that I think should fix all the occurrences of this.

(If it fails, please try "make -k" so that we can fix more errors in one go :)

	patch
	2.4 KB Download

Comment 7 by fergus.henderson, Jul 31, 2008

I've submitted this patch to the mainline.
So as of revision 575, this should be fixed now.

Status: Fixed