Issue 24 - disorder - [patch] Fails to build on ubuntu 8.10

Issue 24:	[patch] Fails to build on ubuntu 8.10
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	ewxrjk
Closed:	Jan 2009

Reported by crazyscot, Jan 22, 2009

Ubuntu 8.10 turns on a number of new gcc warnings by default.

Attached is a diff against disorder.dev. It's pretty lean, should be 
mostly uncontroversial though the fix in libtests was with
a cflag tweak: it's not clear to me how other gccs will handle
-Wno-format-security if they don't recognise it?

I had had an issue with 64-bit correctness in disorder 4.2.1, but they've
been fixed on disorder.dev, and this 64-bit install needed no further fixes.

	disorder.dev.ubuntu-8.10.patch
	2.3 KB Download

Comment 1 by ewxrjk, Jan 22, 2009

-Wno-format-security is recognized by GCC 4.0 which I believe is the oldest I try to
build with any more.  However I'm not sure why the warning needs disabling if the
sink_printf() call is fixed (or removed; I think that code is never actually used).

Compiler flags are set in configure.ac rather than Makefile.am, in any case.

Status: Accepted
Owner: richard+...@sfere.greenend.org.uk

Comment 2 by ewxrjk, Jan 31, 2009

evno: 835
committer: Richard Kettlewell <rjk@greenend.org.uk>
branch nick: disorder.dev
timestamp: Sat 2009-01-31 12:45:22 +0000
message:
  Kill off cgi_attr(), cgi_opentag() and cgi_closetag() which aren't
  actually used (?any more).
  
  http://code.google.com/p/disorder/issues/detail?id=24

Status: Started

Comment 3 by ewxrjk, Jan 31, 2009

revno: 836
committer: Richard Kettlewell <rjk@greenend.org.uk>
branch nick: disorder.dev
timestamp: Sat 2009-01-31 12:55:37 +0000
message:
  Disable -Wformat-security for t-printf, which deliberately uses some
  dubious format strings.  -Wformat-security goes back at least to GCC
  3.0 so it's probably a safe bet to disable without a test.
  
  http://code.google.com/p/disorder/issues/detail?id=24

Status: Fixed

Comment 4 by ewxrjk, Jan 31, 2009

PS.  I think you were right to put the extra flag in the makefile rather than
configure in this instance, though as you'll see if you look at the above change it's
possible to narrow it to just the affected file.

And I forgot to sort out the write() return value part of the question, so re-opening.

Status: Started

Comment 5 by ewxrjk, Jan 31, 2009

revno: 839
committer: Richard Kettlewell <richard@araminta>
branch nick: disorder.dev
timestamp: Sat 2009-01-31 14:57:30 +0000
message:
  Apply the remains of Ross's patch to build on Ubuntu 8.10.
  
  http://code.google.com/p/disorder/issues/detail?id=24

Status: Fixed