Navigation Menu

Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

diso-contactlist #5

Open
GoogleCodeExporter opened this issue Mar 14, 2015 · 4 comments
Open

diso-contactlist #5

GoogleCodeExporter opened this issue Mar 14, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

If you check only that the user registered with OpenID and that the URL
matches, a user could log in with OpenID and then change their listed URL
to someone else's and 'steal' in...

Original issue reported on code.google.com by singpol...@gmail.com on 12 Dec 2007 at 6:56

@GoogleCodeExporter
Copy link
Author

True - the logic for checking these is definitely in need of review. Bring it 
up on the list and let's discuss it.

Original comment by steve...@gmail.com on 12 Dec 2007 at 7:03

  • Added labels: wp-diso-contactlist

@GoogleCodeExporter
Copy link
Author

Okay, Steve here is what I'm getting now:

I've added to my blogroll (on that new 2.3.1 WP install)
  Name: James D Kirk
  Address: http://jamesdkirk.com (which happens to be my OpenID URL as
well)
  Description: My home page

  XFN: rel=me

On the WP-Contacts List Plugin Options page:

If I select the "Username links to blog (No OpenID)", this is the code
behind the output on the static page I created:

<a class="url fn" rel="me" href="">James D Kirk</a>

Clearly, nothing is passing to the href field.

If I select the "Username links to blog or openid (if user registered
via OpenID)", this is the code output:

<a class="url fn openid" rel="me" href="%20">James D Kirk</a>

This time a "space" is attempted to be passed.

Finally, when I choose "Username links to openid if user registered
via OpenID, blogname links to their blog":

<li class="vcard"><a class="url fn openid" rel="me" href="">James D
Kirk</a> -- <a class="url" href="http://jamesdkirk.com" rel="me">My
home page</a></li>

Also, you mentioned earlier about the images (and styles?) not
outputting. I'm not seeing anything in the way of imagery being output
via CSS here, and I believe I have the file structure correct in the
plugin's directory:

wp-diso-contactlist (plugin folder)
  wp-diso-contactlist.php
  README.txt
  /images/
    openid.gif
    /xfnicons/
      7 "xfn-....png" images
  /styles/
    friendlist.css

Let me know what the next tasks are, Steve. At your service!

James.

Original comment by jamesdk...@gmail.com on 19 Dec 2007 at 10:15

@GoogleCodeExporter
Copy link
Author

I found the problem (maybe) default was echoing the unset variable 
$contact_blog_link
instead of $the_link

as a fix:

      $the_link           = wp_specialchars($row->link_url);
+      $contact_blog_link  = wp_specialchars($row->link_url);

Original comment by singpol...@gmail.com on 22 Dec 2007 at 9:27

@GoogleCodeExporter
Copy link
Author

Original comment by steve...@gmail.com on 6 May 2008 at 12:49

  • Added labels: Project-WpFriends
  • Removed labels: wp-diso-contactlist

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant