Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vfs_zip: With some zip archives, files contained in zip will be added twice #932

Closed
Oleksiy-Yakovenko opened this issue Mar 12, 2015 · 8 comments
Closed

vfs_zip: With some zip archives, files contained in zip will be added twice #932

Oleksiy-Yakovenko opened this issue Mar 12, 2015 · 8 comments
Labels
Bug

Comments

@Oleksiy-Yakovenko
Copy link
Member

Original issue 1030 created by Alexey-Yakovenko on 2014-01-08T21:48:47.000Z:

What steps will reproduce the problem?

  1. Have a zip ready that shows this behavior. Not all zips have this problem.

( @ waker: I can privately contact you and mail you a file if needed, since I don't want to cause you trouble on this legal bugtracker with links to copyrighted work.)

2.
3.

(expected)
Each audio file contained in the zip should be added exactly once.

(actual)
It occasionally happens that a file gets added twice.

What version of the product are you using?
trunk, built from git source

Please provide any additional information below.

Since this can also be reproduced with Carlos' archive reader, it appears to be a core issue and maybe unrelated to the plugin as such.
@Oleksiy-Yakovenko
Copy link
Member Author

Comment #1 originally posted by Alexey-Yakovenko on 2014-01-08T22:42:12.000Z:

yes, please just send the file over email.

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #2 originally posted by Alexey-Yakovenko on 2014-01-09T00:00:56.000Z:

mail sent

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #3 originally posted by Alexey-Yakovenko on 2014-01-09T09:39:27.000Z:

<empty>

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #4 originally posted by Alexey-Yakovenko on 2014-01-15T22:06:02.000Z:

fixed on trunk. it was caused by M3Us present in the archive.
the fix makes so that playlists are not being loaded from archives, the same way they aren't when adding folders recursively.

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #5 originally posted by Alexey-Yakovenko on 2014-01-16T22:26:22.000Z:

well done! (as usual)

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #6 originally posted by Alexey-Yakovenko on 2014-01-16T22:28:17.000Z:

however, now the question is...will the archive reader plugin (Carlos' one) be able to utilize your fix as well or will it have to be fixed separately?

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #7 originally posted by Alexey-Yakovenko on 2014-01-17T08:18:19.000Z:

he doesn't need to fix anything for this case.

@Oleksiy-Yakovenko
Copy link
Member Author

Comment #8 originally posted by Alexey-Yakovenko on 2014-01-19T22:43:27.000Z:

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Oleksiy-Yakovenko